Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7492DC7619A for ; Tue, 21 Mar 2023 16:43:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230184AbjCUQnD (ORCPT ); Tue, 21 Mar 2023 12:43:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbjCUQmy (ORCPT ); Tue, 21 Mar 2023 12:42:54 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA787515C9; Tue, 21 Mar 2023 09:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jsbGFAPDCCg1dpVP/wNsQmBc5RaDf7+l5JCSc8t9iVo=; b=FhnEeA6H4LtXOaucATPKvixKkl RYM9VcfEKEv1zcsXDwbruTgihnGwu/d/9AAISum2o32B2CZYg0W//xM1V4aoWZ0u4aPOiYRd+AwJV RTSLEVcH1DLOpMhrHMvFBrk1hmSbgkWGUFD094FO5gTCnQyHxDh9GIg0m95lnWMzk/dQodobrYNKk xMAU9eMId00FGTiOlziX10V0R1leDkMXedb0oyrIE08frrnG1gHxZMQKJAPhnA5WBPuijWS3Yb1Cj fxFgXB10JU2hjdg8AzhphoLvW2D6/bbB5yC2JPDPOgRtWhIxxdvRGAx1a6QX364L05SExMP7BUTol Hqx1+ZZQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pef4C-002CVB-I5; Tue, 21 Mar 2023 16:42:32 +0000 Date: Tue, 21 Mar 2023 16:42:32 +0000 From: Matthew Wilcox To: Yangtao Li Cc: Alexander Viro , Christian Brauner , Andrew Morton , Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] fs/drop_caches: move drop_caches sysctls into its own file Message-ID: References: <20230321130908.6972-1-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230321130908.6972-1-frank.li@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2023 at 09:09:07PM +0800, Yangtao Li wrote: > +static struct ctl_table drop_caches_table[] = { > + { > + .procname = "drop_caches", > + .data = &sysctl_drop_caches, > + .maxlen = sizeof(int), > + .mode = 0200, > + .proc_handler = drop_caches_sysctl_handler, > + .extra1 = SYSCTL_ONE, > + .extra2 = SYSCTL_FOUR, > + }, > + {} > +}; Could we avoid doing this until we no longer need an entire zero entry after the last one? Also, please post scripts/bloat-o-meter results for before-and-after.