Message-ID: <826882c1-a893-d325-7031-0bf4f7aa7f2a@oracle.com>
Date:   Tue, 21 Mar 2023 17:52:09 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v1] scsi: scsi_debug: Remove redundant driver match
 function
To:     Lizhe <sensor1010@163.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230319042732.278691-1-sensor1010@163.com>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20230319042732.278691-1-sensor1010@163.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1Q2bmltL0lDUmlPM1p5dmpjSFQ3RUF1SVUvTDZORlZJWFNRaVg1TDdnc3VD?=
 =?utf-8?B?NjVmL2JLMnFTVjNpMlRuWDhEWUo3Mk1sM29ieUgxMGYyS2VWUXYrOVUxUnkw?=
 =?utf-8?B?RHNSRk9lRXY4WFpTSVJNWXYxOS9BZ2FaZXpYTEdHMjFSWVhFNVhKdFJpMEpC?=
 =?utf-8?B?SktET0FVNDE3UHRGWXhjM0t2UUFBS2VQbHVXb0lBa1RYakFoMm5meElTRGs5?=
 =?utf-8?B?RTlBVXYzTW9wWjJxVzczdm5KbExYRndvaDNod1oxd1VITFlaTkRSM1NtTzFt?=
 =?utf-8?B?UGJMREM0ZVJxMkQ2TjFrcjlJZWQxcDdTNXBaeURVamVraUROKzhlZGMwWUla?=
 =?utf-8?B?Y1B4Ri9SV1M1UUFkanFRMEVTMk5FeVNPM09QMmlaZlVsNzgrYnUwZzY4RitC?=
 =?utf-8?B?bWlrZTFvUjRpMW9SUE1ZQ09ETUtLVlFLaDg3cVdISkJDZllKY1NVdkRZSldC?=
 =?utf-8?B?SUZ3bDZpL3FoMVkxd1hFMmNpOVA5a3lnaHlHTkNQZ1VKNkE4UHk0SGxqUEg4?=
 =?utf-8?B?eGdRS1UvMTdlaG14RFpNLytIbDQxeDBOaThmd09wMzhHaWtDdHZUUHM4SnZU?=
 =?utf-8?B?ajNWQVUxdXA4L2dpSFUzOWpxSHN1SDBtcW5PaDZYRnlJa3ZZeDQrQldRTGxG?=
 =?utf-8?B?TGhwWVNkTHh6alR1SnBxcjRQM2tBUDQ4cXJTV2REcnpUUFRDa3oxTmNLN21a?=
 =?utf-8?B?dEgxUFpUNjN0eWp6L1dBM2lkZkNYTkpteWJIUmZGSWJqc2RHTU9pc2paNXA3?=
 =?utf-8?B?STloclR1UkJSYUVhVnlrelozK2wzV0xJVVlqZ0hDNE1CdXg5Z01SSE1PU1pK?=
 =?utf-8?B?RDg1MmFoY1RNd3VtcFVyUTRSQUtFSnJOWlJxNHViK2lvY2ZDZUZuQllFN0VN?=
 =?utf-8?B?bWhqL1lSU3pPeERtZVNNa25QMFZoRWMwYUtmSFlpSVEyZVdaaFplcVNsOElY?=
 =?utf-8?B?UE9GVHptbnJNbm1QZ2R5SlQvN2lvMkJwejl2c1YzUG1nVUc3aEdjUlZzSmFw?=
 =?utf-8?B?dnNiajh2Mys2RG5DZUpGMTNEQVEwVUNwWGdqL3V0QmwyZUNVdElWcXpuNHZz?=
 =?utf-8?B?UUVEU1pDK3V3TXJ3SGhKMWkySUU1U0U0NmxEaG1ISkd6OVk0WlRjZ2FQUENv?=
 =?utf-8?B?TG1QRTRtU3Y5TzNUYVpRN2M1V1d6SmNqeE5kNGZJYkRZWUd3SjBGUEJ0bGtP?=
 =?utf-8?B?dGd5WDQzYVQ1Q3ZaQkxDUUN6VEMwS3dud1R6T0o2RHJHWFNwbGdHT1NiWkpL?=
 =?utf-8?B?UVQ3bmVqSkoyN3diL3pUQ2VNOXA1ZUZDR2g5UnZLSGFhQ1hjajIrRyttZkFy?=
 =?utf-8?B?a1YyRjA3NzFRelhrbUEzNkpQNzJtOHdQQXF2d2w5VFh3NDdSWlQ1VE5LVXFY?=
 =?utf-8?B?MVg5MDJOZE55Vzd3YkZkSTlNVHFWdTJObUpUTmR1MjlvdXVWcXZKdWhiZVRK?=
 =?utf-8?B?WGNiWVdpbGdjdnF2RnZ6N3RLdXhiNktNQTJaRk1KRkFUdUg5enkzRTdzbkVD?=
 =?utf-8?B?dmNaQlV6a01kUGNOUWwxMWVjd3VJc3c1MVhHeUpSM0x6YUJMWUt0eGlsTVE5?=
 =?utf-8?B?MXdQdWZGaEx0WjVUdUhQRUhhUG9hM3ZjSTkvWWttY2pTNFRhbTh3bDF4TUlR?=
 =?utf-8?B?QUpFbHhFWXNOUjhqbHl1R3VwL2grcGVoSVcrMEsrSHRhR1k2TWVycGZwM3FI?=
 =?utf-8?B?Vmk4SHV2TFBKVHdzeXIxTG41UDg4Mlg5Y2dQNDVvWU9vZDc0RlFTODRncnpz?=
 =?utf-8?B?MC9vM2JoK0VCdHphREc3dk00WkpxQ0F4TmV4ekkvcStLdm1WcEUzWldmdjVI?=
 =?utf-8?B?dlgwdlFRSG5YY25GOGNQWkFFMWhJUVdiYTdXOGcyK1Rsb1hhc1FCbWRHK2Vz?=
 =?utf-8?B?Sk5FeTFMLzRubndGOW05LzlCKzhpbHhNUDBKK2hXSUpuRk0wcy9scU5hWFc1?=
 =?utf-8?B?L25waDhEMDBWUHNtM2VqUlJBWnZWdURyb2JMckFjU3hKK2J6S0hxdTUwTWY4?=
 =?utf-8?B?WkFaeWNQMUllTWFpZlMzRitkTXBwV2F5N2tFaWtYcEZ2NllGOVNqMkpTUFZM?=
 =?utf-8?B?TmlnSVlUS0Z1b1o2RHpjLzR6R090b3l1ZHRuTGJKMUZ6Z0VOWU1BOUVpRDhM?=
 =?utf-8?B?VnVidFVhQTV1dGVyNlJoRmRCS0dhbU40SHg1clZIOE9GOTZLbGIwamNRak9m?=
 =?utf-8?B?K0E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: WgczDx8LdsLZYW2fBismvhOzFVENTrk8lQSWgaya+eVXkmsnLW9nxxWdt5Rm3e/09f3x80sjIR8/n/+37Di46DRG0wjhWRAFS4p4N26c8K/ArCcx3eHM3RuTzHezPGJbj2OjFRFyk5zivQfqFa+8S58uo3Pu+iqUFPBaMnbu5iAHmum6uL5nvSQ9r+hNMLoMRQmqZ+YXrwDw0kBUIxDVGJiJqNTEX6D/2s48mAdPaHB24bCQZxdszb7uv55bx6fJVJsWrb8RZf+8cv5viI7lAKaCkNYRlaQKd4eo9mfOgBob/Ihj7Ec4G03nZskHtaBj0OUnrdJ74/twrwbRhKWGmq9L6LHlIv5xrkMBs6UlIG8QokdlMziZDyodhq9CtO6KdWEdvvJet4JYQacTWwTQglbgiNO+FAN+/Xnb7CVcbVHba+gRWfh6tanggzAiAqnBiXNBcZdImH72sQpqFEx6mwJEU9m4sd8gkA8R9SGXRhDIzTqL6bncxTz3gRdCeugFzBILqj8lSV2DTXVw7IvNKVfq4rWwYsTgGXRRTHKwcaA91Eh8mNr6i8jJ0rh7PHjucUooY80883M555iFN0pcELu+mjfVyTaFoUmbgGX9jjosbBpEH9BffP4IhpKCeiYbM/FRW3XMo61h7ZdELPboJbwN4ialjsKktcUt7nLU/sLQPYfCFEUkitUCOBrQu7X0Pp5nO2V6YYfr7WzgI7NCfFfoI1P+4zmNFvhH1ISoWYOtzhYyP9MkXwyWfqX0GvK2eQZHSE0jInKgpgZNp6gdi1cotkMudzNgIRVDxPb9NWyDt+PmJ+F9hIvXxCKQ8kbJ
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2268660-8953-47f8-d540-08db2a35014a
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2023 17:52:14.9340
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zRfBW7s/GZfDS3ni/kUeJBfxyT+mtPwksErR/T1OHab7piGVj3ZAkBO6Ljigpk6nFSTT43k5iZA6r2gwOtQHuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5322
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-21_11,2023-03-21_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 malwarescore=0
 phishscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002
 definitions=main-2303210141
X-Proofpoint-GUID: nH4rQkL4KiM1opHLf4NOsDEX-dzMR_-W
X-Proofpoint-ORIG-GUID: nH4rQkL4KiM1opHLf4NOsDEX-dzMR_-W
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19/03/2023 04:27, Lizhe wrote:
> If there is no driver match function, the driver core assumes that each
> candidate pair (driver, device) matches, see driver_match_device()
> 
> Drop the pseudo_lld bus's match function that always returned 1 and so

I'd have "Drop the pseudo_lld_bus match function .."

> implements the same behaviour as when there is no match function.
> 
> Signed-off-by: Lizhe<sensor1010@163.com>
> ---

Reviewed-by: John Garry <john.g.garry@oracle.com>