Date:   Tue, 21 Mar 2023 19:02:40 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Anshuman Khandual <anshuman.khandual@arm.com>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        will@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com,
        James Clark <james.clark@arm.com>,
        Rob Herring <robh@kernel.org>, Marc Zyngier <maz@kernel.org>,
        Suzuki Poulose <suzuki.poulose@arm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-perf-users@vger.kernel.org
Subject: Re: [PATCH V9 00/10] arm64/perf: Enable branch stack sampling
Message-ID: <655ff114-99d2-4612-9167-cc8688f2b6b2@sirena.org.uk>
References: <20230315051444.1683170-1-anshuman.khandual@arm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ZiGw5SLj3JFuo5Bg"
Content-Disposition: inline
In-Reply-To: <20230315051444.1683170-1-anshuman.khandual@arm.com>
Precedence: bulk


--ZiGw5SLj3JFuo5Bg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 15, 2023 at 10:44:34AM +0530, Anshuman Khandual wrote:
> This series enables perf branch stack sampling support on arm64 platform
> via a new arch feature called Branch Record Buffer Extension (BRBE). All
> relevant register definitions could be accessed here.
>=20
> https://developer.arm.com/documentation/ddi0601/2021-12/AArch64-Registers

While looking at another feature I noticed that HFGITR_EL2 has two traps
for BRBE instructions, nBRBINJ and nBRBIALL which trap BRB INJ and BRB
IALL.  Even if we don't use those right now does it make sense to
document a requirement for those traps to be disabled now in case we
need them later, and do so during EL2 setup for KVM guests?  That could
always be done incrementally.

I've got a patch adding the definition of that register to sysreg which
I should be sending shortly, no need to duplicate that effort.

--ZiGw5SLj3JFuo5Bg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQZ/08ACgkQJNaLcl1U
h9A2Vwf+OlSvXdhyewDkyTQV0UhoX80wH9Aki8JnkTGnz29AiHDh9G1abuOJhkLZ
ipMeXx43tHlF37e44zk90Xl1TsyPuX0mCOIGwdfqyZCO8MPNA3nehtCuvm2pLgVd
ONOD6HZp9VM6sh3itx3EBI7Z37qrZ2MjO8VyYE0z6VHT2ZH3MJZaaUlqepBF2aP2
n3VpRR9ZdUpZI1oSlZJa1a9o4JRXknDgHKYkuj7Lp9naeBOuoNzSUm/SYB9RxDXu
FDU/RzYV6oCAfAEvb3H1Cr4SEpyK+TLcRGQ78JlFVZQOEAECtd8NjnxZebA9pRAK
XGMS2wcFvKk/Zqzbr6qxNyBJliQJsw==
=U6ZJ
-----END PGP SIGNATURE-----

--ZiGw5SLj3JFuo5Bg--