Message-ID: <7349a16f-6e7e-51d4-4686-ec7e688d891b@alu.unizg.hr>
Date:   Tue, 21 Mar 2023 21:13:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: BUG: scripts/kconfig/merge_config.sh: typo in variable name
Content-Language: en-US
From:   Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
To:     linux-kbuild@vger.kernel.org,
        Masahiro Yamada <masahiroy@kernel.org>,
        Mark Brown <broonie@kernel.org>
Cc:     linux-kernel@vger.kernel.org
References: <17ab5a21-5512-5388-f9fa-c462b2ebd351@alu.unizg.hr>
Organization: Academy of Fine Arts, University of Zagreb
In-Reply-To: <17ab5a21-5512-5388-f9fa-c462b2ebd351@alu.unizg.hr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 3/21/2023 2:04 PM, Mirsad Goran Todorovac wrote:
> Hi all,
> 
> There is a typo in variable name in scripts/kconfig/merge_config.sh, with the
> script returning:
> 
> $ ./scripts/kconfig/merge_config.sh -y -m ../.config tools/testing/selftests/net/config
> ./scripts/kconfig/merge_config.sh: 148: ./scripts/kconfig/merge_config.sh: Previous: not found
> 
> Problem is probably best explained by this diff:
> 
> ---
> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
> index 32620de473ad..902eb429b9db 100755
> --- a/scripts/kconfig/merge_config.sh
> +++ b/scripts/kconfig/merge_config.sh
> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
>                  NEW_VAL=$(grep -w $CFG $MERGE_FILE)
>                  BUILTIN_FLAG=false
>                  if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then
> -                       ${WARNOVVERIDE} Previous  value: $PREV_VAL
> +                       ${WARNOVERRIDE} Previous  value: $PREV_VAL
>                          ${WARNOVERRIDE} New value:       $NEW_VAL
>                          ${WARNOVERRIDE} -y passed, will not demote y to m
>                          ${WARNOVERRIDE}
> 
> Hope this helps.

P.S.

Later I thought of searching the committer of the patch that introduced the change,
so I Cc:ed Mark.

Best regards,
Mirsad

-- 
Mirsad Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu

System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia
tel. +385 (0)1 3711 451
mob. +385 91 57 88 355