Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH 0/3] iio: adc: palmas_gpadc: add iio events
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <20230319223908.108540-1-risca@dalakolonin.se>
Date:   Tue, 21 Mar 2023 21:40:04 +0100
Cc:     linux-iio@vger.kernel.org,
        linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        letux-kernel@openphoenux.org, kernel@pyra-handheld.com,
        pgoudagunta@nvidia.com, jic23@kernel.org, lars@metafoo.de
Content-Transfer-Encoding: quoted-printable
Message-Id: <F099D3A8-5A60-47F4-A329-3AE6CF82848A@goldelico.com>
References: <20230319223908.108540-1-risca@dalakolonin.se>
To:     =?utf-8?Q?Patrik_Dahlstr=C3=B6m?= <risca@dalakolonin.se>
Precedence: bulk

Hi Patrik,

> Am 19.03.2023 um 23:39 schrieb Patrik Dahlstr=C3=B6m =
<risca@dalakolonin.se>:
>=20
> These changes are based on [1] and [2].
>=20
> The palmas gpadc block has support for monitoring up to 2 ADC channels
> and issue an interrupt if they reach past a set threshold. This can be
> configured statically with device tree todayi, but it only gets =
enabled
> when reaching sleep mode. Also, it doesn't look like anyone is using =
it.
>=20
> Instead of this one special case, change the code so userspace can
> configure the ADC channels to their own needs through the iio events
> subsystem.
>=20
> Thresholds and events were tested on omap5-uevm board. It should still
> be possible to wake up from sleep mode on events, but my board don't
> like sleep. A userspace tool for monitoring events and adjusting
> thresholds can be found at [3].
>=20
> [1] =
https://patchwork.kernel.org/project/linux-iio/patch/20230318163039.56115-=
1-jic23@kernel.org/
> [2] =
https://patchwork.kernel.org/project/linux-iio/patch/20230313205029.188174=
5-1-risca@dalakolonin.se/
> [3] https://github.com/Risca/pyra_vol_mon

nice to see the code here!

I haven't tested it yet and will just comment from code inspection.

Maybe it could be good to add linux-omap@vger.kernel.org because the =
Palmas is mostly used for OMAP devices.

BR,
Nikolaus

>=20
>=20
> Patrik Dahlstr=C3=B6m (3):
>  iio: adc: palmas_gpadc: add support for iio threshold events
>  iio: adc: palmas_gpadc: remove adc_wakeupX_data
>  iio: adc: palmas_gpadc: remove palmas_adc_wakeup_property
>=20
> drivers/iio/adc/palmas_gpadc.c | 527 +++++++++++++++++++++++++++------
> include/linux/mfd/palmas.h     |   8 -
> 2 files changed, 434 insertions(+), 101 deletions(-)
>=20
>=20
> base-commit: 37fd83916da2e4cae03d350015c82a67b1b334c4
> prerequisite-patch-id: 9b1f55610800b91b721d042bf7f33b58179237d1
> prerequisite-patch-id: b0418c707db13f514400956596e9ebe91c25bba0
> --=20
> 2.25.1
>=20