Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5295296rwl; Tue, 21 Mar 2023 16:54:03 -0700 (PDT) X-Google-Smtp-Source: AK7set/IumymXthDW9AOpIDAx/vdAokuN0PllQfirZV2f+fVgRZhRb1mALZoLAXOdFJ0p+4jXf6V X-Received: by 2002:a17:90a:cf06:b0:234:117e:b122 with SMTP id h6-20020a17090acf0600b00234117eb122mr3727115pju.0.1679442842809; Tue, 21 Mar 2023 16:54:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679442842; cv=none; d=google.com; s=arc-20160816; b=sQyhquWHjDzv0oWiNKJv7JneZ/sqKfwxNdykviw6NKZvbQz7DIoF31QUeEKdpbaJYm ys8yIPZI3hsgYsw0U9+m39ffeBe3wAlB1IP61gj98tkaWyqM5VisCy1AEhvO7KJzYHxi xrMxE3K06pFgijWf4YsQ2lMRA/8oAmdBVD/O+xtfmdyyVOFQcMSohctN6aJY+S2/mB4n kDXyw69ehqOKhF8ULtRdF5lVI47z5ih01Tw4rjPCJddcb5FFTyDHCiD/Q0JdgyoSMFa5 HbXGG0rVpEO10VcTITuQKA8tE5yewqrQ08oLBKl6oPZNGRMT/upKGyA1vvuPEo5f0I3L BmFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:cc:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=u3FIUoADjtoydcrO6I/aan1rZmbX5WL1LF1a+25+YAU=; b=oRlfVZAFph84rzrAC6vOp8MkRh8y68ggOV5S/94yHweQVZ3q3f+jhjvEm5ZTcfUsbE 8iuzAOvjuw1T5jdUbl3rbM1afdjhMuC37W0Rp9KF6MUOu4KJ3D4Tq91IV7FietJxsyPA Oc4gGDcwEiaZkL2w77wH/yftUfffUI/9i+MHEYCGPmWGWG07S5qoF1s4PNEN7EckKnQD X2jCLBWe5qIoIBwKNa8P5jDCu0AtrlTNtnOspy9NiYf9UXRyAZ1d79D3BR9TSAnVginu IbDCCr8tkzlgZgL++5qaOEtpXnSRvNLSl8ULy2drPAb9MV/nHo9m3e6xlgmRcpQW1PBS TXsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=h1Hu+DeU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e16-20020a17090a9a9000b0023b3401ef14si19671188pjp.62.2023.03.21.16.53.51; Tue, 21 Mar 2023 16:54:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=h1Hu+DeU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229555AbjCUXxM (ORCPT + 99 others); Tue, 21 Mar 2023 19:53:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbjCUXxL (ORCPT ); Tue, 21 Mar 2023 19:53:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05A33900B; Tue, 21 Mar 2023 16:53:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 94EF861EE5; Tue, 21 Mar 2023 23:53:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8E6DC433D2; Tue, 21 Mar 2023 23:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679442788; bh=u3FIUoADjtoydcrO6I/aan1rZmbX5WL1LF1a+25+YAU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=h1Hu+DeUR3VZRZVBG2jNUJRWJu0N59GwVNc5RxyKN/BoFepQ+v7/623jG/Ui20DH+ 5VWLZYUaixBqgHl3Rv33CPCTIjYqfRyOKfujqfjP9ssGc8NImR+LbZ6FBNB28+2jGg pcgkiozLHv47BpRX6trD7iM64iSY6v+Zmk9WQRN/YtHKHsfkrMM2TF07MvVmtzpUQH XqssElxcEcxJV+dOkTiV29n9HwVZZCI/eckjHmpOxIPBCT84d9Hh1edGnJIGVECX1m ngKMkmzTKdWqANJ/xjBNfFV3yB3zdhd46RTvxpO6PSnYu0z9cHXm9wYMVQKjNl5VQF rb4islGZnEV8w== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20221209152913.1335068-2-marpagan@redhat.com> References: <20221209152913.1335068-1-marpagan@redhat.com> <20221209152913.1335068-2-marpagan@redhat.com> Subject: Re: [PATCH 1/6] clk: socfpga: use of_clk_add_hw_provider and improve error handling From: Stephen Boyd Cc: Marco Pagani , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Dinh Nguyen , Marco Pagani , Michael Turquette Date: Tue, 21 Mar 2023 16:53:05 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Marco Pagani (2022-12-09 07:29:08) > The function of_clk_add_provider() has been deprecated, so use its > suggested replacement of_clk_add_hw_provider() instead. >=20 > Since of_clk_add_hw_provider() can fail, like of_clk_add_provider(), > check its return value and do the error handling. >=20 > The indentation of the init function parameters has been aligned > to match open parenthesis, as suggested by checkpatch, and the __init > macro moved before the function name, as specified in init.h. >=20 > Signed-off-by: Marco Pagani > --- Applied to clk-next