Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5295853rwl; Tue, 21 Mar 2023 16:54:47 -0700 (PDT) X-Google-Smtp-Source: AK7set+DRElYl4lJ5rp5GSl0IKWSDAKP73Khg7PRYV/kH0n84OJuJSFlVmn8A206oZfXiN4iVBlL X-Received: by 2002:a17:902:ceca:b0:1a1:d395:e85c with SMTP id d10-20020a170902ceca00b001a1d395e85cmr4121389plg.0.1679442887293; Tue, 21 Mar 2023 16:54:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679442887; cv=none; d=google.com; s=arc-20160816; b=Y44BYuAJpM7V0Sf8UwUbqK7q5exXlCs2W67CB7Q10tMBpz3WDgDRUFBdwXgghRe1Sp fNNn9NhyeCrkLK3caUnoFAhb0qfT3jwSrWABlC4f8PKihjcVZ8/Y+7vZ7ZvJpvEsWD+/ a7GWdZpZvI1hZCXI5NWCKyldcOA2+bOZ/V7YQ/XCnpY7wJd9vGujwLQbG/S8WsV2NCat dECuZWHEa0DB+cr01TKG//rIDwaYInkoWEJ9qg1XQR+b4W9pVnKxLn3T2S88mXE1upRU V66d2z0/I/7EugsSxKP/6wJUBSYUGMvrDMrtg7kOnbbzONGMPx8TdzeGV6g05bag5wzS Mmkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:cc:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=nZcWtrnvUENMdJls1cCb4n1S+DLhWd2T2Qa8EAikTqE=; b=B06b9BrPkyYFUtmjaA88f+QvSOWUHIh5PRQXHwDKrWndvq+7QwMX1u9SasnI+PJJTo ZXE8xTKSNED6RhdaZH6ZNzFkXn9vNtj9YyHl03C2rVIBFyNfK8ZnabjNmABFK+wzdPT4 MskZutPseUrc/ExZo0hLpyrdcUBwPyC2/X+5G//RAL1atLLGLmZAW6mik8Yy0b7LOJ8b ++fRbtBpSAo/meM9mUredErgYDTKCGCytyI7PcFzyr6P5Wi2aD/IZaql28mkSw8A4vo+ pMO66V+EHCVQ9tHw/Na+yS8x+7YmcfRHmIRg6wqfjFs0MXf4sC8jlvpipfOXW+uOQ+gl uZvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="P/8HhZDc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lf15-20020a170902fb4f00b0019e67626276si13835985plb.392.2023.03.21.16.54.35; Tue, 21 Mar 2023 16:54:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="P/8HhZDc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229878AbjCUXxf (ORCPT + 99 others); Tue, 21 Mar 2023 19:53:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229713AbjCUXxc (ORCPT ); Tue, 21 Mar 2023 19:53:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FC2658B74; Tue, 21 Mar 2023 16:53:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CD9BDB81AB8; Tue, 21 Mar 2023 23:53:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CAECC433D2; Tue, 21 Mar 2023 23:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679442806; bh=nZcWtrnvUENMdJls1cCb4n1S+DLhWd2T2Qa8EAikTqE=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=P/8HhZDceLjYkoL0Fm5ngMBupIoI+lhtAponOMcoXyNL3fn15za7sctuewb5Gxhxb 67klz/FlOWs5ZFiCsVfb85OCN/T76shqpAf4bNowam9I3tUDT6mcTVb8WuzjEsz2cO ZgH1lm3mdMSTsDROYtmPd8yG4IBC7BSbB4ZUp7VDJY3vWZwQ2RXOKhwDQILuKJd4lQ Coxp4/CGaO5BAEiFy7s3S5fxfjocr99X4GGGngC6hjzdNnYYXF787uDdkkU+JwAB3b YPtfnNOlr9aycpb9mrrdLRu/T9bZYHEkKaWx9DAOz8aJkh+xtoSM2g2orxi/CeIjlw 8BUBm/26mPRHQ== Message-ID: <21fc28cccf3b9fa64428ddc9085deb63.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20221209152913.1335068-4-marpagan@redhat.com> References: <20221209152913.1335068-1-marpagan@redhat.com> <20221209152913.1335068-4-marpagan@redhat.com> Subject: Re: [PATCH 3/6] clk: socfpga: use of_clk_add_hw_provider and improve error handling From: Stephen Boyd Cc: Marco Pagani , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Dinh Nguyen , Marco Pagani , Michael Turquette Date: Tue, 21 Mar 2023 16:53:24 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Marco Pagani (2022-12-09 07:29:10) > The function of_clk_add_provider() has been deprecated, so use its > suggested replacement of_clk_add_hw_provider() instead. >=20 > Since of_clk_add_hw_provider() can fail, like of_clk_add_provider(), > check its return value and do the error handling. >=20 > The err variable unnecessarily duplicates the functionality of the > rc variable, so it has been removed. >=20 > Signed-off-by: Marco Pagani > --- Applied to clk-next