Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5296665rwl; Tue, 21 Mar 2023 16:55:41 -0700 (PDT) X-Google-Smtp-Source: AK7set9UfwiYtpyT/dCtihvwdvCzUAZsdCaPWBM/wTC3WmODArLjP1PSEpGHUj5wmrSl4Wg4QgB9 X-Received: by 2002:a05:6a20:6914:b0:cd:2c0a:6ec0 with SMTP id q20-20020a056a20691400b000cd2c0a6ec0mr3573236pzj.3.1679442941592; Tue, 21 Mar 2023 16:55:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679442941; cv=none; d=google.com; s=arc-20160816; b=KoLLMbXVytaKXo2wRmI+mwIkwTbG//CLl79Ced8TlTte4hl05SV38zHNHvEe7b2Tv3 QuKenhJwZZk+3GJG7OEJsIIuLpQ830zwUf42WIhs8OT6IjSVb8/gnGUeZ3v19Rp34DYm MrVU3bx4qWT+M2ZQh5iZZJcpFj3LlWc3ihf6Vbqj8uhhUWxPhJyJC+5KAvLJ7uCp34f4 3FNfgdRLeTmc8y5ZasheSbLH5H9IQBoZesNJOCNOt9XUinCEuu31s0gVyIywpdMUrjnL j4ydgVd4P0GuPn7tfv25FmCT2UQJSEXv17vA0mE2l7573lfeB+3OhNv1VynC4XrZ0q7p JcDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:cc:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=Se62AcjZEbRL9aU/OO95SPGgaa/PfL/hcFXxxs6W4G0=; b=MXM/D52MxXxOIPfwdsFXjyUcdrna+4HycfY0qLN7l9alXlwZF71VYDsRFPwK1l63xh usIf28od7yWLHR+Ey2gbaoqZlx4u1ZVq7chBwJaH6Qn3fHZFNmXjm0Y+Gxd4HfuXUB9h sSAYrKaZ10Mp7hlR9vb3ifKxx6X/Hh4M8FF+96nzt8PLFHSvwy2grzJHZrNrVkccyTiA ZIRvBNjTuTWaETXkl9Pi1D7Pk9+gGQuPvrmqyCVM4TbNaiIyEg81/Fs3liI7TYqs9KVv 7L12f7VQ+cutXiXtZCh6WVdiiTBZHUqg96rK88CYsME9RkA+RosThYzFFELSY3dMcKTh CJZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="FI/d6pDx"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 28-20020a63115c000000b004fd72ee1e38si13628462pgr.748.2023.03.21.16.55.29; Tue, 21 Mar 2023 16:55:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="FI/d6pDx"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229942AbjCUXyH (ORCPT + 99 others); Tue, 21 Mar 2023 19:54:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229713AbjCUXyD (ORCPT ); Tue, 21 Mar 2023 19:54:03 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DE0D24BE7; Tue, 21 Mar 2023 16:53:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8547DCE1B99; Tue, 21 Mar 2023 23:53:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4A5DC433D2; Tue, 21 Mar 2023 23:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679442827; bh=Se62AcjZEbRL9aU/OO95SPGgaa/PfL/hcFXxxs6W4G0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=FI/d6pDxJ6Idr3dco1XDBXPi+ZyFLwVSffYeTmO4Sz2ph24n2fKyyK+mIswHebjd7 qlXoewwBY+hl9zSL6FaBZj/7SN6WIZr8EsVG4CWlNa2grbCLjekWETUfvsLgKSPxUP uJN895g8tIv7+QzFBzXW2xODVquAYWMh9Bdvko40hSqQPi1B3ygQvSWorYnFy6sBYp b2dRSBAdNbT7a+hwfXUcCZvA9TwHL4wNUARwsunBN6cEXX4WOXSB3Yk1VeprVbMsyY Jc5GCEIgTL2i8WeF6KnsV5LyqYOOZz805tq/3jxrpYmCm9e3CqG5dS4JuVXDLEJMNu mAcnDLj0svyyA== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20221209152913.1335068-6-marpagan@redhat.com> References: <20221209152913.1335068-1-marpagan@redhat.com> <20221209152913.1335068-6-marpagan@redhat.com> Subject: Re: [PATCH 5/6] clk: socfpga: use of_clk_add_hw_provider and improve error handling From: Stephen Boyd Cc: Marco Pagani , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Dinh Nguyen , Marco Pagani , Michael Turquette Date: Tue, 21 Mar 2023 16:53:44 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Marco Pagani (2022-12-09 07:29:12) > The function of_clk_add_provider() has been deprecated, so use its > suggested replacement of_clk_add_hw_provider() instead. >=20 > Since of_clk_add_hw_provider() can fail, like of_clk_add_provider(), > check its return value and do the error handling. >=20 > The return type of the init function has been changed to void since > the return value was not used, and the indentation of the parameters has > been aligned to match open parenthesis, as suggested by checkpatch. >=20 > The err variable has been renamed rc for consistency. >=20 > Signed-off-by: Marco Pagani > --- Applied to clk-next