Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5296996rwl; Tue, 21 Mar 2023 16:56:00 -0700 (PDT) X-Google-Smtp-Source: AK7set8Zg0nIh8QB63uqmD7x9t0TkLtfytxbreK+WDvw0zUXYUVCBOIg/IVkVx7LBvmAM+8BTAQd X-Received: by 2002:a17:90a:5609:b0:23b:35cd:5b9a with SMTP id r9-20020a17090a560900b0023b35cd5b9amr3839565pjf.4.1679442959965; Tue, 21 Mar 2023 16:55:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679442959; cv=none; d=google.com; s=arc-20160816; b=wjmj3y/FbZubulc6ZSNxfT1IgYk3/Y+DHBVVmfugNyyjd5g3XOofnIfn890GrwEvSr m/pYsA4XBn5l9iMfYr9lpUHOzFzhel082JCobAEKa4xmO8Lro3NNTZFxOTikK+swbk9i mC8ngqNhzRO1OuzC3Kt4hRB0aHi1EFVdHOaWiSvFj8sWGFn9wxbJRGYqtBMAa8AMAlDs DL04YTnc7/7xGxhY91uzdSOhRa6sy/ZVOYUnJ9M4AApgDPWp8HKVFdy/qW15pDeTRJqM MbsspHkvj2Mt+NbK1ywmZM6Q++OBurZVX72epf22uoqWfkWbJNNX7cblD/l4C6gHdRcc jN1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:cc:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=J6tFeM38IM7MOoSSdzpx3tQvMrfs/A8zdFZCKt/JIJc=; b=zuOA2DKE/fOYl0dynRuHufE7cH0Bv+N0YE1TsS+duS30TfLUHdqSd8i6D7I0la4/jT cziY0KM7JtLifTB5kdOSlqq3Ri8hG2uOChwNa5LMQmjamQ7dzt7U/oFnMag9nHo+Yg+y JzJQjI7Nq5upB5DiOio4ShUKp8fbM7q1A3rrBpPC7+6sYaXuhmg0Yn9TF0Ky6wl+fb5q oW+3QE4tARu4AgoIsuCcDWkpmPnIs8InPYQm+gKO+u9EL2AvSWQWFSDl9Qa3wYBrDrt/ 2WGRD76mHewGNZj7Msd280jBdz085/Xt+y4hotLtcA54ti3FaZw7ZzBmoXSs9JGy/jai BioQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BPdw1YKD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c1-20020a170903234100b0019f24ac1ab4si15098460plh.472.2023.03.21.16.55.47; Tue, 21 Mar 2023 16:55:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BPdw1YKD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229934AbjCUXyL (ORCPT + 99 others); Tue, 21 Mar 2023 19:54:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbjCUXyJ (ORCPT ); Tue, 21 Mar 2023 19:54:09 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C30405943D; Tue, 21 Mar 2023 16:53:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 68764B81986; Tue, 21 Mar 2023 23:53:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F274C433EF; Tue, 21 Mar 2023 23:53:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679442836; bh=J6tFeM38IM7MOoSSdzpx3tQvMrfs/A8zdFZCKt/JIJc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=BPdw1YKDmHoOOBMf6Tv9JUL7ZmShVwcA4aaoAzxIPH1UQs01Wn82/b+eMyzG7Gngj CpeUT0ivk6JKWv3j0wyWF4JzTuHFMQDeVGBCjLmxgL6FNYP1kg8ZXCivfVOieTKhMe KWtJL8/U+rpKUTVZnR8zsReDdr1FPcd8QMu4RUZWNtsWxozyUskrS3dX/OeVs6/SAx 6hx8u61vKQyqDiMWX5nn2a8YkYTV0MG2dsv327eC/LotHf/4xFOs9ZNo+PDzz3YsKu fuQoEqepI2cuIHYq2o6IGC/m8Ti1RwlSWeCIvQQDrJzn6yNVcMLQNZrHXKOsvzgVyA vY/u2AfQ3ffbA== Message-ID: <3d2a4063dfa82d49dd98ee8f615f3aec.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20221209152913.1335068-7-marpagan@redhat.com> References: <20221209152913.1335068-1-marpagan@redhat.com> <20221209152913.1335068-7-marpagan@redhat.com> Subject: Re: [PATCH 6/6] clk: socfpga: arria10: use of_clk_add_hw_provider and improve error handling From: Stephen Boyd Cc: Marco Pagani , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Dinh Nguyen , Marco Pagani , Michael Turquette Date: Tue, 21 Mar 2023 16:53:54 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Marco Pagani (2022-12-09 07:29:13) > The function of_clk_add_provider() has been deprecated, so use its > suggested replacement of_clk_add_hw_provider() instead. >=20 > Since of_clk_add_hw_provider() can fail, like of_clk_add_provider(), > check its return value and do the error handling. >=20 > The return type of the init function has been changed to void since > the return value was not used, and the indentation of the parameters has > been aligned to match open parenthesis, as suggested by checkpatch. >=20 > Signed-off-by: Marco Pagani > --- Applied to clk-next