Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v4 05/29] LoongArch: KVM: Add vcpu related header files
To:     Xi Ruoyao <xry111@xry111.site>, Paolo Bonzini <pbonzini@redhat.com>
References: <20230321035651.598505-1-zhaotianrui@loongson.cn>
 <20230321035651.598505-6-zhaotianrui@loongson.cn>
 <75f843b2780fc3c3dcc1d0d8f78f2b955956316b.camel@xry111.site>
Cc:     Huacai Chen <chenhuacai@kernel.org>,
        WANG Xuerui <kernel@xen0n.name>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
        Mark Brown <broonie@kernel.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Oliver Upton <oliver.upton@linux.dev>, maobibo@loongson.cn
From:   Tianrui Zhao <zhaotianrui@loongson.cn>
Message-ID: <554dc19a-cd94-0f94-7e81-9cdc137dac7d@loongson.cn>
Date:   Wed, 22 Mar 2023 09:34:46 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <75f843b2780fc3c3dcc1d0d8f78f2b955956316b.camel@xry111.site>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023年03月21日 20:30, Xi Ruoyao 写道:
> On Tue, 2023-03-21 at 11:56 +0800, Tianrui Zhao wrote:
>> +/* Tracepoints for VM exits */
>> +#define kvm_trace_symbol_exit_types                    \
>> +       ({ KVM_TRACE_EXIT_IDLE,         "IDLE" },       \
>> +       { KVM_TRACE_EXIT_CACHE,         "CACHE" },      \
>> +       { KVM_TRACE_EXIT_SIGNAL,        "Signal" })
> Looks like there shouldn't be "(" and ")".
>
>> +#define kvm_trace_symbol_aux_op				\
>> +	({ KVM_TRACE_AUX_RESTORE,	"restore" },	\
>> +	{ KVM_TRACE_AUX_SAVE,		"save" },	\
>> +	{ KVM_TRACE_AUX_ENABLE,		"enable" },	\
>> +	{ KVM_TRACE_AUX_DISABLE,	"disable" },	\
>> +	{ KVM_TRACE_AUX_DISCARD,	"discard" })
> Likewise.
>
> See the test robot report, and https://godbolt.org/z/bE8q97z1o.
>
> The lesson: if a text book claims "you should always wrap the content of
> a macro in ( ... )", we should burn it in the fire! :)
>

Thanks, it should remove the "()" statement in the macros. The reason I 
did this before because an error was triggered when I use checkpatch.py 
to check it,  and now I know this error can be ignored.

Thanks
Tianrui Zhao