Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ee585b21-7b75-c7fe-57fd-ad6d35986a11@infradead.org>
Date:   Tue, 21 Mar 2023 20:21:33 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] of: fix htmldocs build warning
Content-Language: en-US
From:   Randy Dunlap <rdunlap@infradead.org>
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Rob Herring <robherring2@gmail.com>
Cc:     Frank Rowand <frowand.list@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
References: <20230220163638.04e9d0c4@canb.auug.org.au>
 <20230310113258.463f836c@canb.auug.org.au>
 <b8e8e51e-1ccf-e413-0831-ae5f70da539b@infradead.org>
In-Reply-To: <b8e8e51e-1ccf-e413-0831-ae5f70da539b@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 3/9/23 20:52, Randy Dunlap wrote:
> 
> 
> On 3/9/23 16:32, Stephen Rothwell wrote:
>>
>> Fix this htmldoc build warning:
>>
>> include/linux/of.h:115: warning: cannot understand function prototype: 'const struct kobj_type of_node_ktype; '
>>
>> Reported by: Stephen Rothwell <sfr@canb.auug.org.au>
>> Fixes: 39459ce717b8 ("of: dynamic: add lifecycle docbook info to node creation functions")
>> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> 

Can we get Stephen's patch merged, please?
Thanks.

> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
> Thanks.
> 
> After this patch, there is another warning for this function:
> 
> ../include/linux/of.h:118: warning: Excess function parameter 'phandle_name' description in 'of_node_init'
> 
>> ---
>>  include/linux/of.h | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> This is actually untested, but seems pretty straight forward.
>>
>> diff --git a/include/linux/of.h b/include/linux/of.h
>> index 0af611307db2..814d33f3835a 100644
>> --- a/include/linux/of.h
>> +++ b/include/linux/of.h
>> @@ -100,6 +100,9 @@ struct of_reconfig_data {
>>  	struct property		*old_prop;
>>  };
>>  
>> +extern const struct kobj_type of_node_ktype;
>> +extern const struct fwnode_operations of_fwnode_ops;
>> +
>>  /**
>>   * of_node_init - initialize a devicetree node
>>   * @node: Pointer to device node that has been created by kzalloc()
>> @@ -111,9 +114,6 @@ struct of_reconfig_data {
>>   * whether to free the memory will be done by node->release(), which is
>>   * of_node_release().
>>   */
>> -/* initialize a node */
>> -extern const struct kobj_type of_node_ktype;
>> -extern const struct fwnode_operations of_fwnode_ops;
>>  static inline void of_node_init(struct device_node *node)
>>  {
>>  #if defined(CONFIG_OF_KOBJ)
> 

-- 
~Randy