Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1a2278c5-5398-2e7a-344d-fd5dd9703b10@gmail.com>
Date:   Wed, 22 Mar 2023 10:35:04 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] scripts/package: add back 'version' for builddeb
To:     David Wang <00107082@163.com>
Cc:     linux-kernel@vger.kernel.org, masahiroy@kernel.org
References: <20230320110819.23668-1-00107082@163.com>
 <a05cfc82-a9e9-ea96-aaca-612ff9c14219@gmail.com>
 <3ee67285.5853.18704c2158c.Coremail.00107082@163.com>
Content-Language: en-US
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <3ee67285.5853.18704c2158c.Coremail.00107082@163.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/21/23 22:20, David Wang wrote:
> 
>>
>> Again, your patch looks like corrupted (tabs converted to spaces).
>> Please resubmit; this time; generate the patch via git-format-patch(1)
>> and then send the resulting patch with git-send-email(1).
>>
>> Thanks.
>>
> I did use `git format-patch` and `git send-email`, but I did not run scripts/checkpatch.pl.
> Now when I run scripts/checkpatch.pl against the file generated by `git format-patch`, it shows a warning about "Fixes:" tag, and
> I have resend a patch which pass the checks of scripts/checkpatch.pl, hope this time it could be ok.
> 
> ```
> $ scripts/checkpatch.pl 0001-scripts-package-add-back-version-for-builddeb.patch
> total: 0 errors, 0 warnings, 7 lines checked
> 
> 0001-scripts-package-add-back-version-for-builddeb.patch has no obvious style problems and is ready for submission.
> ```
> 
> 
> David

OK, but there is already the similar fix submitted at [1]. Please test it.

Thanks anyway.

[1]: https://lore.kernel.org/linux-kbuild/3351f907cfd0b5d8372e858a8ec9065cc2bd91df.1679434718.git.kevin@kevinlocke.name/

-- 
An old man doll... just what I always wanted! - Clara