Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <17ab5a21-5512-5388-f9fa-c462b2ebd351@alu.unizg.hr> <7349a16f-6e7e-51d4-4686-ec7e688d891b@alu.unizg.hr>
In-Reply-To: <7349a16f-6e7e-51d4-4686-ec7e688d891b@alu.unizg.hr>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Wed, 22 Mar 2023 12:40:03 +0900
Message-ID: <CAK7LNARxu0hjOp6N7jnLWvqWb0h3LPPSAgF7+7+c-eB7Fmc9dA@mail.gmail.com>
Subject: Re: BUG: scripts/kconfig/merge_config.sh: typo in variable name
To:     Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc:     linux-kbuild@vger.kernel.org, Mark Brown <broonie@kernel.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Mar 22, 2023 at 5:14=E2=80=AFAM Mirsad Goran Todorovac
<mirsad.todorovac@alu.unizg.hr> wrote:
>
> On 3/21/2023 2:04 PM, Mirsad Goran Todorovac wrote:
> > Hi all,
> >
> > There is a typo in variable name in scripts/kconfig/merge_config.sh, wi=
th the
> > script returning:
> >
> > $ ./scripts/kconfig/merge_config.sh -y -m ../.config tools/testing/self=
tests/net/config
> > ./scripts/kconfig/merge_config.sh: 148: ./scripts/kconfig/merge_config.=
sh: Previous: not found
> >
> > Problem is probably best explained by this diff:
> >
> > ---
> > diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_co=
nfig.sh
> > index 32620de473ad..902eb429b9db 100755
> > --- a/scripts/kconfig/merge_config.sh
> > +++ b/scripts/kconfig/merge_config.sh
> > @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
> >                  NEW_VAL=3D$(grep -w $CFG $MERGE_FILE)
> >                  BUILTIN_FLAG=3Dfalse
> >                  if [ "$BUILTIN" =3D "true" ] && [ "${NEW_VAL#CONFIG_*=
=3D}" =3D "m" ] && [ "${PREV_VAL#CONFIG_*=3D}" =3D "y" ]; then
> > -                       ${WARNOVVERIDE} Previous  value: $PREV_VAL
> > +                       ${WARNOVERRIDE} Previous  value: $PREV_VAL
> >                          ${WARNOVERRIDE} New value:       $NEW_VAL
> >                          ${WARNOVERRIDE} -y passed, will not demote y t=
o m
> >                          ${WARNOVERRIDE}
> >
> > Hope this helps.
>
> P.S.
>
> Later I thought of searching the committer of the patch that introduced t=
he change,
> so I Cc:ed Mark.
>
> Best regards,
> Mirsad

Good catch.

Will you please send a patch with your signed-off?


> --
> Mirsad Todorovac
> Sistem in=C5=BEenjer
> Grafi=C4=8Dki fakultet | Akademija likovnih umjetnosti
> Sveu=C4=8Dili=C5=A1te u Zagrebu
>
> System engineer
> Faculty of Graphic Arts | Academy of Fine Arts
> University of Zagreb, Republic of Croatia
> tel. +385 (0)1 3711 451
> mob. +385 91 57 88 355


--=20
Best Regards
Masahiro Yamada