Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Veerasenareddy Burru <vburru@marvell.com>
To:     Maciej Fijalkowski <maciej.fijalkowski@intel.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Abhijit Ayarekar <aayarekar@marvell.com>,
        Sathesh B Edara <sedara@marvell.com>,
        Satananda Burla <sburla@marvell.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Subject: RE: [EXT] Re: [PATCH net-next v3 5/7] octeon_ep: support asynchronous
 notifications
Thread-Topic: [EXT] Re: [PATCH net-next v3 5/7] octeon_ep: support
 asynchronous notifications
Thread-Index: AQHZQDM6GPKcjWDLWUe8vgr/YQ1bB67QNs6AgDZndGA=
Date:   Wed, 22 Mar 2023 07:26:05 +0000
Message-ID: <BYASPR01MB0053FFDDDF3ED9122B0D917DCC869@BYASPR01MB0053.namprd18.prod.outlook.com>
References: <20230214051422.13705-1-vburru@marvell.com>
 <20230214051422.13705-6-vburru@marvell.com> <Y+0J94sowllCe5Gs@boxer>
In-Reply-To: <Y+0J94sowllCe5Gs@boxer>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dvJttHcqEaaduqzkSk9gTtZocgRBtesoPvQAmudIbNl/fwCXRH1M5LHrWRIq?=
 =?us-ascii?Q?4/ExtGv3iG1F/hMv+YIvTdRuGi8d9zCvuaMPeepLmPpfKZ/5gKtM/duPg9+V?=
 =?us-ascii?Q?AckkKHVW5QGVP5nfIa6Sr6NkD95wqWXNkWL/XOpvYnM9W9lzH+hEaxi6W08z?=
 =?us-ascii?Q?uvqgHtR4XNksiKbjNO3IaL5nP672l3J0+V0kM5W/4s+DPTOuufinZdE/dSx5?=
 =?us-ascii?Q?tjBfCOAKyl4EtjrV+cDBQD4LrsXuKAE7/GnO+xOWJUFUDkB2JK0sgWGeQGte?=
 =?us-ascii?Q?OkmXhV+OwVsV7jIjWtAbfqYQk0xzkBIqJEdKqNAKeFC0QNLa4Rnfc1CIvDG+?=
 =?us-ascii?Q?V9ngCry4JpYsBDPy6jtLedL3ANotjcYWhZRd0O1KjUjPiSkeqZhqChJ0fdbl?=
 =?us-ascii?Q?bQQSgBCrnUJ64vjMN+y6ha2MdylKg9ZyiTUlRocJyyfgOyCXTjZJ4TywZ1Ln?=
 =?us-ascii?Q?8Rri04Gt/8fkQdW+u9QvllVWuilBj6ljkkBpFkAwybO7eCPhBHuzKGKkC6V4?=
 =?us-ascii?Q?oSRjmWYuMY2Ps/DCHkrfBpE7/KpzvT2TCsfUqaHUHsF7/+tikvjQmNy0xGMq?=
 =?us-ascii?Q?f4O1REgVK0btYjlpCKEmHCYya3E+XzUTuSs9d3DeoOtHzkOCZBeTeSILS4yT?=
 =?us-ascii?Q?dWbunjc0gElY0xGJXPRZWNrAb2ppthkwzhcuVIn35aJtFyIZbz0fG/Keeb8J?=
 =?us-ascii?Q?1Xq0HbkrMEj+O0HVTS8uwMPKslAzp0Ms/aLek/ktJ6QKGiJ3r376cLP94Onz?=
 =?us-ascii?Q?9kiLJF3XZtqA8cFEpvSowPg0RZhW7J99M/4kUNYI5xqL59ojAuF8rXu8Js1d?=
 =?us-ascii?Q?zY1QJINBpVVurNFJgHwEagSi9Rw1zpTKLW/zd1cQK7KiaDm5pGbhI6NCUYjR?=
 =?us-ascii?Q?jEfGH017Ve9tHr0uio4EENqtF6IP+P3DeY6zvwsG+yGnkUpFH6+cQKG7iVit?=
 =?us-ascii?Q?/dnvqccgf/YbfafNoqOCSBU3ZgDn5ITZCosCjXVQfclEkjmVh9TeAvV5DPZY?=
 =?us-ascii?Q?ZyxAy6pFGWuZd49pQCY7hc9J98iLWAuY+wX3x1fGetYQq4lYY8Radi1GBvl4?=
 =?us-ascii?Q?R9BVULEFJPBqcfaz3ExBSz3Wz9FL/UaBimKLF3S/UGU2LAGtrLTaeWjRbOyT?=
 =?us-ascii?Q?fA0r+S2uixWnmBGNPRjNGIfVDxQt2nqYnmOYF63aXbzAjcqUzId1IGvuz0Xu?=
 =?us-ascii?Q?BZ5RateB+eJn+kkmRWRI7NOvv5p+LvoM1ab93IU1RXDl+guOePWvv59R3LPw?=
 =?us-ascii?Q?JhqRDcku64JBFkdvvAzJyBq6NDX8FK8lwFm/RfmRc/02tYzlpvW8I/Ws1nKa?=
 =?us-ascii?Q?oxKoDOD8+Slwn4gJnVUQE1SkYD/UpMGtsQT1Hyrwc8R2l9TPNBQVNj6ncPGI?=
 =?us-ascii?Q?S8YqTHeC3r4OA3qNL24nqHybaNVvio6W+TuU/mgVS/ZeK0jTZhLBdOoMVBhT?=
 =?us-ascii?Q?D+JShhopK3inEh3GZI1UZpxf5fhAjyZRiIZQlrVyERzcEJxEinWuubQBd8rx?=
 =?us-ascii?Q?UxCqtdokWqfnjMQxMA0NRN0G7egjeF/0KZ0SLCrwLhTR3k62GHy+AxPEPBqV?=
 =?us-ascii?Q?o4q/eeHscjyquZf0KbadVZEffMeZ1q+nPeo4gwle?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYASPR01MB0053.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82a68f0b-687b-47ed-f85d-08db2aa6b296
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2023 07:26:05.1920
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LBiZBjkm7rjTlW7szeYt4jYj/PVCDEwZaa1qHYwPqXOvv9J1k7EMvp3wz6f+5sLJ0AlyDBml33xhO75atxm0TQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4441
X-Proofpoint-ORIG-GUID: -KL6TtOditB3mO_MhpVH91SgKnXPtNxY
X-Proofpoint-GUID: -KL6TtOditB3mO_MhpVH91SgKnXPtNxY
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-21_11,2023-03-21_01,2023-02-09_01
X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Sent: Wednesday, February 15, 2023 8:36 AM
> To: Veerasenareddy Burru <vburru@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Abhijit Ayareka=
r
> <aayarekar@marvell.com>; Sathesh B Edara <sedara@marvell.com>;
> Satananda Burla <sburla@marvell.com>; linux-doc@vger.kernel.org; David S.
> Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>;
> Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Subject: [EXT] Re: [PATCH net-next v3 5/7] octeon_ep: support
> asynchronous notifications
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> On Mon, Feb 13, 2023 at 09:14:20PM -0800, Veerasenareddy Burru wrote:
> > Add asynchronous notification support to the control mailbox.
> >
> > Signed-off-by: Veerasenareddy Burru <vburru@marvell.com>
> > Signed-off-by: Abhijit Ayarekar <aayarekar@marvell.com>
> > ---
> > v2 -> v3:
> >  * no change
> >
> > v1 -> v2:
> >  * no change
> >
> >  .../marvell/octeon_ep/octep_ctrl_net.c        | 29 +++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> > b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> > index 715af1891d0d..80bcd6cd4732 100644
> > --- a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> > +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> > @@ -279,6 +279,33 @@ static int process_mbox_resp(struct octep_device
> *oct,
> >  	return 0;
> >  }
> >
> > +static int process_mbox_notify(struct octep_device *oct,
>=20
> void
>=20

Will change in next revision.

> > +			       struct octep_ctrl_mbox_msg *msg) {
> > +	struct octep_ctrl_net_f2h_req *req;
> > +	struct net_device *netdev =3D oct->netdev;
>=20
> RCT
>=20

Will fix in next revision. I missed some RCT violations in this patchset. W=
ill take care for future submissions.
Thank you for kind review.

> > +
> > +	req =3D (struct octep_ctrl_net_f2h_req *)msg->sg_list[0].msg;
> > +	switch (req->hdr.s.cmd) {
> > +	case OCTEP_CTRL_NET_F2H_CMD_LINK_STATUS:
> > +		if (netif_running(netdev)) {
> > +			if (req->link.state) {
> > +				dev_info(&oct->pdev->dev,
> "netif_carrier_on\n");
> > +				netif_carrier_on(netdev);
> > +			} else {
> > +				dev_info(&oct->pdev->dev,
> "netif_carrier_off\n");
> > +				netif_carrier_off(netdev);
> > +			}
> > +		}
> > +		break;
> > +	default:
> > +		pr_info("Unknown mbox req : %u\n", req->hdr.s.cmd);
> > +		break;
> > +	}
> > +
> > +	return 0;
> > +}
> > +
> >  int octep_ctrl_net_recv_fw_messages(struct octep_device *oct)  {
> >  	static u16 msg_sz =3D sizeof(union octep_ctrl_net_max_data); @@ -
> 303,6
> > +330,8 @@ int octep_ctrl_net_recv_fw_messages(struct octep_device
> *oct)
> >  			process_mbox_req(oct, &msg);
> >  		else if (msg.hdr.s.flags &
> OCTEP_CTRL_MBOX_MSG_HDR_FLAG_RESP)
> >  			process_mbox_resp(oct, &msg);
> > +		else if (msg.hdr.s.flags &
> OCTEP_CTRL_MBOX_MSG_HDR_FLAG_NOTIFY)
> > +			process_mbox_notify(oct, &msg);
> >  	}
> >
> >  	return 0;
> > --
> > 2.36.0
> >