Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5706151rwl; Wed, 22 Mar 2023 00:47:24 -0700 (PDT) X-Google-Smtp-Source: AK7set8qEjtprhivq7Lqw4EJaKcgdFPTpY3KZatGIokm0t27JbsAG4zQl/8IvgX7xQpbgn3oJ8kD X-Received: by 2002:a17:903:2093:b0:19e:e172:2a40 with SMTP id d19-20020a170903209300b0019ee1722a40mr1495115plc.65.1679471244552; Wed, 22 Mar 2023 00:47:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679471244; cv=none; d=google.com; s=arc-20160816; b=LJULyyCcty2FsR7f/edI/egqtu7Z7dFSqiVtS787OfaYzBHdlak3GSEBJR3khJMkgY Aaj6G1a/VoQJbrHd12RETaEEiawooTBvgr5dGJWmX7gEKWPmIQDLA1K+ln7osWPywZfk 6P2PSA4GZspCCUR+HM/Cj3CewbR+z3UVpahao95MYv75xDeow348ptW7AVEPzERICt2z cKSRgDVNxDo9SC5D+iePwk4z7BKi/5kjNK+yCbPGa2q/FjMg1RSBSTPhdg7zvfLIoVNJ tsDutQneNVKGzfbQt9n2UW04Q4NZ//y4tVDKD8QgXM549hGaYBBaCDUMfAPR5huUDgkh /pLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=A7TowZkEhnqjJnr/U9MoEskGOfrJFIxqIBN7LeONOYA=; b=NI2kqEHFBntUUxrdmKFHPnGjWl2oVgoosHbI3pZVsNRm/GO9KccUY0ieCzi/p1SAUN 3LcSVDh92fEtUQRe6/JBzY33DqkraKgP3SzoXGyRi8g/UdPJu8TPnvcVpWe1ZiKyjGZ4 FMyVTQYn3z9oSQxLoKbEoG6ghreNehArWJzoOwgvLs0eFIng5Ra7y4lrxAqO/amkANm6 G9A+flvOVimnp6Ydv3HySTaAabZUL5rcl9oqXKdQ4F2SSAzPl81DkkVWBsrQ0k8mFo+h q7KktfDwHX/4NQ29HubOfwGUUQguGzSkA0dCns05mtSPDdNM7tlNMuUJXW4l5O60lE4x XVTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ieqy7YeK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c3-20020a170902d48300b0019e2bd0fea8si13453738plg.143.2023.03.22.00.47.12; Wed, 22 Mar 2023 00:47:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ieqy7YeK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229939AbjCVHqa (ORCPT + 99 others); Wed, 22 Mar 2023 03:46:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjCVHq2 (ORCPT ); Wed, 22 Mar 2023 03:46:28 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF8A35AB74; Wed, 22 Mar 2023 00:46:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 78062B81A34; Wed, 22 Mar 2023 07:46:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F176BC433EF; Wed, 22 Mar 2023 07:46:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679471185; bh=OcfApPzBhFbVilWX9veIC9cR3TcxTEM6uyoh7NQTV4I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ieqy7YeKERD238mqSeqZHh7bdt9fv+09KJAVhevtdiTYCEvGE9yxrzC3swox3JAPb NfqyXmLjIqhaRUjmAtqjkMxmhBoozBBh/ukaB8AFPSxzPu5m7aEGgQE9kWjGqtcdQ/ O/KPhln1Xk/gb2TYzrb97riZItapLy5TVtlRo2Kru2gq6hCpNX6WhkBXUe4kn3asu6 GpOGzQ6HnmiZRA/KlS74CvuDUQM1gXZWD+Clwx4c3QTltnB4tyRBAEBWl6wiMnYsRW 7vVaKdsFj5QX3Lv9orvk3bS2n0JOHa1yvyUPBkJty7oI/vRbSvh+RIS3w92sJyGpIA EE2WuNkUxPRxA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1petCI-0002Sf-Be; Wed, 22 Mar 2023 08:47:51 +0100 Date: Wed, 22 Mar 2023 08:47:50 +0100 From: Johan Hovold To: Dmitry Baryshkov Cc: Johan Hovold , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 05/10] drm/msm: fix drm device leak on bind errors Message-ID: References: <20230306100722.28485-1-johan+linaro@kernel.org> <20230306100722.28485-6-johan+linaro@kernel.org> <90264695-131e-46b7-46db-822b0aee9801@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <90264695-131e-46b7-46db-822b0aee9801@linaro.org> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2023 at 04:54:51PM +0200, Dmitry Baryshkov wrote: > On 06/03/2023 12:07, Johan Hovold wrote: > > Make sure to free the DRM device also in case of early errors during > > bind(). > > > > Fixes: 2027e5b3413d ("drm/msm: Initialize MDSS irq domain at probe time") > > Cc: stable@vger.kernel.org # 5.17 > > Cc: Dmitry Baryshkov > > Signed-off-by: Johan Hovold > > Can we migrate to devm_drm_dev_alloc instead() ? Will it make code > simpler and/or easier to handle? I'm just fixing the bugs here. Cleanups/rework like that can be done on top but should not be backported as it risks introducing new issues. Johan