Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <59886f87-c277-5917-a521-5893ab75acee@molgen.mpg.de>
Date:   Wed, 22 Mar 2023 08:50:32 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] ARM: npcm: remove select of non-existant ERRATA
Content-Language: en-US
To:     Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc:     Avi Fishman <avifishman70@gmail.com>,
        Tomer Maimon <tmaimon77@gmail.com>,
        Tali Perry <tali.perry1@gmail.com>,
        Patrick Venture <venture@google.com>,
        Nancy Yuen <yuenn@google.com>,
        Benjamin Fair <benjaminfair@google.com>,
        Russell King <linux@armlinux.org.uk>, openbmc@lists.ozlabs.org,
        linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org,
        Brendan Higgins <brendan.higgins@linux.dev>
References: <20230316204749.19902-1-r.czerwinski@pengutronix.de>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20230316204749.19902-1-r.czerwinski@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Dear Rouven,


Thank you for your patch.

Am 16.03.23 um 21:47 schrieb Rouven Czerwinski:

There is a small typo in the commit message summary/title: 
non-exist*e*nt. Maybe also mention the errata number:

ARM: npcm: Remove select of non-existent ARM_ERRATA_794072

> config ARCH_NPCM7XX selects ARM_ERRATA_794072, however this config
> option does not exist since the workaround for the errata requires
> secure mode access which needs to be run by the bootloader or firmware
> since linux can't determine whether it is running in secure mode.

Please add a Fixes: tag.

> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
>   arch/arm/mach-npcm/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/mach-npcm/Kconfig b/arch/arm/mach-npcm/Kconfig
> index 63b42a19d1b8..d933e8abb50f 100644
> --- a/arch/arm/mach-npcm/Kconfig
> +++ b/arch/arm/mach-npcm/Kconfig
> @@ -30,7 +30,6 @@ config ARCH_NPCM7XX
>   	select ARM_ERRATA_764369 if SMP
>   	select ARM_ERRATA_720789
>   	select ARM_ERRATA_754322
> -	select ARM_ERRATA_794072
>   	select PL310_ERRATA_588369
>   	select PL310_ERRATA_727915
>   	select MFD_SYSCON

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul