Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760946AbXISR3Y (ORCPT ); Wed, 19 Sep 2007 13:29:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755320AbXISR3I (ORCPT ); Wed, 19 Sep 2007 13:29:08 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:35153 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752883AbXISR3G (ORCPT ); Wed, 19 Sep 2007 13:29:06 -0400 Date: Wed, 19 Sep 2007 10:29:04 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Anton Altaparmakov cc: David Rientjes , Christoph Hellwig , Mel Gorman , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, David Chinner , Jens Axboe Subject: Re: [03/17] is_vmalloc_addr(): Check if an address is within the vmalloc boundaries In-Reply-To: Message-ID: References: <20070919033605.785839297@sgi.com> <20070919033641.009931707@sgi.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 771 Lines: 16 On Wed, 19 Sep 2007, Anton Altaparmakov wrote: > There even is such a function already in mm/sparse.c::vaddr_in_vmalloc_area() > with pretty identical content. I would suggest either this new inline should > go away completely and use the existing one and export it or the existing one > should go away and the inline should be used. It seems silly to have two > functions with different names doing exactly the same thing! Just in case you have not noticed: This patchset removes the vaddr_in_vmalloc_area() in sparse.c - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/