Received: by 2002:ac8:156:0:b0:3e0:cd10:60c8 with SMTP id f22csp1793572qtg; Wed, 22 Mar 2023 02:07:05 -0700 (PDT) X-Google-Smtp-Source: AK7set9dTeJuRiaj/A8jNd4sJ2eTSdNGak/lr5qMtUlY6Y6sGvZuJinxDJXuOxda6XvjUfPZzHSx X-Received: by 2002:a17:90a:1a53:b0:23f:abfd:1241 with SMTP id 19-20020a17090a1a5300b0023fabfd1241mr3106200pjl.1.1679476025120; Wed, 22 Mar 2023 02:07:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679476025; cv=none; d=google.com; s=arc-20160816; b=u2T8GMg46//CJTWSFQ+eqR5RXawByWkilyZ/nQ8JRAjKwq4W18ZbmzXfwJ7s74c/2o UGlepNHhL78x453V9+gx8ETSg+7M7hvYYW0TnhRHbO07mMbaOVocV8aVJSLShr1ndSNZ DBHprRwtdy/xqlYfuQgqEri4R92WAUJ5Yv+B11j50n0zZBMON3PrcNxiC1EY6XIMBlQK ms/7vP8ucYJQoQVQVCSdIBKOSipHhqxaJYp3dOi09MHzl9M+T8n1xkFv1cWXDYcV0iUH PBaf0ZxNuly/IlLIq4XYBrOeCC6YdKt0CgtbZBr6WtLixdvRdVhfyj9n9xZORkqG350w 83pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=yoez+GkpIqIne9UpwkUe2KjsMKBDPoyQBYMjl8pDQRA=; b=omHnUwKI1rZiUynEY1ijW8iaPfkQ9TamHE0B4H9IOWBsOeYpJJUHeiug/1huFx8io4 O/iS7mwJIM7x1eecUAZmSk6lXsJPbJkyd4OQ2zM/M/lTHzg3PkXo+7EvYKa4repIIbTL 0rijtUejMVNB++kSZCz2VVilNxEcWvzw0c+A8aVxpA2DTm7bCsEKwxx2lFeyquuNRk8U 5UoUNBLV9FgTR07znWMEsQta9rSyCescaR/VFFEp6tskUUS2eVCmRflrSYBTjGBVhvF2 fkwzcjSU94AZQC4axTZz4NLNHNFJ52Ex0Q/E3kUYbLs9BVB5p1rGZ3unNo3roVK4QYam T65w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h20-20020a17090acf1400b0023d982fb7ecsi20721700pju.75.2023.03.22.02.06.53; Wed, 22 Mar 2023 02:07:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229842AbjCVJAU (ORCPT + 99 others); Wed, 22 Mar 2023 05:00:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229676AbjCVJAS (ORCPT ); Wed, 22 Mar 2023 05:00:18 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 25BCB50713; Wed, 22 Mar 2023 02:00:10 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1peuKE-0004ZM-00; Wed, 22 Mar 2023 10:00:06 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 540DCC1B28; Wed, 22 Mar 2023 09:59:53 +0100 (CET) Date: Wed, 22 Mar 2023 09:59:53 +0100 From: Thomas Bogendoerfer To: Mike Rapoport Cc: Andrew Morton , Huacai Chen , "Kirill A. Shutemov" , "Kirill A. Shutemov" , WANG Xuerui , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-mips@vger.kernel.org Subject: Re: [PATCH] mips: drop ranges for definition of ARCH_FORCE_MAX_ORDER Message-ID: <20230322085953.GA3910@alpha.franken.de> References: <20230322081520.2516226-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230322081520.2516226-1-rppt@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2023 at 10:15:20AM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > MIPS defines insane ranges for ARCH_FORCE_MAX_ORDER allowing MAX_ORDER > up to 63, which implies maximal contiguous allocation size of 2^63 > pages. > > Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a > simple integer with sensible defaults. > > Users that *really* need to change the value of ARCH_FORCE_MAX_ORDER > will be able to do so but they won't be mislead by the bogus ranges. > > Signed-off-by: Mike Rapoport (IBM) > --- > arch/mips/Kconfig | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 3e8b765b8c7b..a0f6e9d0a561 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -2137,13 +2137,9 @@ endchoice > > config ARCH_FORCE_MAX_ORDER > int "Maximum zone order" > - range 13 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_64KB > default "13" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_64KB > - range 12 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB > default "12" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB > - range 11 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB > default "11" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB > - range 0 63 > default "10" > help > The kernel memory allocator divides physically contiguous memory > -- > 2.35.1 Thank you for cleaning this up. Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]