Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Mar 2023 11:06:16 +0200
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     ye.xingchen@zte.com.cn
Cc:     andrzej.hajda@intel.com, neil.armstrong@linaro.org,
        rfoss@kernel.org, jonas@kwiboo.se, jernej.skrabec@gmail.com,
        airlied@gmail.com, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: bridge: simple-bridge: Use dev_err_probe()
Message-ID: <20230322090616.GJ20234@pendragon.ideasonboard.com>
References: <202303221622511915615@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <202303221622511915615@zte.com.cn>
Precedence: bulk

Hi Ye,

Thank you for the patch.

On Wed, Mar 22, 2023 at 04:22:51PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> Replace the open-code with dev_err_probe() to simplify the code.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/bridge/simple-bridge.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
> index 5ede3e111096..d85d9ee463b8 100644
> --- a/drivers/gpu/drm/bridge/simple-bridge.c
> +++ b/drivers/gpu/drm/bridge/simple-bridge.c
> @@ -202,11 +202,9 @@ static int simple_bridge_probe(struct platform_device *pdev)
> 
>  	sbridge->enable = devm_gpiod_get_optional(&pdev->dev, "enable",
>  						  GPIOD_OUT_LOW);
> -	if (IS_ERR(sbridge->enable)) {
> -		if (PTR_ERR(sbridge->enable) != -EPROBE_DEFER)
> -			dev_err(&pdev->dev, "Unable to retrieve enable GPIO\n");
> -		return PTR_ERR(sbridge->enable);
> -	}
> +	if (IS_ERR(sbridge->enable))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(sbridge->enable),
> +				     "Unable to retrieve enable GPIO\n");
> 
>  	/* Register the bridge. */
>  	sbridge->bridge.funcs = &simple_bridge_bridge_funcs;

-- 
Regards,

Laurent Pinchart