Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5827764rwl; Wed, 22 Mar 2023 02:58:19 -0700 (PDT) X-Google-Smtp-Source: AKy350bl1+J4DklwAbtGjFtZKpaMK5hfDM2labRcUnFTVp/tCLY0/mazHmSPKlKWJEl81mUj7CT3 X-Received: by 2002:a17:903:234f:b0:1a1:e5ec:31ae with SMTP id c15-20020a170903234f00b001a1e5ec31aemr1726692plh.23.1679479099273; Wed, 22 Mar 2023 02:58:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679479099; cv=none; d=google.com; s=arc-20160816; b=VxEQeCVMN+jh99nCrfuoqoNodyauOIAmjS9qZu9+hc7qfgnOaBzoPOT2/o9/y0s0ZA 7q1bE+aDhp47PgMFkIg+72zUs5lIsDpKtrKEW99By60pP1sqrkaLPSDemRn0JAFjIknx f20bPQuv2maWDB9EPBkiTsjwTsKyS1AJnKveEPqqqY7BGwFXOEfogjer86GHIYM7uDN+ 3Mw1IQvg6CqQQF4Z5cLmeXwyi/l7a7k7fOWYknI4phIQQJsRr/a+Txqx6Ebz2kwrTbyF 9oZq0Q7ZocWjgYj8q0e79Bcnr9HgYK+1IckF2r9mF07/Yy6WTxPxA3vr9bgTAiZJAq01 euNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MepofSho9k8xeRbWNPZZ+b/oeW4EOWYNx1ZHow41Q0M=; b=Cwsh30XvqrUuIAltiM+2KIUnR8Ep1Z0voLOGjQRqbDh8m2Ny8h21TM75EPgUSyVjhF Q15CYAd7eekheY6bT6/Mpx4qtx2kMsTLWfFZK69aO5+cUZPgWXV8MChuogkwMVdO0aPC y23IMKfouxnpiUpcLyorqhN/7otkXp7wlSRmmCZ8EFGkOVEZvOmhdFkUMc9VyEA3uPvP USWrw4ibVQI4VoOsP7jATRVxku3Lc1xH8M0736yknZhaYN3+jxKEwMHd3asRYafPU2vP BEQqj1EulQ2R6H3fEC+leCYbyp8a9uLFOI9oXS+7YMnfhjiDiyKPN0AlXx84zSEe1/Sv 7p2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=geC7HoOO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gi15-20020a17090b110f00b0023f087aaa9asi2017674pjb.140.2023.03.22.02.58.08; Wed, 22 Mar 2023 02:58:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=geC7HoOO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229816AbjCVJ5s (ORCPT + 99 others); Wed, 22 Mar 2023 05:57:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229825AbjCVJ5l (ORCPT ); Wed, 22 Mar 2023 05:57:41 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 853452D4A for ; Wed, 22 Mar 2023 02:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MepofSho9k8xeRbWNPZZ+b/oeW4EOWYNx1ZHow41Q0M=; b=geC7HoOO3D5XVXJb0Rh6Zky0OU QNkvKkUCvitUfjQqKXWXOGJLBmA7ykSXs0eCQUBE6RI/aAgQtxFOfjgWlkStF+UsqxXWrPhwZ2NUg IHFY3vr4dPniov2l8ydfRkJ4GSii0UxrJVEKmjwUCBF6vH/+8pSxEtUc4tsxkbUjJ3UrUwBSrgxXx 0LfhSPJHDovHqAmUkdxmirY2t27Fi8Si8JxLBgBC+nCvDhWOJxocxBFOrWhJ5XiWvIONcsQQk17bb j1nWoSGUneLudThXMgw4cyj4azatXOSDAZJH+m+HaKXCwoVNflvFIwI22Dpp2b6uJeZhQT3x7AYu8 42YcZ6Xw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pevDd-004Wy0-33; Wed, 22 Mar 2023 09:57:22 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 3B440300652; Wed, 22 Mar 2023 10:57:20 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id E511D205414ED; Wed, 22 Mar 2023 10:57:19 +0100 (CET) Date: Wed, 22 Mar 2023 10:57:19 +0100 From: Peter Zijlstra To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, rostedt@goodmis.org, jgross@suse.com, mingo@kernel.org, corbet@lwn.net, vschneid@redhat.com Subject: Re: [PATCH RFC smp] Remove diagnostics and adjust config for CSD lock diagnostics Message-ID: <20230322095719.GT2017917@hirez.programming.kicks-ass.net> References: <0c368b66-71b2-442f-a8f7-e6decc4be2d6@paulmck-laptop> <20230321102220.GH2234901@hirez.programming.kicks-ass.net> <1b48795e-8ec7-4628-b926-38f21a024a9d@paulmck-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1b48795e-8ec7-4628-b926-38f21a024a9d@paulmck-laptop> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2023 at 08:38:50AM -0700, Paul E. McKenney wrote: > On Tue, Mar 21, 2023 at 11:22:20AM +0100, Peter Zijlstra wrote: > > On Mon, Mar 20, 2023 at 05:54:39PM -0700, Paul E. McKenney wrote: > > > Hello! > > > > > > This series removes CSD-lock diagnostics that were once very useful > > > but which have not seen much action since. It also adjusts Kconfig and > > > kernel-boot-parameter setup. > > > > > > 1. locking/csd_lock: Add Kconfig option for csd_debug default. > > > > > > 2. locking/csd_lock: Remove added data from CSD lock debugging. > > > > > > 3. locking/csd_lock: Remove per-CPU data indirection from CSD > > > lock debugging. > > > > > > 4. kernel/smp: Make csdlock_debug= resettable. > > > > > > Thanx, Paul > > > > > > ------------------------------------------------------------------------ > > > > > > Documentation/admin-guide/kernel-parameters.txt | 17 - > > > b/Documentation/admin-guide/kernel-parameters.txt | 6 > > > b/kernel/smp.c | 2 > > > b/lib/Kconfig.debug | 9 > > > kernel/smp.c | 260 ++-------------------- > > > 5 files changed, 47 insertions(+), 247 deletions(-) > > > > Yay!! How do you want to route these, should I take them through tip? > > Either way works for me. If you take them into -tip, I will drop them > from -rcu. If you don't take them into -tip, I will send Linus a pull > request for the upcoming merge window. And if you take them at just > the wrong time, we will both send them to Linus. ;-) > > Your choice! OK, since they conflict a wee bit with Valentin's IPI tracepoint stuff, I'm probably going to take both these series, let me stomp on the conflict and feed it to the robots to see how bad it all gets :-) I'll let you know if/when i'll push them to -tip.