Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9e339ec0-d244-ea22-d9d8-70a76ac1bc0a@gmail.com>
Date:   Wed, 22 Mar 2023 12:16:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] staging: greybus: remove unnecessary blank line
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     gregkh@linuxfoundation.org, outreachy@lists.linux.dev,
        johan@kernel.org, elder@kernel.org, vireshk@kernel.org,
        thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
        greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev, linux-pwm@vger.kernel.org
References: <20230322100927.28351-1-eng.mennamahmoud.mm@gmail.com>
 <369edb35-b93b-301c-fcef-8e64e5d4a122@inria.fr>
Content-Language: en-US
From:   Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
In-Reply-To: <369edb35-b93b-301c-fcef-8e64e5d4a122@inria.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On ٢٢‏/٣‏/٢٠٢٣ ١٢:١٤, Julia Lawall wrote:
>
> On Wed, 22 Mar 2023, Menna Mahmoud wrote:
>
>> Remove unnecessary blank line before struct as reported
>> by checkpatch:
>>
>> " CHECK: Please don't use multiple blank lines"
> Since there is no vX indicator, one doesn't know that this replaces some
> previous patches.

yes, sorry I missed it because I dropped the previous commits, I will 
add it.


Menna

>
> julia
>
>> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
>> ---
>>   drivers/staging/greybus/greybus_authentication.h | 1 -
>>   drivers/staging/greybus/pwm.c                    | 1 -
>>   2 files changed, 2 deletions(-)
>>
>> diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h
>> index 7edc7295b7ab..48b4a9794d3c 100644
>> --- a/drivers/staging/greybus/greybus_authentication.h
>> +++ b/drivers/staging/greybus/greybus_authentication.h
>> @@ -41,7 +41,6 @@
>>   #define CAP_AUTH_RESULT_CR_NO_KEY	0x03
>>   #define CAP_AUTH_RESULT_CR_SIG_FAIL	0x04
>>
>> -
>>   /* IOCTL support */
>>   struct cap_ioc_get_endpoint_uid {
>>   	__u8			uid[8];
>> diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c
>> index 3fda172239d2..26d39e08c3b6 100644
>> --- a/drivers/staging/greybus/pwm.c
>> +++ b/drivers/staging/greybus/pwm.c
>> @@ -24,7 +24,6 @@ struct gb_pwm_chip {
>>   #define pwm_chip_to_gb_pwm_chip(chip) \
>>   	container_of(chip, struct gb_pwm_chip, chip)
>>
>> -
>>   static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
>>   {
>>   	struct gb_pwm_count_response response;
>> --
>> 2.34.1
>>
>>
>>