Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c7e41662-ce98-62c1-18d7-22402faf8322@linaro.org>
Date:   Wed, 22 Mar 2023 11:29:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
From:   neil.armstrong@linaro.org
Reply-To: neil.armstrong@linaro.org
Subject: Re: [PATCH v1 1/3] ARM: dts: meson8: add the xtal_32k_out pin
Content-Language: en-US
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        linux-amlogic@lists.infradead.org
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230321171213.2808460-1-martin.blumenstingl@googlemail.com>
 <20230321171213.2808460-2-martin.blumenstingl@googlemail.com>
Organization: Linaro Developer Services
In-Reply-To: <20230321171213.2808460-2-martin.blumenstingl@googlemail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/03/2023 18:12, Martin Blumenstingl wrote:
> GPIOX_10 can generate a 32768Hz signal when enabling the "xtal_32k_out"
> group with the xtal function. This is typically used as LPO clock for
> the SDIO wifi chips.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
>   arch/arm/boot/dts/meson8.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
> index 21eb59041a7d..4d18bb4e3c33 100644
> --- a/arch/arm/boot/dts/meson8.dtsi
> +++ b/arch/arm/boot/dts/meson8.dtsi
> @@ -568,6 +568,14 @@ mux {
>   				bias-disable;
>   			};
>   		};
> +
> +		xtal_32k_out_pins: xtal-32k-out {
> +			mux {
> +				groups = "xtal_32k_out";
> +				function = "xtal";
> +				bias-disable;
> +			};
> +		};
>   	};
>   };
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>