Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Mar 2023 13:15:36 +0100
From:   Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To:     <ye.xingchen@zte.com.cn>
Cc:     <miquel.raynal@bootlin.com>, <kishon@kernel.org>,
        <linux-phy@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <vkoul@kernel.org>
Subject: Re: [PATCH] phy: marvell: phy-mvebu-a3700-comphy: use
 devm_platform_ioremap_resource_byname()
Message-ID: <20230322131536.2b43010f@dellmb>
In-Reply-To: <202303221007049346627@zte.com.cn>
References: <202303221007049346627@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 22 Mar 2023 10:07:04 +0800 (CST)
<ye.xingchen@zte.com.cn> wrote:

> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>=20
> Convert platform_get_resource_byname(),devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource_byname(), as this is exactly what
> this function does.
>=20
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
>  drivers/phy/marvell/phy-mvebu-a3700-comphy.c | 16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)
>=20
> diff --git a/drivers/phy/marvell/phy-mvebu-a3700-comphy.c b/drivers/phy/m=
arvell/phy-mvebu-a3700-comphy.c
> index d641b345afa3..9aeeedf59f44 100644
> --- a/drivers/phy/marvell/phy-mvebu-a3700-comphy.c
> +++ b/drivers/phy/marvell/phy-mvebu-a3700-comphy.c
> @@ -1241,7 +1241,6 @@ static int mvebu_a3700_comphy_probe(struct platform=
_device *pdev)
>  	struct mvebu_a3700_comphy_priv *priv;
>  	struct phy_provider *provider;
>  	struct device_node *child;
> -	struct resource *res;
>  	struct clk *clk;
>  	int ret;
>=20
> @@ -1251,26 +1250,19 @@ static int mvebu_a3700_comphy_probe(struct platfo=
rm_device *pdev)
>=20
>  	spin_lock_init(&priv->lock);
>=20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "comphy");
> -	priv->comphy_regs =3D devm_ioremap_resource(&pdev->dev, res);
> +	priv->comphy_regs =3D devm_platform_ioremap_resource_byname(pdev, "comp=
hy");
>  	if (IS_ERR(priv->comphy_regs))
>  		return PTR_ERR(priv->comphy_regs);
>=20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM,
> -					   "lane1_pcie_gbe");
> -	priv->lane1_phy_regs =3D devm_ioremap_resource(&pdev->dev, res);
> +	priv->lane1_phy_regs =3D devm_platform_ioremap_resource_byname(pdev, "l=
ane1_pcie_gbe");
>  	if (IS_ERR(priv->lane1_phy_regs))
>  		return PTR_ERR(priv->lane1_phy_regs);
>=20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM,
> -					   "lane0_usb3_gbe");
> -	priv->lane0_phy_regs =3D devm_ioremap_resource(&pdev->dev, res);
> +	priv->lane0_phy_regs =3D devm_platform_ioremap_resource_byname(pdev, "l=
ane0_usb3_gbe");
>  	if (IS_ERR(priv->lane0_phy_regs))
>  		return PTR_ERR(priv->lane0_phy_regs);
>=20
> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM,
> -					   "lane2_sata_usb3");
> -	priv->lane2_phy_indirect =3D devm_ioremap_resource(&pdev->dev, res);
> +	priv->lane2_phy_indirect =3D devm_platform_ioremap_resource_byname(pdev=
, "lane2_sata_usb3");
>  	if (IS_ERR(priv->lane2_phy_indirect))
>  		return PTR_ERR(priv->lane2_phy_indirect);
>=20

Reviewed-by: Marek Beh=C3=BAn <kabel@kernel.org>