Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp6010746rwl; Wed, 22 Mar 2023 05:30:50 -0700 (PDT) X-Google-Smtp-Source: AK7set+Yw94Ip1HuDWMPu6Ia6FQMlhX/NHxKO1QD5/PazvVj3f9qy5drpWG7/8uQ5qrAvbqeEQXm X-Received: by 2002:a05:6a20:1a91:b0:d6:b44e:f644 with SMTP id ci17-20020a056a201a9100b000d6b44ef644mr4960802pzb.59.1679488250118; Wed, 22 Mar 2023 05:30:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679488250; cv=none; d=google.com; s=arc-20160816; b=VO9AkvnQcyLzD9VhukywnZ6w1xOKlXN225vZD3uCoU7XSKBflZxiGTj+dInxUv3N5X oYNBrmW3I3dMl8OZUD6/bHbAfgCYSOJl1fW9Y1jmcQ36n2NM/aSMvPMP7euPDPisgiAY znNayNSdI58/TCpe/2vf6P0SQkPBpMTifOa3/jg3hBHHrsOTyMcKGln0xTuPsIxNzBnY H8d4/7IZIhHKYePzO7XskipqOSxKQfuBs28NeShvLTnYxJc0UHXpNhYfTdHFbRP/GTwu UuRiLyB+jUU7opn2QftlIuDKV3lY5yWGspxftsdB4usbDzw0kTL2j5MzGwStgEO+NXzZ rWdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:content-disposition :content-transfer-encoding:mime-version:in-reply-to:references:cc :user-agent:date:subject:to:from; bh=UqksWiacA80a8vfK7eQsGm9tcgXqQh0s4hXu8pkbAiI=; b=FyPqXxIydqL1wxusrYoZGOrx6Rb0kPI3xuoxr41pg/o+FyrLLK0nbhTagdBD9nRIyn CHlbaRcV/k/0pUI8yEJYLyyL7aTxi3yFjUSUJL52sHaJ4EYwF7tzcu6XxGzQ46eaC0qA 4Kzf/iP2+0vxNrbwKIAh7+fqex5Zv8LzaQ620yxlrZSctVnjw8JTC4lobT9e1N7JuJCZ VX2I0kEFFURCW+nQyJRxqKIAOhKoiM9IiFxhVWMmTa6fHsVue6HsBGbblZgsu+N8wsh3 Cygbc6F8Wh2+QpQr0c6XrxejNlcwgPKLgZ9ulQVIopabZ1p1FXpiTBdn/H6RxfXqbiAz WivA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t70-20020a638149000000b0050f9b7ec155si5649711pgd.51.2023.03.22.05.30.38; Wed, 22 Mar 2023 05:30:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229807AbjCVMLF (ORCPT + 99 others); Wed, 22 Mar 2023 08:11:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229864AbjCVMLD (ORCPT ); Wed, 22 Mar 2023 08:11:03 -0400 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 094AB5F6D6; Wed, 22 Mar 2023 05:11:01 -0700 (PDT) Received: from [192.168.0.2] (chello089173232159.chello.sk [89.173.232.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id D3E7D7A00F2; Wed, 22 Mar 2023 13:10:59 +0100 (CET) From: Ondrej Zary To: Sergey Shtylyov Subject: Re: [PATCH 00/32] pata_parport-bpck6: rework bpck6 protocol driver Date: Wed, 22 Mar 2023 13:10:42 +0100 User-Agent: KMail/1.9.10 Cc: Damien Le Moal , Sudip Mukherjee , Christoph Hellwig , Jens Axboe , Tim Waugh , linux-block@vger.kernel.org, linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230307224627.28011-1-linux@zary.sk> <202303181955.41922.linux@zary.sk> In-Reply-To: X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <202303221310.44235.linux@zary.sk> X-Spam-Status: No, score=-0.0 required=5.0 tests=NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 19 March 2023 21:02:43 Sergey Shtylyov wrote: > On 3/18/23 9:55 PM, Ondrej Zary wrote: > > >>> This patch series simplifies bpck6 code, removing ppc6lnx.c file to match > >>> the simplicity of other protocol drivers. It also converts the direct > >>> port I/O access to paraport access functions. This conversion revealed that > >>> there's no 8-bit and 16-bit EPP support in parport_pc so patch 11 implements > >>> that. > >>> > >>> Tested with Backpack CD-RW 222011 and CD-RW 19350. > >>> > >>> Signed-off-by: Ondrej Zary > >>> --- > >>> drivers/ata/pata_parport/bpck6.c | 452 +++++++++++++++++++++++++++-------- > >>> drivers/ata/pata_parport/ppc6lnx.c | 726 --------------------------------------------------------- > >>> drivers/parport/parport_pc.c | 20 +- > >>> include/uapi/linux/parport.h | 3 + > >>> 4 files changed, 370 insertions(+), 831 deletions(-) > >> > >> OK, it's finally clear I can't keep up with reviewing 32 patches posted > >> at once... Luckily, all those patches seem to be dealing with parallel port > >> control), not the PATA control! Of course, when I volunteered to review the > >> PATA driver patches, I didn't expect such patch volumes -- I mostly expected > >> some odd fixes, not a massive driver rework... :-/ > > > > So you're going to review the (P)ATA parts (if any) only. > > I saw no PATA parts in this patcheset... > > > Maybe Sudip (as parport maintainer) could review the parallel port parts? > > I have no objections! :-) Looks like Sudip does not care. What needs to be done so this can be merged? -- Ondrej Zary