Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Mar 2023 09:36:45 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Christoph Hellwig <hch@infradead.org>,
        Kevin Tian <kevin.tian@intel.com>,
        Will Deacon <will@kernel.org>, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] iommu: Use sysfs_emit() for sysfs show
Message-ID: <ZBr2XZr25jwAp3kO@nvidia.com>
References: <20230322123421.278852-1-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230322123421.278852-1-baolu.lu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AghIFUg0SJJkBShgCiFypbu8NkM+3+mnrggfDo13DSRMddlEAF8v+JUpMtfV?=
 =?us-ascii?Q?Mm+ie+GzN37r3FZTcOQ7AqOrT9HJXpQpNqYhAb2TDYPYlVHrcBjBwPclkqbI?=
 =?us-ascii?Q?Jbnz7vUWbL+TA0o6mo8Q80EuS0dTpsL7NELWqaC7WBQ3CGUSGFNuLcak8lwl?=
 =?us-ascii?Q?4BmRnKyMsNyfvmtpuPzAnAvMOovcWXENRbOERVGVyTRMZPq5OXg5u4Pi0xQx?=
 =?us-ascii?Q?OTk2TTu1odrgNziBS1IQ/VEsR/IbSrkIIDcrJasmI3uzWygVNs2b1aH8vDtU?=
 =?us-ascii?Q?LRt2C93UZUlFWl822gpu+IXcNbu3xv6uZcgKpVnjHY6EybmeVwtWmgoRk5x6?=
 =?us-ascii?Q?mUjUNSk/zWfBog7iqOas/LPiQQKpOBEnY7/K8oDMVcPQOnxWIkCpJIl79X+G?=
 =?us-ascii?Q?MGn2CyV8gA4zZX7JA4hAiKm6L+5/JHXD0ecmXh/wlM9qrSRSZgHsXfy27/wj?=
 =?us-ascii?Q?WtqwDY259OCRtFv6eEt4P32xM0dgZSVAlOzfLq+DTRCW57YNpSwUlZXStdqq?=
 =?us-ascii?Q?BB2e435FHpSSKADKHERkKMfE1iec+hO4YPLmt0F/rlb87hPY5+elwX13H11K?=
 =?us-ascii?Q?205MoTE3kk4DbpEp2WWeYlMqm4wnhFp532aWX7sCp9Rt16pM6K5uPSqZHdxc?=
 =?us-ascii?Q?rNW41HlldKqSpz5gUXwcudV3UDvh1SGFplWYpSXmnXHyWLN+OVD1x4Ltkw5K?=
 =?us-ascii?Q?GDYmbDygVsPgWtEq9kAVWVIndok4l5D3zicYmrVQUsIl3eu4lGRUZPRqWxrL?=
 =?us-ascii?Q?DBRjM4LlVzRce2nkPHqxuaf6GeKUrx8YUOjccBomoNl4YelIID4c5FS1yVUc?=
 =?us-ascii?Q?9kiVjnOmj1dut6M3zFuGUmdkAMAtTJmp/x6g1LQipoOfliUMUO9QMlxWM6ls?=
 =?us-ascii?Q?Bp0mWGxTAPUDo/fYmebrN2m6c67rZihjKwv5z8GzSseP5rLsRMbzZBxVbriX?=
 =?us-ascii?Q?VVbET6wrdtr3rOUExz8KD0I7cZcjPck2gAhlhdJyFNw08CXH+cNueXWQxN+0?=
 =?us-ascii?Q?hqwRx9J0UrXvHrIC3wjwgUI6p7vIZX68baP6VJt73v1TfASL8gsPd+MAVic8?=
 =?us-ascii?Q?g5FXI2CmuzMmgR/nkm3FCwBs/o+3QmvymeaUzYkAu/LAeKLS4fhSFqpbvAne?=
 =?us-ascii?Q?LuK8pzK5V74qrcfvv009pbpDzLh6jZmlxsMqW/9Du9uWkhAFdwty0A7lw6xn?=
 =?us-ascii?Q?IhyNR7PajIoflfV5pATK6YeDowm8bp/V0aqbpL1j67LUyQ2VHzzQCwflq+eh?=
 =?us-ascii?Q?oeMeVGQh+xaCDHTZhO/z8qcss45u/KILOiQ3LVMyDpquau/1RqinyabwMMuw?=
 =?us-ascii?Q?70MkuHyUWKPzsbD4yt1wpsmSMBGrhCYb87Ztjo2il5R2iAVIk7tq3E4M3pMO?=
 =?us-ascii?Q?h/Ag+j6ZyNfRbCgsM4M0aUMuyleCkIhj5yvQcvqcMuuBScQ4IyUYbtAaUo6V?=
 =?us-ascii?Q?owT0/IBwKXav9uPmlvRHJ9R78cZZeWRxcfBaYwPqwwfWLG+iny7EiF/5ximO?=
 =?us-ascii?Q?g4lh3yxMGnwVRBmW5IDkpyO0OkQMaCN++5LdSs9JuXGVzU6edpgCazSgV/oL?=
 =?us-ascii?Q?gxD6aFOVHesGw7G2r4TA+s21mAcx3mMtjdgxt6sS?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64654f78-e480-4f20-a156-08db2ad2193e
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 12:36:45.9496
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +tumHJChtBee3tShv6Sk/Vf7cbqyuAevWJbdZme8V9lBqtQsmgeKhT1VtJVE+xvr
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7858
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 22, 2023 at 08:34:21PM +0800, Lu Baolu wrote:
> Use sysfs_emit() instead of the sprintf() for sysfs entries. sysfs_emit()
> knows the maximum of the temporary buffer used for outputting sysfs
> content and avoids overrunning the buffer length.
> 
> Prefer 'long long' over 'long long int' as suggested by checkpatch.pl.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
>  drivers/iommu/amd/init.c    |  4 ++--
>  drivers/iommu/intel/iommu.c | 17 +++++++++--------
>  drivers/iommu/iommu.c       | 31 +++++++++++++++----------------
>  3 files changed, 26 insertions(+), 26 deletions(-)
> 
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index 19a46b9f7357..a98202018140 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -1941,7 +1941,7 @@ static ssize_t amd_iommu_show_cap(struct device *dev,
>  				  char *buf)
>  {
>  	struct amd_iommu *iommu = dev_to_amd_iommu(dev);
> -	return sprintf(buf, "%x\n", iommu->cap);
> +	return sysfs_emit(buf, "%x\n", iommu->cap);
>  }

It would be nice to add the missing whitespace after declarations here
and other places to follow the coding convention

The conversions look OK though

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason