Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Mar 2023 14:20:46 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Tom Rix <trix@redhat.com>
Cc:     isdn@linux-pingi.de, nathan@kernel.org, ndesaulniers@google.com,
        kuba@kernel.org, alexanderduyck@fb.com, yangyingliang@huawei.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Subject: Re: [PATCH] mISDN: remove unused vpm_read_address function
Message-ID: <ZBsArtzFkgz+05LK@corigine.com>
References: <20230321120127.1782548-1-trix@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230321120127.1782548-1-trix@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XThWeFtnqriwHhzwWijVGGe6jVj+dkWSVa41co4gYA11BiKNtSuXk2lcw7lb?=
 =?us-ascii?Q?7ohZ/u2ud0kFgOcDBE1gxecKz1K9BHEyDpW8Gz86KtKjCsrKS4lewv8m3UT7?=
 =?us-ascii?Q?dzwmeHRQk3UxVSfd7AdAf3oZqPKtPmGZqNQ3DFRlkT+0ABiGVOcF1QoOXHcY?=
 =?us-ascii?Q?W7y8iEOXTKjIZYsfOhar0CNi15AaAO8MrZU376LVS15x1jf92T2iZbK5E0Mb?=
 =?us-ascii?Q?fK1AXjc/xonxZ+Ii90ol+vRrATtJlTHdm6eOFL6miPQZLnqxEgxB3hjEFkbV?=
 =?us-ascii?Q?xPFwcp7zPKKJgMoYsUqBcwDFmm6WgQuPv2ufCjQzB/kf8p8C/IBvsj5UakYy?=
 =?us-ascii?Q?9ljqnsc8TPZez8bcR5/XTiE9rYEh5IID7P1x64+TNU6lt18IPt8OE29Kwy2i?=
 =?us-ascii?Q?jRIktT4RfBuk2lKB0U9txxzlro6m2RQPxtTY4Zf2P3e0ejSXAhcrz9P/Q4W3?=
 =?us-ascii?Q?no76N2RFvYk7WnfmY+tDGdJRTSWC3ltAALLO7kbp/yog08KUfMM/8TYXyJe5?=
 =?us-ascii?Q?r9f+XKFM8iGoQlZlSZVqF6UBUEbB+SadYsZYyE2sou/5NFjK/sjE7oE0QnUn?=
 =?us-ascii?Q?A6h5b7m/DNdfokCdtTfEramzWqCEctiWczVTfXUnVB7p3Z5nu8E2vuSwbF5M?=
 =?us-ascii?Q?BfgXJujTafs0TjCFoG3v3MEX/S7eL/XnxvpdU+ml/+DZhYg/sXcfLQea0kOm?=
 =?us-ascii?Q?9xZUCWCBSbcGXQ/OpqtqW/erKsT6r1GiC6STy3MttqYD7Ko9IIutCWQfdzUj?=
 =?us-ascii?Q?GqpiFQlVf8mrdSHJCG4aRpui/NpqYBqS4UwNvKH/InD3oc6VEOEPhU73HnJV?=
 =?us-ascii?Q?ZhIo5mDeWUjqsvK1dOvC90xOd/nv8LHcVcDSvfDbbxOK35PY42iKSRHLg9l/?=
 =?us-ascii?Q?guOU4vbaoQG4AW/5EhQrcTVm7LY46Lsc92hDD0hFK6DP1WkDQ8opRo915fY/?=
 =?us-ascii?Q?X5afsd9Kl49bDLasOCz604RHhcovhlTeGoBiP7f+y1jY9aIDjmWcgmTSj9dJ?=
 =?us-ascii?Q?aTvQSXA+qwuAM0zQUeFlMOo7pXxzEbW9MTyJtm1DxkxDDkk48/emQWng/8Z5?=
 =?us-ascii?Q?xnbWIgXzSJP6hqUoOIubQP/vWrl+rzubvBitcnlB2s9RD7/+XJwUH79H+AOc?=
 =?us-ascii?Q?irqvZKWQFUzTcl88q7e/HfPyM/oQsoI6xx0tcOT/wkjCMVNu10wBmVz3F/R9?=
 =?us-ascii?Q?b4/xbyae4KNVDJALKELOb4RWOljMUrSBKPA4IKKz6ZbtpXXtOZYPjIStnJIw?=
 =?us-ascii?Q?DnJct1enVVyC3aghPEB1iP9Fl5i50jED49/OIGmNvDn6o0zghIOTzLuEImvS?=
 =?us-ascii?Q?QaIvNfzisiPjaG9Bhz8Hl+3pbLXFRHMaYBrGp7plrHb6qP6MN1nEBwWlTZZm?=
 =?us-ascii?Q?x4q1c6oGhhDya1bcjs/fiDPcremcjJ6BZFXvey8wGCpM/k4OBWNrwhVtuhyN?=
 =?us-ascii?Q?LeT+KfefrNLT0GPOJ1zsREHKNvxJA+BBCFsPw8IswZEuRCwVnaqZgrOK1czC?=
 =?us-ascii?Q?x+/CbqtwkQZkiEFmmA0brpnxBogbGm5n1uomSL3HrN8MiHsLKSkoaF9jM206?=
 =?us-ascii?Q?qrCkqbWTembcO7cELTQW8K6RsgnkQEdcjI7OPlIgquyv8NuCXyTK7DGnrwAR?=
 =?us-ascii?Q?0bNra90pfCEL4z80CKMeythI3BVBVUflY3nAkPbd9hCMPKAlyT+ktv1Z5Rvq?=
 =?us-ascii?Q?3Q40Zg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5962337b-f35e-4456-5145-08db2ad8434f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 13:20:53.6148
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fN+1SujG2YVcu78XifloGGA89RBErSGoRV3bgcW4duquJS9UF8aKbaBtr3Mb7LP8hytDAfVAsXDKxnS9X7hZ7JuO1kt2KiMBs7E0EUo30fM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3878
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 21, 2023 at 08:01:27AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/isdn/hardware/mISDN/hfcmulti.c:667:1: error: unused function
>   'vpm_read_address' [-Werror,-Wunused-function]
> vpm_read_address(struct hfc_multi *c)
> ^
> This function is not used, so remove it.

Yes, agreed.

But with this patch applied, make CC=clang W=1 tells me:

  CALL    scripts/checksyscalls.sh
  CC [M]  drivers/isdn/hardware/mISDN/hfcmulti.o
drivers/isdn/hardware/mISDN/hfcmulti.c:643:1: error: unused function 'cpld_read_reg' [-Werror,-Wunused-function]

So perhaps cpld_read_reg should be removed too?