Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0e7b4269-a96d-db71-b0a6-5e61af731fc2@oracle.com>
Date:   Wed, 22 Mar 2023 13:36:16 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH RESEND v2 09/11] scsi: scsi_debug: Drop
 sdebug_dev_info.num_in_q
From:   John Garry <john.g.garry@oracle.com>
To:     kernel test robot <oliver.sang@intel.com>
Cc:     oe-lkp@lists.linux.dev, lkp@intel.com, linux-scsi@vger.kernel.org,
        jejb@linux.ibm.com, martin.petersen@oracle.com, bvanassche@acm.org,
        linux-kernel@vger.kernel.org, dgilbert@interlog.com
References: <202303201334.18b30edc-oliver.sang@intel.com>
 <92a2d9c4-cc7a-6a26-07ea-b49ecdc920cc@oracle.com>
Content-Language: en-US
Organization: Oracle Corporation
In-Reply-To: <92a2d9c4-cc7a-6a26-07ea-b49ecdc920cc@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUV6eEFZcXQvaEhHeWwrUGkyUEh4UWJNeFFaM1J1Z0I0U0JEMm1yQXlZWmg3?=
 =?utf-8?B?bm1iSVZvVmcybVcwUWNNNUEvRWxyRHBkTk9BelA0TFBQMTZmdHRJcndNdTVD?=
 =?utf-8?B?ek51elBjclhFUjlwMUEyYlFMNThvQ0FGNXJyN3VBMzVRRkJhVlhiSGpxbTNu?=
 =?utf-8?B?dkFUT2NuS3dxblZvb3JIWk5leEoxNGEzT3ZRUFJ5bXl0eThadU9VSFp0UTJq?=
 =?utf-8?B?d3h6Q1p4TnlQMUFkMjFQcjJ1YTloTlp4V05udktXUW5ocnltYWhaNlhFbm0r?=
 =?utf-8?B?L1U4R0RYZWQrcXNLU3BHNmw5cUtFU01GNSthakQxRXA4QkQwdkx1ZzRiN2pT?=
 =?utf-8?B?U1RPaG9WTjY2NlAzbElxWTRVM3RBMmhKU2NGaXY1QnJXU3FEa1pJTDEzS2dO?=
 =?utf-8?B?ZytodFg5N2xSNzBqZjN4MU1qSHYzd2RleHdLZElldngxSEVkVFNuQUhxMU9t?=
 =?utf-8?B?UzdpQTN6NzVjak8vS0Y3L0Vrazh4T1E5NS9PN3dyTlZjcmg1U3NMSlA1ZThZ?=
 =?utf-8?B?OEg0cGNnVjZpcXV5Tk1FRGFIZ1lhcXlDZFlrMTV4Y3M4Z2NWd3FuYVNNRDNz?=
 =?utf-8?B?eW5qcFdwMzVoU2RsUHp0aExlYzFXZHdLWTZhWHRhN0t5OUpWbXJRT1JFZEhO?=
 =?utf-8?B?K05nM3c4VUJ5b1l6eDFkUG02ZkN5a1JZUnliU3RrWkQzUXNTYmticFZFNlpy?=
 =?utf-8?B?Rmp0QXZteW00cEw2a0h6SWpqWXZhNWdhVEwrdUdFSjkrTXZMMWE1dEsvMld5?=
 =?utf-8?B?OWNLUzFIMVNBZ0Fla2NsT045aTdrcEd3UHJBa21rbmVUU1dBRW9STjRPd2I0?=
 =?utf-8?B?VVEvcUFhWDhWeWJNaG5TOGtPSjUycTRmYjRGajlqVVN3RWhTM2IzYWw4SFlz?=
 =?utf-8?B?TzUraERzbWRtWFVPaVoxWUU3dE81T0FsTlBWRnVpMktjc0YyRmE1eEVkcGlJ?=
 =?utf-8?B?emRXNFp0RU5YdmRBODRNdWc1cjNJY25kOWY1VThPQjU0ekRYWnBXYis1NXBE?=
 =?utf-8?B?eWZ5dzJRc3ZkZkVEem1nOGZheE9oZnRlbXI5NlhVUHFHK1hDTEVPNS94SkQr?=
 =?utf-8?B?d3V6bkYvc2pIQ2hId0dMVk9UZXpwYnNJMEtMdUtUd1pIQ29XOGtDUFZKWnFE?=
 =?utf-8?B?UTNmYzg1VGp3bWVIMHlNbzRTTEVRcTNtaFJ3UlFHUlQ4U1NZUXAwM3F4NkV1?=
 =?utf-8?B?Y0NjNHBzOXBwS3J4MEJrOHh1ZWVEN0VYeUI1aU8rN1hzQzZqZzhXVnFiUVBN?=
 =?utf-8?B?aVAzTEIzOXlqazJnT0tjRStQeFBVaDc5MnUwOWwzZ0p3L2MvUXRMLzF5NEtH?=
 =?utf-8?B?bytxQmlVTmNoajFrQjlpNXgrYWhrUkVvWlZ4VFQ4eDBPV1l6aG1nenYyNW5K?=
 =?utf-8?B?N3VLNXlCM3VqU1d5Nlc5QjV2K3l4Z1h0SHZ5ZGpsb05WM2EydUFLemZ6RGpx?=
 =?utf-8?B?TjY0RGt4SVp6YStENWxOcThud2JBSHFLNTNyWk1LTGNLZnpyNkRJRGEyQmRX?=
 =?utf-8?B?dnVYV05FSFpjOVQwKy83SUNEZllBOVNNRktNcW4vRUhYZFZINnpWWjVnZ2t2?=
 =?utf-8?B?NlBIblIweEUzUHAvWmlKMHZtRnMrcCs4VjVmbVRDak9ySUhmODM1TDNUY0Qy?=
 =?utf-8?B?QnFzMTVZeHJjenYxT21hRENwVndVNm5hQSt2VUlpNEFtV3dyOFE5d1BLUlhw?=
 =?utf-8?B?bDM1T3A4SlBGSTJ1VVZKTTdKY3hMZWRRRUcySXkzNFpkNTkyOXErY0tYMU8x?=
 =?utf-8?B?aDF5TWoyL2NPRGdPR1VMYWlTaU80dHlUYldOWTYyTmg4MFB5VWx5YkJvcGQ2?=
 =?utf-8?B?cDMza2VzbGVJZGhzN1NRWTBoR1ZXSEdUOXhUSFprZjJDUytabFEvYlpsOU1Q?=
 =?utf-8?B?VDJUZjBnREs4eWo0NTlCN1R1NmYwMWdkdGp4OU1nRlk3U3p3UjFncEkvQklu?=
 =?utf-8?B?aWVtVXM4c2M3N1FlaUYxZm9zMktVbXp5emxLU0VmUHZpUmZackJ5aEx4Zk1Y?=
 =?utf-8?B?S0ZkZEVWd1F2T202MDhJbG9mcnRqeUlDSFZuUlJ1Q0FKcmZPand4aElCS0FI?=
 =?utf-8?B?TUZZVlJmUGZMWkZoeXQ4ZC9EYjhCT3R2RWlKWUFPMjVwWndXTHgrK3lLMFh3?=
 =?utf-8?B?aFVmelRCTGdIcmdHKzF5K0tpb3QxekwwdnF5ZUFrMitlU3hOUGN5aC9LcFQ3?=
 =?utf-8?B?Q2c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 9AC5OwckjxiRp2E5GIFXNes2s+5NKnQZI5y5DolwN5GTdw2FauU+22UqRGcN7ajUqLVRbJvd9xTb3iFLSrkBxYhIXD37/SEmLhz2dbWZT2+51lR2NuYytmeIFNM/Rb3RV46C6jdFKGuDY1GC+eEin1MqBptGe2PzKVaC4+vK+Yi+ycPaeVHKNKoCOd9xF7PRq4KwZBICEJ4w8Zur5WxnNrW9CLmInZDdLW7aMUSOsEYdet8sUWp8ksKDWLXnJpF/TP+KUipf0FU9Uk/Hl1JhjH5Lo41a2m4StZsgiF42sFo9/bjBMenzx8F2BgmC6e+6p5TkdiOlLMO0KbOKt/QGwo563Kttq7JWMFtrtxyFiWDNYFGMHlRAtNez4jvbbuaJawK12RKtBV7CoS3jVzhGrhnLeRsbgP17W8CwEQ8KqQI0xwOxQz63pKYwtpMVcsMRjJqmFERpLj0TecmH+1AXjEvuUaxr/9KmpTKDX+83NngZWlkCYjW/AxtutAIaiIiy+b9PvJrZEcxqUZLnk6mV6ZLv0HwKbxwlj0yvwMqi63OGyreKaY5vXBlucnA8bUHmCaOM0b0oonKEdp4s+mci176bGtAg1OvbMFdEzyigbLgnOEchwmlQQ0LGJ0UEqD9tuWRjjmfJIlThLYm0lIqPHgzXg3iJb/O/DZ92wqgQqMIJhKG7n8IblTI2qvaqIIgTOzlF+E09ypBuYcvCgIfyr6FOCDF34OUtgv2Q2AtIlcqTtqfBiNQJuswj7zVRXRsbII+wEOU1kBOAgHfm2gC8qiHaNXHfb6QwnggeYyuZvk4MJxhATQ/2HIEVaaZQmBKagJWAG6Hq4e3ny1KmGOJpAtvFD2UxK1hX7TKP/gu9wngNnh1maFgg+9akGIHYBh++wkb9dUCausrBwqaz93mXB2sRqNzj9fCDrS62QitB7vg=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4f465ed-5670-4f49-0a86-08db2ada6c7e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 13:36:21.6524
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u8Wy4CUL5juRzA/bE6E+AHzL8CdvGHj1jkZKEcSQQyBlLKWOnlOdvx05ULmIDMs7jc1HPRdJ52qsxacyBkD5fQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7017
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-22_11,2023-03-22_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 phishscore=0 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303150002 definitions=main-2303220099
X-Proofpoint-ORIG-GUID: uJlvYNPj4iS99dOyZPH-eBMWzcUO-mm4
X-Proofpoint-GUID: uJlvYNPj4iS99dOyZPH-eBMWzcUO-mm4
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20/03/2023 11:41, John Garry wrote:
>> scsi/004 (ensure repeated TASK SET FULL results in EIO on timing out 
>> command) [failed]
>>      runtime    ...  1.467s
>>      --- tests/scsi/004.out    2023-02-28 16:52:49.000000000 +0000
>>      +++ /lkp/benchmarks/blktests/results/nodev/scsi/004.out.bad    
>> 2023-03-18 00:19:00.232079954 +0000
>>      @@ -1,3 +1,2 @@
>>       Running scsi/004
>>      -Input/output error
>>       Test complete
>>
> 
> I'll check this now.

This should fix it:

--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -5580,7 +5580,7 @@ static int schedule_resp(struct scsi_cmnd *cmnd, 
struct sdebug_dev_info *devip,
                 int num_in_q = scsi_device_busy(sdp);
                 int qdepth = cmnd->device->queue_depth;

-               if ((num_in_q == (qdepth - 1)) &&
+               if ((num_in_q == qdepth) &&
                     (atomic_inc_return(&sdebug_a_tsf) >=


I'll send that change in my other scsi_debug series after I test further.