Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b0647255-ce4a-ff0e-016b-2868bb3d6d63@amd.com>
Date:   Wed, 22 Mar 2023 08:49:14 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v3 5/7] x86/resctrl: Display the RMID and COSID for
 resctrl groups
Content-Language: en-US
To:     Stephane Eranian <eranian@google.com>
Cc:     corbet@lwn.net, reinette.chatre@intel.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, fenghua.yu@intel.com,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, christophe.leroy@csgroup.eu,
        jarkko@kernel.org, adrian.hunter@intel.com, quic_jiles@quicinc.com,
        peternewman@google.com
References: <167778850105.1053859.14596357862185564029.stgit@bmoger-ubuntu>
 <167778869402.1053859.6094569492538617564.stgit@bmoger-ubuntu>
 <CABPqkBQWy2anBCvfo6DK5EyBxv3WrbUcxFVoLP=YsgYoQ1anxw@mail.gmail.com>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <CABPqkBQWy2anBCvfo6DK5EyBxv3WrbUcxFVoLP=YsgYoQ1anxw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFVNcFcxT1JLNU9oRUY3bE5FbTh5a01zMEJ0SzVHZ2tJcU9nRjhEdkcrNlYr?=
 =?utf-8?B?aWJMWFlzN2FldkxSL0RMN3hPd095dlBVMUV3dlllbFRqbGdPTWZOaTRmYVdt?=
 =?utf-8?B?MUFSTkVLSnlYdXg0NkNhVk1UdmZsVFVEZ1RtMzhyY3NPbVh2OWloOFd0aytq?=
 =?utf-8?B?ZWRiZzJrUWdmTVpUeERIb1dmOW9UZ25nZ2dnRzZUV1dleVR5K2dETjRDYlNm?=
 =?utf-8?B?S29IM3Jhay9vc0hCbFpkS1c5bGZWVW1tN1pzenFKak1YZUMzSlJjM2tCZHg2?=
 =?utf-8?B?a1krT1ZURWVzUkRqc0xKVVZCUWpSaVBKdjJ0V0tlRUNxaXJ1L1BZeFV6NUFB?=
 =?utf-8?B?MVMvUEs4WFU2aW81SWRVcmVWOHFGVDViZTJXcXBmUHVlWEhpcEEwUXluQ2p5?=
 =?utf-8?B?R1liOGVUSGJRaEgxaFVoZU14VjF4R3lVRVAydkFmMzhtdG1QYWp2bzNVWkJX?=
 =?utf-8?B?VEVNdEtXejJhUHIwS24vR1lmMUdsdEtWcEtSUmd0OXNydjUwL2FDd054RjVU?=
 =?utf-8?B?VzVmb1NXcmZhUUNTTXBLQkxZRSt2QWhjdkpmVE0yNGtiUGp3czArQVVoWGg0?=
 =?utf-8?B?bmhUdVJpWkZRMUwzQjNPVkhJL1BDNXo3Y0FjajFKK2xoUy9SRzg1alEyc3ph?=
 =?utf-8?B?d05NZmNoYlBRanJ2VVd2M3JXMkJjQzNJNGtkMHZGVzhERm1LOFQ0TE1xcjE2?=
 =?utf-8?B?b0lKUGV5QStoTzVuY3B6WnkxbUdUR3d1a3p1bTI2OVpidE5pUHJrcVFlRWRV?=
 =?utf-8?B?MmllWUJNV24yamY1b3JOcVd6NThrVkJDWVpOdnhUSVNQQVVqeDhJY2prN0x4?=
 =?utf-8?B?UFNqS1FLTzdtZ3Zub0QrZW5hQnNIMk1DcWxveW80a1NaUXlKdzc5Q2lnSFJ1?=
 =?utf-8?B?QWxhSXAzS1NOTVpQTm05YSs0TmsyWU40a1FFeWpYZG5yM09NbGZMaVh6V0hQ?=
 =?utf-8?B?WnJ3WjdRR2JIU2RvSkZ5Wi9TNXA1N3NGRjZwRjRyanVmQy92L0xaSmJDOFNW?=
 =?utf-8?B?RFZ2TE5HYytqTGlnTlpiZ1FrL2xCOG9mNW0vSFpGSUR6RmpHTm83aTJFYzhr?=
 =?utf-8?B?TktRQmN5c1ZzcXdQMlBMMWdMMjBpL3NseXNFWVhaNVdoZmxFQzJwOUU2Vnl5?=
 =?utf-8?B?aXJxUnpUTHIvZDVXZndTbjZsd2laQmU0NHpGc1VEVUhJYmFMYTZFc2xOZE9y?=
 =?utf-8?B?emsvT3hFM2VxSTZJNHRTL2dRNnNqcFFlNUtOY3ZNczkyOUc3QkpSaENoOFJP?=
 =?utf-8?B?UnlaWk1LVVNWZTIxSVVIcDdVc2EzYjJLdFB3NW1FeHZHY3J0Q3RuQ0dIMEk3?=
 =?utf-8?B?U3JMaE9paHl4V0NUTmlodG05blNvOENnZE1OM3BkTHl1K0dkZUhLenZrUlR2?=
 =?utf-8?B?ajVaZE1QQndrSTlka1RMelNQbmVORXFsN3g4WUlpNThHS2ZzdkM3Ujh3dlJz?=
 =?utf-8?B?dEZ0djhEbS9VWDBaamI4NWVqbVR0UW1uL00xL2J0dDkyYVF0NnJZU1BtbXJy?=
 =?utf-8?B?MlJZOXk5aFVhNFl4ZUcxdkphY3dDS2VmNlNEdGhhd2RIUnBYbkJYSllZcUhT?=
 =?utf-8?B?QjFBd3lOZXMvZmE1MWFYUVQzZGJtYXFJSDlDOGlaYkhPSFdTOHdlTmZlUVVx?=
 =?utf-8?B?bHpJOFVac0hvZSsyMCszbDR5YjZQdnFEMS9jVkk3R2kwRVdCMCsyT3BWdjQz?=
 =?utf-8?B?eElGOHRJa2RUaVl4RWhWTjNSOVM0U05hV3F6clhCRFYyL0NJOVhIRCtBL3RL?=
 =?utf-8?B?QlF4U3ZZNE1UVlAyYlM2Q0hNbHFhSitnd0RvTnZ1UnRHZUI5R1lHWno5Njkw?=
 =?utf-8?B?RE05ZEFSVDN1aG41a1dtOU5KNXM4UDJSNUZxOC9OT216NEIrZmtFRW5acWU0?=
 =?utf-8?B?YjY3VXh4bFFLanlkZThMZDFmS2JjNjVnNGZDMTYwQWRGbkMzNEtPaTdDNDVC?=
 =?utf-8?B?RXg2dGp6SE50SmkweXkyOUpzcGFFSXcvMEpEVHFWMDEwYytraHVIeWFNTmRM?=
 =?utf-8?B?ZExSbTFPeC93WmdueDBUUjRzZHBuNlZhUjZWUjRZL0RMQnQ2M00zUEIzRnRI?=
 =?utf-8?B?WHdKRFVhN25SL1BDVVhqa0Y0WmpRYytpLzZBaFRIZ0JGY29rL2I4amFUWXVI?=
 =?utf-8?Q?qZtAUr03Xppd5sd5ei60dZa85?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc045491-ce7c-4480-6662-08db2adc3c96
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 13:49:20.3530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +jc6khbREfZfTcSOl0QCXvxsY0ls0SU4uQ6VlnaLvpV9hM4M79cV8xCgh92+1m9F
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7458
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Stephane,

On 3/20/23 15:59, Stephane Eranian wrote:
> On Thu, Mar 2, 2023 at 3:25 PM Babu Moger <babu.moger@amd.com> wrote:
>>
>> When a user creates a control or monitor group, the CLOSID or RMID
>> are not visible to the user. These are architecturally defined entities.
>> There is no harm in displaying these in resctrl groups. Sometimes it
>> can help to debug the issues.
>>
>> Add CLOSID and RMID to the control/monitor groups display in resctrl
>> interface.
>>
>> $cat /sys/fs/resctrl/clos1/closid
>> 1
>> $cat /sys/fs/resctrl/mon_groups/mon1/rmid
>> 3
>>
> Is the intent here to be x86 specific?
> How would that work on ARM?
> Shouldn't we be using more generic names such as monitoring_id,   control_id?

Yes. We can do that.
Thanks
Babu