Subject: Re: [PATCH 03/24] create cleanup helper svc_msnfs()
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Jan Engelhardt <jengelh@computergmbh.de>, akpm@osdl.org,
       linux-kernel@vger.kernel.org, hch@infradead.org
In-Reply-To: <1190223930.26982.109.camel@localhost>
References: <20070917182718.70494C9B@kernel>
	 <20070917182721.8EF73A09@kernel>
	 <Pine.LNX.4.64.0709191939080.10201@fbirervta.pbzchgretzou.qr>
	 <1190223930.26982.109.camel@localhost>
Content-Type: text/plain
Date: Wed, 19 Sep 2007 13:54:06 -0400
Message-Id: <1190224446.6734.4.camel@heimdal.trondhjem.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1181
Lines: 34

On Wed, 2007-09-19 at 10:45 -0700, Dave Hansen wrote:
> On Wed, 2007-09-19 at 19:39 +0200, Jan Engelhardt wrote:
> > 
> > >+static inline int svc_msnfs(struct svc_fh *ffhp)
> > >+{
> > >+#ifdef MSNFS
> > >+      return (ffhp->fh_export->ex_flags & NFSEXP_MSNFS);
> > >+#else
> > >+      return 0;
> > >+#endif
> > >+}
> > 
> > The name looks kinda confusing. msnfs? almost makes you think
> > what's got microsoft to do with it.. 
> 
> I'd give it a better name if I had any idea what it means. :)
> 
> The macros and names are all preexisting.  I just took the liberty of
> pulling the #ifdef out into a function because the code got very
> unreadable with the other modifications that I need.
> 
> If it were some kind of larger API, we could come up with something
> better.  But, for a single isolated user, I think it is OK.

The msnfs option means enable the use of MS Windows share locks, so yes,
the name is appropriate.

Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/