Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f8a8890b-7a02-6824-b5aa-957008ebda53@linuxfoundation.org>
Date:   Wed, 22 Mar 2023 08:37:30 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] docs: add system-state document to admin-guide
To:     Bagas Sanjaya <bagasdotme@gmail.com>, corbet@lwn.net
Cc:     kstewart@linuxfoundation.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20230321231816.31131-1-skhan@linuxfoundation.org>
 <ZBrKcwoFMAhmIn1f@debian.me>
Content-Language: en-US
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <ZBrKcwoFMAhmIn1f@debian.me>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/22/23 03:29, Bagas Sanjaya wrote:
> On Tue, Mar 21, 2023 at 05:18:16PM -0600, Shuah Khan wrote:
>> +scripts/checksyscalls.sh can be used to check if current architecture is
>> +missing any function calls compared to i386.
> 
> i386 is the reference architecture for comparing syscalls, right?
> 

Correct. If you are askig about "function calls" wording, this is coming
right from the checksyscalls.sh

>> +This scripts parses Documentation/features to find the support status
>> +information. It can be used to validate the contents of the files under
>> +Documentation/features or simply list.::
> 
> "... to validate contents of Documentation/features files or simply list
> them::"
> 
>> +Let's do one last sanity check on the system to see if the following two
>> +command outputs match. If they don't examine your system closely. kernel
>> +rootkits install their own ps, find, etc. utilities to mask their activity.
>> +The outputs match on my system. Do they on yours?
>> +
>> +ps ax | wc -l
>> +ls -d /proc/* | grep [0-9]|wc -l
> 

Thanks for catching this.

> The shell snippet above should be in a code block for consistency
> with other snippets.
> 
>> +Linux kernel supports several hardening options to make system secure.
>> +kconfig-hardened-check tool sanity checks kernel configuration for
>> +security. You can checkout the latest::
> 
> "... If you don't have the tool handy, you can clone the repository::"

I can fix it to say "clone the latest"

> 
>> + * https://docs.kernel.org/trace/index.html
> 
> Shouldn't the last ref be internal link (Documentation/trace/index.rst)?
> 

This docs.kernel.org link intentional and it is better to this rendered
version.

thanks,
-- Shuah