Subject: Re: [PATCH 03/24] create cleanup helper svc_msnfs()
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Christoph Hellwig <hch@infradead.org>,
       "Dr. J. Bruce Fields" <bfields@fieldses.org>,
       Neil Brown <neilb@suse.de>
Cc: Dave Hansen <haveblue@us.ibm.com>,
       Jan Engelhardt <jengelh@computergmbh.de>, akpm@osdl.org,
       linux-kernel@vger.kernel.org
In-Reply-To: <20070919175909.GA24530@infradead.org>
References: <20070917182718.70494C9B@kernel>
	 <20070917182721.8EF73A09@kernel>
	 <Pine.LNX.4.64.0709191939080.10201@fbirervta.pbzchgretzou.qr>
	 <1190223930.26982.109.camel@localhost>
	 <1190224446.6734.4.camel@heimdal.trondhjem.org>
	 <20070919175909.GA24530@infradead.org>
Content-Type: text/plain
Date: Wed, 19 Sep 2007 14:10:32 -0400
Message-Id: <1190225432.6734.10.camel@heimdal.trondhjem.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1033
Lines: 24

On Wed, 2007-09-19 at 18:59 +0100, Christoph Hellwig wrote:
> On Wed, Sep 19, 2007 at 01:54:06PM -0400, Trond Myklebust wrote:
> > > If it were some kind of larger API, we could come up with something
> > > better.  But, for a single isolated user, I think it is OK.
> > 
> > The msnfs option means enable the use of MS Windows share locks, so yes,
> > the name is appropriate.
> 
> Yepp.  While we're at it, can we please kill the silly ifdefs for it
> (once Dave's patches are merged to avoid conflicts).  The code has always
> been enabled since it was introduced, it's an export option anyway and
> to make things worse the ifdef needs to be disabled in multiple files
> to make it consistant..

I'm sure that either Neil or Bruce would be happy to take such a patch.

Cheers
  Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/