Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Mar 2023 15:55:08 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] mtd: rawnand: mxc: Remove the unused function
 is_imx51_nfc()
Message-ID: <20230322155508.6f4acb80@xps-13>
In-Reply-To: <20230317074041.115036-1-jiapeng.chong@linux.alibaba.com>
References: <20230317074041.115036-1-jiapeng.chong@linux.alibaba.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

jiapeng.chong@linux.alibaba.com wrote on Fri, 17 Mar 2023 15:40:41
+0800:

> The function is_imx51_nfc is defined in the mxc_nand.c file, but not
> called elsewhere, so remove this unused function.
>=20
> drivers/mtd/nand/raw/mxc_nand.c:1602:19: warning: unused function 'is_imx=
51_nfc'.

Thanks for your patch, but apparently is_imx53_nfc() is also unused,
strange the robot did not pick this up. Anyway, no need to resend, I
received another patch removing both functions already.

>=20
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D4559
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/mtd/nand/raw/mxc_nand.c | 5 -----
>  1 file changed, 5 deletions(-)
>=20
> diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_n=
and.c
> index f6c96341b896..16d795c25609 100644
> --- a/drivers/mtd/nand/raw/mxc_nand.c
> +++ b/drivers/mtd/nand/raw/mxc_nand.c
> @@ -1599,11 +1599,6 @@ static inline int is_imx25_nfc(struct mxc_nand_hos=
t *host)
>  	return host->devtype_data =3D=3D &imx25_nand_devtype_data;
>  }
> =20
> -static inline int is_imx51_nfc(struct mxc_nand_host *host)
> -{
> -	return host->devtype_data =3D=3D &imx51_nand_devtype_data;
> -}
> -
>  static inline int is_imx53_nfc(struct mxc_nand_host *host)
>  {
>  	return host->devtype_data =3D=3D &imx53_nand_devtype_data;


Thanks,
Miqu=C3=A8l