Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <55bea6244a6d41e3d7d38d6cb6d379e9.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <79ceb9c5-2657-ca9b-e017-5ec14acfcda1@loongson.cn>
References: <20230321130710.20236-1-zhuyinbo@loongson.cn> <20230321130710.20236-2-zhuyinbo@loongson.cn> <26c4712672de6c4f70f88c6846bc892f.sboyd@kernel.org> <79ceb9c5-2657-ca9b-e017-5ec14acfcda1@loongson.cn>
Subject: Re: [PATCH v15 2/2] clk: clk-loongson2: add clock controller driver support
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Jianmin Lv <lvjianmin@loongson.cn>, wanghongliang@loongson.cn,
        Liu Peibao <liupeibao@loongson.cn>,
        loongson-kernel@lists.loongnix.cn, zhuyinbo@loongson.cn
To:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        zhuyinbo <zhuyinbo@loongson.cn>
Date:   Wed, 22 Mar 2023 08:16:13 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting zhuyinbo (2023-03-21 19:07:26)
>=20
> =E5=9C=A8 2023/3/22 =E4=B8=8A=E5=8D=887:42, Stephen Boyd =E5=86=99=E9=81=
=93:
> > Quoting Yinbo Zhu (2023-03-21 06:07:10)
> >> diff --git a/drivers/clk/clk-loongson2.c b/drivers/clk/clk-loongson2.c
> >> new file mode 100644
> >> index 000000000000..090810655511
> >> --- /dev/null
> >> +++ b/drivers/clk/clk-loongson2.c
> >> @@ -0,0 +1,344 @@
[....]
> >> +
> >> +static void __iomem *loongson2_pll_base;
> > Why is this a global?
>=20
> Normally, this should be an element in the structure, but since there is =

> only one
>=20
> element, It is directly defined as a global variable for use by other=20
> function.
>=20

Ok. Globals are frowned upon but it's just a single pointers so I guess
it's Ok.

> >
> >> +               return PTR_ERR(loongson2_pll_base);
> >> +
> >> +       loongson2_clocks_init(dev);
> > Please inline this function here.
>=20
> The loongson2_clocks_init had inline in this version, or do you mean some=
thing else ? Need to inline the probe?

I mean get rid of the function loongson2_clocks_init() and move the code
in that function into this probe function. With this patch the probe is
split to two functions when it should be one function.