Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <135cd1f3-e931-6099-279b-1e5c71bcb373@amd.com>
Date:   Wed, 22 Mar 2023 11:17:42 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] drm/amd/display: Remove the unused variable
 dppclk_delay_subtotal
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        alexander.deucher@amd.com
Cc:     Xinhui.Pan@amd.com, Abaci Robot <abaci@linux.alibaba.com>,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, daniel@ffwll.ch,
        airlied@gmail.com, christian.koenig@amd.com
References: <20230322015917.118874-1-jiapeng.chong@linux.alibaba.com>
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230322015917.118874-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cEs4UTh5ci80aURrMDVWbFRwOTEzSzE5MnNvTC9YamViWVgvVURlb3orUlhO?=
 =?utf-8?B?VXRFZGxsVWh2d2pNNy81d2JxdmFuaG5kQzlOdm8vd09pa1BQSllrV1dvL01w?=
 =?utf-8?B?L3dPQ0FlQUtzYUFsN1VsclVCT3VuaUJRM3RwcWtaU1JFbmhsR3ZWYTNXTjhr?=
 =?utf-8?B?ZG9XY0JVZlptNVdTeG1CL0ZuR1JZWHp3Uy82VFB3YkIzQjY1elhXbGY1Sm9V?=
 =?utf-8?B?SFJ5dEliV1EzSjRnMDkyY2F4SXFIenc5dlh0QlNJMmdLWDd0SllVT25zdUdh?=
 =?utf-8?B?Wk0xTjFnenRUUld1QjVEZFYydXB5NU5QYksyMEZJem15OFNUUWxwVEhiOHNV?=
 =?utf-8?B?aUpJRUI2YzV0bVQzaVBkVVkyRlc3Unc0TG5POTVEM3JhMXdJNjJkbGlkek42?=
 =?utf-8?B?RlQybjV5YVErL1NYSWdjdzJKa2pNVnZCOUdmampYdGVDMFVqbVBZNmRQUEZ0?=
 =?utf-8?B?NE41UTdLaktQZW0wdFJYaWpETE5tUXhpKy9QZFFWSDFYOWg4OVd4dDJBeTlv?=
 =?utf-8?B?UHp1Qm4wSkJNcnNOV0ZLTlpvSHpSbUFIY0tRaDFkK2p0QktvMTFWV1E0K1NL?=
 =?utf-8?B?VnFXMnJkN0RwVjRvTXc2SVpEMnIxWFF2cXB1N01BeUpQK2tSWUpmT0VsVGxU?=
 =?utf-8?B?YWNTZVRCNFNmUnpmU0ZCSzVYMFY1cHIzVHl0S2ZBYk9QSzhaZzkzVzh6akVB?=
 =?utf-8?B?N001LzlpRkRjd095NHNhYmJSclFFZSt0QkZOenRLVlQrWmRYazFpQ3R2YzZt?=
 =?utf-8?B?R0U3VzVtaDJJM1ZEak9vWVVpTk5YRTdzNkQ3WExWMVdQc2lNR0xpczZYWW1H?=
 =?utf-8?B?TG9uQm80U0JVOStEQnpPT0hwN1F1QUNaU1QyTDAvMGtuMW03cnRxNFQvYVVj?=
 =?utf-8?B?QzA4MjJESDdRVUErVmFkVzVBR3NINkhTM2s4OGtTUXR2cEhPMDBoNERUZTdL?=
 =?utf-8?B?Rm9saEJPVmd5d0NHRjNYaXpXNEorczhIZHZTVUdnZDVrS1V3QlFYUWx2V3pp?=
 =?utf-8?B?QU5qSWhYWC9MRGZHY0NMV3RQY2JjN3J0dVdoblFGUWZVZ0diUEtONHhEQUI2?=
 =?utf-8?B?SjVyRURFaDdLT29sQ2Q2Z1l5NUFydWxnbGRaRDhVRUZHVEd2ZGJMZ1N4Nkky?=
 =?utf-8?B?dVZxemEzeXdLMzh0RlFFWVNic29xMTVIbndyT254R2lDVnJYTU5HbEx3aXhO?=
 =?utf-8?B?eUdTQ29ndndwKzJoR2pZdDVRZ2Y2WmRGelI3OXN3Tk9rQVNQaloxL2V5OVh6?=
 =?utf-8?B?UVVodGpBOEw4QVNESlo3Y1ovZzhhVVp0ZTB6N1NBUGZZNGx0bXNFQ0lCd1VV?=
 =?utf-8?B?c044dXMxeUpaeWtadGJDMldmUWhqa0JxVnUzY0QycFhzamVQUHM4ZUl3b3hs?=
 =?utf-8?B?UTZzeWg0U0lDM0Y3YldQN3oxQWNjdWl3L2xKQ0ROb2xXbkFISVRSZjViRmF4?=
 =?utf-8?B?cHVGQ3grWWdmR29kcTRTWmgvdVB2cDQwMnpiN1g3WTF4cG1ySlJoNkZIb0hm?=
 =?utf-8?B?T2RxYThlMzl3TUdpb21aUS9iMFY1TjlkNzRLSXdoMUdNMER3cjB4N3krM2Nl?=
 =?utf-8?B?MUY4czdLS3FkeFRJNFpFSFJHRUVVSUxDUTVnUFVCRnVpQ2M2b0FQMCtGWjdz?=
 =?utf-8?B?VEVISU5FblNZQUxLUG80d0tFa1QyRjJ2enczY281SG85TUVGNXFVNlZhSWE5?=
 =?utf-8?B?OHQ3Z2MvbXN4d042QW81aXlpMVFUQWQvNjN6RkIzRkd6M0JCOVptMWhJYWNB?=
 =?utf-8?B?bWhlZTkzN09xM1VuWGRsVlhsazY2bVc3MnFHS3d3ZEFsZ0loRmhON0oxczlK?=
 =?utf-8?B?L3pGZlZUeFRxZWpoRlkyQWdOQTBsUlFPbEgwclRzaXNBRGpnQ0RtQ1ZSMGQx?=
 =?utf-8?B?TUQwQWR2aWYxQXl6aTluQy9KdEx4S1hKSm9pZ3RpcXp4MWJnT2JWbnZjbkN2?=
 =?utf-8?B?NkpBT1ZMM1JTdG11ZitBR2lDZXZtQjc5L2lWd2M5WG5zRHc0aUpFZ21MaFli?=
 =?utf-8?B?Y25VTDlNUy9BNVJ0VlFyWTVmbEhUMXRiOVBaK3QyWERuQnN6U2puNFZuR0dq?=
 =?utf-8?B?T2ZVT2xoeVF1SnBydjJMRDdBV2s5dlgyeEQzU1lDbXdBL0x2ZE5xNmIyM0Q1?=
 =?utf-8?Q?VyBBeVOu2d/SnTpumYfDbNFeM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0071a28-bdc8-4bfa-b323-08db2ae866e2
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 15:16:25.2156
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N0xhrmumsgCeT5GJLQxVMvAdj4n8j4U0ECiz7Qz0RNwrmXGW2RkeFnaiuIefHKQhVnLCZPv1s3GVekT7oklJYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4369
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/21/23 21:59, Jiapeng Chong wrote:
> Variable dppclk_delay_subtotal is not effectively used, so delete it.
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_rq_dlg_calc_314.c:1004:15: warning: variable 'dppclk_delay_subtotal' set but not used.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4584
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Applied, thanks!

> ---
>   .../display/dc/dml/dcn314/display_rq_dlg_calc_314.c    | 10 ----------
>   1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> index 6576b897a512..d1c2693a2e28 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> @@ -1001,7 +1001,6 @@ static void dml_rq_dlg_get_dlg_params(
>   	unsigned int vupdate_width;
>   	unsigned int vready_offset;
>   
> -	unsigned int dppclk_delay_subtotal;
>   	unsigned int dispclk_delay_subtotal;
>   
>   	unsigned int vstartup_start;
> @@ -1130,17 +1129,8 @@ static void dml_rq_dlg_get_dlg_params(
>   	vupdate_offset = dst->vupdate_offset;
>   	vupdate_width = dst->vupdate_width;
>   	vready_offset = dst->vready_offset;
> -
> -	dppclk_delay_subtotal = mode_lib->ip.dppclk_delay_subtotal;
>   	dispclk_delay_subtotal = mode_lib->ip.dispclk_delay_subtotal;
>   
> -	if (scl_enable)
> -		dppclk_delay_subtotal += mode_lib->ip.dppclk_delay_scl;
> -	else
> -		dppclk_delay_subtotal += mode_lib->ip.dppclk_delay_scl_lb_only;
> -
> -	dppclk_delay_subtotal += mode_lib->ip.dppclk_delay_cnvc_formatter + src->num_cursors * mode_lib->ip.dppclk_delay_cnvc_cursor;
> -
>   	if (dout->dsc_enable) {
>   		double dsc_delay = get_dsc_delay(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // FROM VBA
>   

-- 
Hamza