Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a7e45c16-cfc7-691c-8bf9-c187f85b7679@amd.com>
Date:   Wed, 22 Mar 2023 11:15:47 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] drm/amd/display: Slightly optimize
 dm_dmub_outbox1_low_irq()
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        harry.wentland@amd.com, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, aurabindo.pillai@amd.com, roman.li@amd.com,
        hersenxs.wu@amd.com, stylon.wang@amd.com
Cc:     kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <b7cff2c1976308c64951d466fd627989ef6e46fb.1679421347.git.christophe.jaillet@wanadoo.fr>
Content-Language: en-US
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <b7cff2c1976308c64951d466fd627989ef6e46fb.1679421347.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1NERUgxUGpRcXJ4U016N1M3NXRHeW1iN0ZiSm9PSzdEUjEzZGZlTkoxR3R6?=
 =?utf-8?B?WUdDK0dvNEo1a3R1VExkQjlNZDdGUlFYOUJLcWVDN3pIUWh3WldBaUhCeHc1?=
 =?utf-8?B?ZEFpUlphNWprSmVCczMzc0ozUnNDK1l3L3pEQmM5REYycXhrai9RbGdOVzky?=
 =?utf-8?B?ZmhhZlliYjUzTkZCaWtIdUlxOTI3TDZCVEJHYlZIbHp6azcrNnBINlYrU1dN?=
 =?utf-8?B?bllYZE1aVkRzU3pLSFhIYUg5WTEyYVYwc1Fmakc2V2x0ZlpuZTBvZ0Z6aHkv?=
 =?utf-8?B?MGp5ampnUi9LendLclJ3djNXcklWU0FBTGpTZ2VYKzQ4K0V1Mm8wY2NDR3BL?=
 =?utf-8?B?c1R4MGhBTWgreXVaWWV3OEJLZDVyeHltMTFTa2lBSDhGWHlPZndKN0hRMFdO?=
 =?utf-8?B?ZWZ4Tk1pdG5lWkVuVzF0WFcwUTlqbjAyZ0wyTG1vcm5sRHZpbURJbm9naSs4?=
 =?utf-8?B?dWFzejlvdWltSW12QU50MllxZlZKdHBreGltOXdRQWVFK0diRm1FMTRaa0xQ?=
 =?utf-8?B?ZW5DQVp6Q3lFeTFXZ3A2dDlEcTBCV2MxdHFJaEk1SFpTaUtFNy9xWVp2blBT?=
 =?utf-8?B?L1ZqUi96OW1NYlJRSFlicytFaGNJb3NWUktTcG5DVDZiSlZteE05bG1Vc3RD?=
 =?utf-8?B?YmJaVUd4Qy9GRzBCa00rQ053TlZaV0llRm8zd3Y0WWxNaXp1bUFaa1EvYmVC?=
 =?utf-8?B?OVJXTTNXKzRWMzZ3blhYWnJhTnJYdHRJVnFpeEhBNTJYeDBjb1FKdEtnM3BZ?=
 =?utf-8?B?QUU0Skx0WEJOeDNwZ1JNMmhBUGVsS0VDcFVzWGY0Sm1YRmhhUXBkVDVvRnZ3?=
 =?utf-8?B?a1VZK0RLakh5ZytkcUdHYVUvVWdTTFZsSy93UzhUYUU4Q3J5MEpiaE0rNFZu?=
 =?utf-8?B?ZEtLK2tucnBqcS92ckowMFJxbnBiR1A0MDdqT2JDY1h3MDZFZE1sQXVWdkJq?=
 =?utf-8?B?M3lWcHF4ekZnTlFCZGpCSm5kSXRYUURkZDk2ZFdJOXhYU3FkRk5JSllEb29z?=
 =?utf-8?B?MTBQZzh6a2dxTGo4OGwzTWhKUW5laC9YN0R4Sng3UmY0cnY2eFpDbC9YYkhr?=
 =?utf-8?B?bFppSTlwNUl1RFJUWWRCajVCQXNIbHptY01hZi83T0FOUVNTSlNvV2VDeFJj?=
 =?utf-8?B?MU9YL1BwNDgwSjZzdm1lcnRtU0JTeDRnNy9Ham1lUlVMNjd1MnNJZFkvckVT?=
 =?utf-8?B?OGNiN2hhbjZLN3FsWTRLNk9jTUEwUVBud08yRmdZQVBwQ29ySHo2SG9tVzhz?=
 =?utf-8?B?cldrRHpvM3lwcys2eklZd1dXa3hRSWt0eXN5LzBDSE5vbUFnZ0VRNjJoZCtj?=
 =?utf-8?B?OVluekNZSTdtbHl0dVpuKy9EZzRHUW9idzVjcEIwMnEvT1NmMXR1aUNMcWVj?=
 =?utf-8?B?bExzOENMWTdvNThsUjdmZEhla3ljSHIvNkJJVkNmMEVrMzlicjJNWUVwdCtu?=
 =?utf-8?B?MUJTRTgvL3pWU09iTlVISWZMUGlSNml0cTZlNGpyTDh1L1RLeXh3Y1A2aEZD?=
 =?utf-8?B?bHZsWGNvWU0wbS8xVW8vK2lKQjJUeHRVeHFqQVdBd0JoMlNWeldRazhGOVpC?=
 =?utf-8?B?M2JzWjZrUHA0N2xqRFBaanM4VEV3NFQxNXN3WGdrdXRrZWtOT2tlb1BVSnN1?=
 =?utf-8?B?S0JWWG1GTGZQbHpnZXJSRlpDVmljckpiVU53SThGSGNzSjRzNnR0N0QxTXpy?=
 =?utf-8?B?SUx1VzQzL3BndytiRmtQaWpJTUtPQ3FuRFBIQzlzcWRSYzJGRDB3Nk9zcWVj?=
 =?utf-8?B?YjltLzNMRHNGdytCVWRLNGlkSzcxTk9wWGsyWFNPcTgzNHdXL1FEb0xtWGNF?=
 =?utf-8?B?MmFOSG53ZVlBVCtqVGN6MjJwT0FUdURnV0x5UFM4dWQrUlF0SE5GS0dRVWZX?=
 =?utf-8?B?WjIveWY2VjhRTUZMV045WGh2SEZhZ21naXVSRGQ2L3NaaWc0ZC9jVWlPYkRk?=
 =?utf-8?B?ZzRaRlJFcktrR3VURGpNTHphd1dNNksrWVQ0dW9DWGowQ1U0QTNyTUVEa21s?=
 =?utf-8?B?bmh4NXFmY2YzUjB2Z3FicTJEOUdNS3VjWUJmSUhPYjAwL3ZQMm9ESU9PM1ph?=
 =?utf-8?B?L2g0eUhFL3E1RkJvcEtEd3VYeUM4TEVMZk9DRnJ3NFVnbW9sNFBoYWR4Ti9x?=
 =?utf-8?Q?2uSB96BCK+Zxr6+LaWGZUQYYN?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7ef6c1c-bcae-4fe8-9368-08db2ae822a9
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 15:14:30.8044
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fm1AsHV5ckNOmcEVHQtDouN35Tybi8t3WGdVl3eKMcImVjYrdXja0Elw26H2OUCJYms5ZWw4kRSMfSx1jJ28Yw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7646
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/21/23 13:58, Christophe JAILLET wrote:
> A kzalloc()+memcpy() can be optimized in a single kmemdup().
> This saves a few cycles because some memory doesn't need to be zeroed.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 5bac5781a06b..57a5fbdab890 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -820,15 +820,14 @@ static void dm_dmub_outbox1_low_irq(void *interrupt_params)
>   					DRM_ERROR("Failed to allocate dmub_hpd_wrk");
>   					return;
>   				}
> -				dmub_hpd_wrk->dmub_notify = kzalloc(sizeof(struct dmub_notification), GFP_ATOMIC);
> +				dmub_hpd_wrk->dmub_notify = kmemdup(&notify, sizeof(struct dmub_notification),
> +								    GFP_ATOMIC);
>   				if (!dmub_hpd_wrk->dmub_notify) {
>   					kfree(dmub_hpd_wrk);
>   					DRM_ERROR("Failed to allocate dmub_hpd_wrk->dmub_notify");
>   					return;
>   				}
>   				INIT_WORK(&dmub_hpd_wrk->handle_hpd_work, dm_handle_hpd_work);
> -				if (dmub_hpd_wrk->dmub_notify)
> -					memcpy(dmub_hpd_wrk->dmub_notify, &notify, sizeof(struct dmub_notification));
>   				dmub_hpd_wrk->adev = adev;
>   				if (notify.type == DMUB_NOTIFICATION_HPD) {
>   					plink = adev->dm.dc->links[notify.link_index];

-- 
Hamza