Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c93723aa-f01c-9f1e-c9c7-aa79f38390c1@infradead.org>
Date:   Wed, 22 Mar 2023 08:20:58 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name.
Content-Language: en-US
To:     Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>,
        Mark Brown <broonie@kernel.org>, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Masahiro Yamada <masahiroy@kernel.org>
References: <20230322085106.16629-1-mirsad.todorovac@alu.unizg.hr>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230322085106.16629-1-mirsad.todorovac@alu.unizg.hr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/22/23 01:51, Mirsad Goran Todorovac wrote:
> ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell
> syntax error in certain paths of the script execution.
> 

Fixes: 46dff8d7e381e ("scripts: merge_config: Add option to suppress warning on overrides")

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> Cc: Mark Brown <broonie@kernel.org>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: linux-kbuild@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-of-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
> ---
>  scripts/kconfig/merge_config.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
> index 32620de473ad..902eb429b9db 100755
> --- a/scripts/kconfig/merge_config.sh
> +++ b/scripts/kconfig/merge_config.sh
> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
>  		NEW_VAL=$(grep -w $CFG $MERGE_FILE)
>  		BUILTIN_FLAG=false
>  		if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then
> -			${WARNOVVERIDE} Previous  value: $PREV_VAL
> +			${WARNOVERRIDE} Previous  value: $PREV_VAL
>  			${WARNOVERRIDE} New value:       $NEW_VAL
>  			${WARNOVERRIDE} -y passed, will not demote y to m
>  			${WARNOVERRIDE}

-- 
~Randy