Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Mar 2023 17:25:51 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
Cc:     linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>
Subject: Re: [PATCH v1 mfd] mfd: ocelot-spi: fix bulk read
Message-ID: <20230322152551.q5sjc62yu3ijp4wj@skbuf>
References: <20230322141130.2531256-1-colin.foster@in-advantage.com>
 <20230322141130.2531256-1-colin.foster@in-advantage.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230322141130.2531256-1-colin.foster@in-advantage.com>
 <20230322141130.2531256-1-colin.foster@in-advantage.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NFj9R5TKEPb5D13b6XgC9wY3QynJffchPFHBPcW96b2ZrjgQX5rFNKY2YGai?=
 =?us-ascii?Q?6wuSSiWTP/vTURBBXlc0n2dO0JRrZYyEh5DeiWOq52vgG0lerrHgvqjcNhdH?=
 =?us-ascii?Q?MBWSYBb9U2oFQ3zF6N2imlg0qS/dyIiXYA4B43d2Hs+cK4O0ZxHC1rIKSxfp?=
 =?us-ascii?Q?9zaKK0eCX2p7qBVoN/coG1OwZdQwdfvUAh0oKC2WONyHVRHyc0cdplBLC8jv?=
 =?us-ascii?Q?merOOBdFeFgrGecJBWHol5xfPvXJbeEdU8UwO16RM2w42wfQcHbcl57M0GG6?=
 =?us-ascii?Q?cP93evonZItbHuY/IQZfpmcc3G51dh77nPxw+1B9qS9rHAHpVkT1qk2HP2Cn?=
 =?us-ascii?Q?ekpxmuOpW6jcs8fzaXPCKlIZ1QmoVjoOsu9lbcyN8TtIPKr1VxpK5Yqia1FO?=
 =?us-ascii?Q?eGlvSKVnOMt3mIgNiAK3+r6EQ4S3eDCYMxThAt/WV/Cy676z0VCCXvata+1I?=
 =?us-ascii?Q?WdKt9he9luStDHgmhGfq4guS/lzQTfcdKD+MOqCgW9hbE2kMLKAb59TZfm2L?=
 =?us-ascii?Q?jmbKGg9mgP/YBxufMfshwo2tNnxk3qicLiM5GuX9D7PUMftRJ4ALoXHESnQd?=
 =?us-ascii?Q?oMdLUXUkyg/7rHmyebtpTU+S68L0Goct45H5QwQ7PpOwE+hAmnV5sF/l+UhU?=
 =?us-ascii?Q?xzqMfRcQLaLtY/o2H/Axk2cC2ve/ewhCFrsWUfstsLkOA8BXy7Uk8cXMle7S?=
 =?us-ascii?Q?FMyqARx/qZx+Q91uzamQ5tOQHPlMJtq93PsXx4ZUhrx/C0kDDNY2KoQD5wiy?=
 =?us-ascii?Q?2RnrSlUYnJJJd0KFUCHGsnQkBNblIO1LTxOZmRzagBN9TsztVfnJgLWpQ7g2?=
 =?us-ascii?Q?JLrP5fKfddiXd1/cQaxxMtYLNcmKBI0O3kPhNwj9DJq75Uplvf/njg3A4JuS?=
 =?us-ascii?Q?7U69EDOW80EdsHEc6ZQt3seKxmqJsXfahFkoKOiO8LRzPUMytifpqkdlh0pt?=
 =?us-ascii?Q?RgKbCD8gAkSDu2Hc5u9lUoFA7rz/c3Yyo98RFV6gTVScV6YX/Sxv0/nuJsgZ?=
 =?us-ascii?Q?dCMYxeJ3cFDQLFHgaIyhaiExx+LNMQ5icbKGKCoAdbgHrQfIblP7GmJ0fj7t?=
 =?us-ascii?Q?SDrZ/bLIKJf99P5mlRdFMxEX6G4g+veyYY3zistu98bmjugGuChDr9/lhtWR?=
 =?us-ascii?Q?M7LZbkCoHiFDXdCCTcI/hsKXKtVUDzXHpHa2jr4ETbcFGUe6BE1T3Dx66KRg?=
 =?us-ascii?Q?PrWqBR/Zq1uWjTBPgyqy8AWjsd8NsA4tIDCOnNMc4drrfbpuCGGpry5KNHr8?=
 =?us-ascii?Q?kidLHhHdLSqFDMfpraSah8MnbnGBnBZ7nKv2FXx+twW8SWsEMllVsb0kJm/i?=
 =?us-ascii?Q?lyuLN26FJZjUqlt2Gw+BEev0q01EsIop2rcO28BD9cGQzGXy9KGgiTSFdllK?=
 =?us-ascii?Q?enZU5busi/wAEyxwexCLJoGPP0OkJ2iW73vJ3UL/DyJkhu/T2j80Cy3GrTV5?=
 =?us-ascii?Q?wZZ8KHRIeVeU69UpI7X/mU5U6KgwAHJWdjj6WzxZInYnsZk3crmkyGYZbQhH?=
 =?us-ascii?Q?egpmMd2fCVZN0bBKQpMdYSbnU3b+n/DFpmEI2Z+uTrlZB+4Ittb9HnepjG4k?=
 =?us-ascii?Q?XKwvXayC5sYIikyNu+i5aCYFGVHiUpbM/f7xR7+I/u3J6BU1StI+FgglOpj6?=
 =?us-ascii?Q?3g=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce921e47-4124-441e-4f05-08db2ae9ba6c
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 15:25:54.8026
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YxzGSWIEeVCZmsGMxDXL2qc3QfG8X3/7izbDP2mQWRi2EEGnElSWenY/HJd/TQjsEfmUqnh12yh0bTJtCj7tDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8401
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 22, 2023 at 07:11:30AM -0700, Colin Foster wrote:
> Ocelot chips (VSC7511, VSC7512, VSC7513, VSC7514) don't support bulk read
> operations over SPI.
> 
> Many SPI buses have hardware that can optimize consecutive reads.
> Essentially an address is written to the chip, and if the SPI controller
> continues to toggle the clock, subsequent register values are reported.
> This can lead to significant optimizations, because the time between
> "address is written to the chip" and "chip starts to report data" can often
> take a fixed amount of time.
> 
> When support for Ocelot chips were added in commit f3e893626abe ("mfd:
> ocelot: Add support for the vsc7512 chip via spi") it was believed that
> this optimization was supported. However it is not.

Details? What about bulk reads is "not supported", and not supported by whom?