Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <202303222158.8975b36d-oliver.sang@intel.com>
In-Reply-To: <202303222158.8975b36d-oliver.sang@intel.com>
From:   Ian Rogers <irogers@google.com>
Date:   Wed, 22 Mar 2023 09:03:28 -0700
Message-ID: <CAP-5=fV3x_=6JqVsX8Z_+5bz67de_5JcWX-1B=So18wpMK3r=A@mail.gmail.com>
Subject: Re: [acme:tmp.perf-tools-next] [perf build] a980755beb: perf-sanity-tests.perf.make.fail
To:     kernel test robot <oliver.sang@intel.com>
Cc:     oe-lkp@lists.linux.dev, lkp@intel.com,
        linux-perf-users@vger.kernel.org,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andres Freund <andres@anarazel.de>,
        Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@kernel.org>,
        Leo Yan <leo.yan@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        =?UTF-8?Q?Martin_Li=C5=A1ka?= <mliska@suse.cz>,
        Namhyung Kim <namhyung@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Pavithra Gurushankar <gpavithrasha@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Quentin Monnet <quentin@isovalent.com>,
        Roberto Sassu <roberto.sassu@huawei.com>,
        Stephane Eranian <eranian@google.com>,
        Tiezhu Yang <yangtiezhu@loongson.cn>,
        Tom Rix <trix@redhat.com>,
        Yang Jihong <yangjihong1@huawei.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Mar 22, 2023 at 7:20=E2=80=AFAM kernel test robot <oliver.sang@inte=
l.com> wrote:
>
>
> Greeting,
>
> FYI, we noticed perf-sanity-tests.perf.make.fail due to commit (built wit=
h gcc-11):
>
> commit: a980755beb5aca9002e1c95ba519b83a44242b5b ("perf build: Make BUILD=
_BPF_SKEL default, rename to NO_BPF_SKEL")
> https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git tmp.perf-tool=
s-next
>
> in testcase: perf-sanity-tests
> version: perf-x86_64-e8d018dd0257-1_20230320
> with following parameters:
>
>         perf_compiler: clang
>
>
>
> on test machine: 4 threads Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz (Skyla=
ke) with 32G memory
>
> caused below changes (please refer to attached dmesg/kmsg for entire log/=
backtrace):
>
>
>
>
> If you fix the issue, kindly add following tag
> | Reported-by: kernel test robot <oliver.sang@intel.com>
> | Link: https://lore.kernel.org/oe-lkp/202303222158.8975b36d-oliver.sang@=
intel.com
>
>
> [   89.510180][  T246]   LINK    /usr/src/perf_selftests-x86_64-rhel-8.3-=
func-a980755beb5aca9002e1c95ba519b83a44242b5b/tools/perf/util/bpf_skel/.tmp=
/boo
> tstrap/bpftool
> [   89.510191][  T246]
> [   89.801665][  T246]   GEN     /usr/src/perf_selftests-x86_64-rhel-8.3-=
func-a980755beb5aca9002e1c95ba519b83a44242b5b/tools/perf/util/bpf_skel/vmli=
nux.
> h
> [   89.801677][  T246]
> [   91.387572][  T248] libbpf: failed to find '.BTF' ELF section in /usr/=
src/perf_selftests-x86_64-rhel-8.3-func-a980755beb5aca9002e1c95ba519b83a442=
42b5
> b/tools/perf/util/bpf_skel/.tmp/bootstrap/bpftool
> [   91.387584][  T248]
> [   91.601268][  T248] Error: failed to load BTF from /usr/src/perf_selft=
ests-x86_64-rhel-8.3-func-a980755beb5aca9002e1c95ba519b83a44242b5b/tools/pe=
rf/u
> til/bpf_skel/.tmp/bootstrap/bpftool: No data available
> [   91.601281][  T248]
> [   91.626292][  T248] make[2]: *** [Makefile.perf:1075: /usr/src/perf_se=
lftests-x86_64-rhel-8.3-func-a980755beb5aca9002e1c95ba519b83a44242b5b/tools=
/per
> f/util/bpf_skel/vmlinux.h] Error 195
> [   91.626303][  T248]
> [   91.648913][  T248] make[2]: *** Deleting file '/usr/src/perf_selftest=
s-x86_64-rhel-8.3-func-a980755beb5aca9002e1c95ba519b83a44242b5b/tools/perf/=
util
> /bpf_skel/vmlinux.h'
> [   91.648922][  T248]
> [   91.667624][  T248] make[2]: *** Waiting for unfinished jobs....
> [   91.667631][  T248]
> [   98.262749][  T248] make[1]: *** [Makefile.perf:236: sub-make] Error 2
> [   98.262761][  T248]
> [   98.266203][  T246] make: Leaving directory '/usr/src/perf_selftests-x=
86_64-rhel-8.3-func-a980755beb5aca9002e1c95ba519b83a44242b5b/tools/perf'
> [   98.270224][  T248] make: *** [Makefile:70: all] Error 2
> [   98.272060][  T246]
> [   98.284492][  T248]
> [   98.290078][  T246] make perf failed

Hi Oliver,

Could we add NO_BPF_SKEL=3D1 to the build flags? The idea with changing
the default is that is what most users want and so we want the BPF
skeleton to be opt-out rather than opt-in.

Thanks,
Ian

>
> To reproduce:
>
>         git clone https://github.com/intel/lkp-tests.git
>         cd lkp-tests
>         sudo bin/lkp install job.yaml           # job file is attached in=
 this email
>         bin/lkp split-job --compatible job.yaml # generate the yaml file =
for lkp run
>         sudo bin/lkp run generated-yaml-file
>
>         # if come across any failure that blocks the test,
>         # please remove ~/.lkp and /lkp dir to run from a clean state.
>
>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests
>
>