Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Mar 2023 17:46:53 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: enetc: fix aggregate RMON counters not showing
 the ranges
Message-ID: <ZBsw/SRtCgfadtlC@corigine.com>
References: <20230321232831.1200905-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230321232831.1200905-1-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?01kIbfzSpfkLpcRlzZQzPwgFB9s6T0QgoUaDQyepbxHjwJV7Cco/OuJX8Vnf?=
 =?us-ascii?Q?6PVESL9XHjfkvsIltd/owNMeQVibyVomoC5hQcsPF4oG+5qZdLjsqShxrsAF?=
 =?us-ascii?Q?7f4NomAqVRNajU0XM/PDYSsmNH+0FeiXrumwXzRU9GVfPH/jt0/IaKE5dAcv?=
 =?us-ascii?Q?uQD058NFhGPXr01JbETBXVg2nFAyPPlOwfF4i/+F+gLtKOZx7ucT8wFjq/wO?=
 =?us-ascii?Q?9ihp+2Fb/2F1WuORlvm5g7PBAT/nLtejIVBW9IH0ZTF/42ZbutKSJ1JQlGnF?=
 =?us-ascii?Q?umfNwXYHF1P35oZKb1HN25tX5TE+eXSbP2KWHoyunhp+rrpbaUZDMX4EyMfe?=
 =?us-ascii?Q?99i/2zsTKZCGJPmMemUCQpFBZcH16DD8hEMfcyUF44BwXzEp4iJ8pSgEeS5x?=
 =?us-ascii?Q?8J/7GPeRQNvHcE2gvcBgN715D/fwK/XPEzsCxOZ2LyhjyTPLG/0ikPo6oKc/?=
 =?us-ascii?Q?uZ9TtZcUOm6HuwPkIUWEaHrixc4FZqFNSYz2D44nx8GE6yYgK0oKE8BEjWmz?=
 =?us-ascii?Q?h+Adg8YUtjZOr/ED9JvQfnMJLch0IsU9j9QX227CykJvYpCXtJGBkUqtyoS3?=
 =?us-ascii?Q?qr/iyOeswn/rz7vL00lX2FPLRgVHJ9DseVAYbFSB1yKhanAiQFAvN7YAXlGu?=
 =?us-ascii?Q?MeCzo+ycA71Kxe9hmgd6hvr8UsEN/6RmAUj7zr1AnTgD7gaA0GVAA51F0Jc2?=
 =?us-ascii?Q?DKuzv1UKiFaLQOUrSYjJxQvxwa9T3yLH82QvhOaltMbO4mWcvisyw1ZYYzcl?=
 =?us-ascii?Q?0ePwvvoGNBaEuJO/9bqNB6RqZqOdT2CQeTjSndFTZimLYT4ZuQ4mWcdSuCiX?=
 =?us-ascii?Q?Wpe5lmgLuMGPqw0+DcSUye6UG6IUzPfNQyIVU5KPo8iwBTM2MNFr6yoYKnhG?=
 =?us-ascii?Q?BnDBP5INqUdL4usxeYqBF36KKRHo7xnqANZYIBrqANBaqC/rrktfJn3AHMCJ?=
 =?us-ascii?Q?+9xzdhuEVLblBm58BqUot3mqibr9HPgZ6Bmlo6oZ3vZL1s8D8Siu/ItrfyJF?=
 =?us-ascii?Q?GpYtGqkxs2Cb90uWqpoZxz5YUd+10zfCN5NuPUD/o7la9ewLjDkgLXgqPdit?=
 =?us-ascii?Q?bfPjuCRjIqjcDLCldAe/CgZnNA/dg2QzMvtu75gdHhZ9pg7NX0fMWWOSQ4Yr?=
 =?us-ascii?Q?Mlap5B4oyzOspKmWu3RJpE9iDePwxwn9IrDOsMjtg5bbDN3Xl2SbgQ8txA3c?=
 =?us-ascii?Q?Gy6WfXxxHuwprs14Vxdj72hhbzTpfLG4MtIZ8oTk0DNuUwwnQRBhYI5eEarK?=
 =?us-ascii?Q?xrhFFeRp1y1fyLt2ICa4HQsMhKRjHL7SomwoP2c6SnlRGgdKVd/W4RI1ttwF?=
 =?us-ascii?Q?tBAlqqdpRNYWiOOeQUWBz54ctYuxC41abiUKx2I1q+4uoXrJKmNWeKLzlDPa?=
 =?us-ascii?Q?GeXb59tTzooKKmKItZI3h5G1OqNmqaM2j/YrF/YWT628hUmjDVsGlKowzoHH?=
 =?us-ascii?Q?S+rDeBpOIh/vuiA2NQXgwAntzHeywo3AyxmwBBlCRxSZYrl+Iju0v95tErfU?=
 =?us-ascii?Q?lLxFJxmrAqsJxLs0rMmL1sIX57DPom/6h2cHfBLaNsejP0wUYgrLklBAzH/T?=
 =?us-ascii?Q?Er/zFvbFun7GWbJqBJHtJjsLd1BwdkmaQSqct0DuXsLufxnClbaCfL3D3t8+?=
 =?us-ascii?Q?rQlDWHu/l/mghTQdmC5lKZhMj6tdetUZSAu6BpobJH3s+tn3/htEDddQ0nZm?=
 =?us-ascii?Q?XpZAeg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ba62350-ace7-46d9-a3a8-08db2af50f04
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 16:47:01.2404
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eyd9jm4X1wrWa120ekmkOylI0SJUWk9NYsaCtTXJeEoeLlkR8Y9MBrMCUdVYSH5aW/jgWsU1iSyuPf0Nv0qLV/W9Ci8FQlHqMzJ03yBt+00=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR13MB4683
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 22, 2023 at 01:28:31AM +0200, Vladimir Oltean wrote:
> When running "ethtool -S eno0 --groups rmon" without an explicit "--src
> emac|pmac" argument, the kernel will not report
> rx-rmon-etherStatsPkts64to64Octets, rx-rmon-etherStatsPkts65to127Octets,
> etc. This is because on ETHTOOL_MAC_STATS_SRC_AGGREGATE, we do not
> populate the "ranges" argument.
> 
> ocelot_port_get_rmon_stats() does things differently and things work
> there. I had forgotten to make sure that the code is structured the same
> way in both drivers, so do that now.
> 
> Fixes: cf52bd238b75 ("net: enetc: add support for MAC Merge statistics counters")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

This feels a bit more like an enhancement than a fix to me,
but I don't feel strongly about it.

Reviewed-by: Simon Horman <simon.horman@corigine.com>