Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Mar 2023 18:51:26 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Simon Horman <simon.horman@corigine.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: enetc: fix aggregate RMON counters not showing
 the ranges
Message-ID: <20230322165126.23bwb4rnnbuuwlnx@skbuf>
References: <20230321232831.1200905-1-vladimir.oltean@nxp.com>
 <ZBsw/SRtCgfadtlC@corigine.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZBsw/SRtCgfadtlC@corigine.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YjHwXTbFUmJg81Ku30RyDzGCSvu1rntBD8hO2KhL2y9ifLeDQ5s71+lYkHaC?=
 =?us-ascii?Q?ZiN7/L6IT9cxMrS7yu+CPG/Gq5MtsAQ14YkCIRwxQxDMjgq0NuLwCojLjAP1?=
 =?us-ascii?Q?uHHfZdGrK+rmj9s+Sd36w05zfMNX6L2DOCLYA7q3wQyZlF4fhrXCxi34dynL?=
 =?us-ascii?Q?R7yK0L29fgnILzyy4/phLUP2p2pxAndJKVGKaTKkAVURh6tkXq2BAnPs2YBa?=
 =?us-ascii?Q?uzk0FsL699wTBEUWMnKoMnRFazQUY3JVHBaqdeRuvOdJD0Olg8QD/EuaPLUA?=
 =?us-ascii?Q?c2cuzFGAlNq1DvXvxCJrMkhqGNQY8R+arlD4hGNLF43be2YPh+Pvfzq3xqaQ?=
 =?us-ascii?Q?FMvcVIJ0CApCTLY2lbG+bzYk0MJJocdJ6BV6AIorjaTkb9SQYBtYwjZ2f6Xt?=
 =?us-ascii?Q?lVSANXQzgCSahwHyFuSt8I+TrocLaZsyGU3KhEuUbFDyEFQTuhcNqTP9yJ9/?=
 =?us-ascii?Q?ZpkwLR3bv3VGhp9DDaMYlXD24iItsEZJ6MxCtsOlZjwCPZGVjVuBCocCCNH6?=
 =?us-ascii?Q?gziG8nMpJoMl9c47QUiJ4EkzoKkjpDWMvQC5MnhOx5cK0ki5RIeyrvNYltoq?=
 =?us-ascii?Q?g6RU/OLC4URZJUtFIs8lnOTH9wlNhfvnBjndfyyx/ufPoRb3IlucJt7cLTqC?=
 =?us-ascii?Q?SOjBva0bkNvR459QH90L1bPjZI7QSUAdV7cymuMC3wGSY9uufkDUDx7uB+ft?=
 =?us-ascii?Q?Un7K/VISSdL4eLUWSs7Eq/htuu1Uuc51zXPsbUu8VPMY73u2m108XuaJ+4F/?=
 =?us-ascii?Q?upqZvja5ioRx9nTiUHn2o7im1q3Rs3Ok178kdtdFhzbjkFWpvz16BE/YjE1q?=
 =?us-ascii?Q?Z6YtdV7Nbx3gruK+mHs/qY+ryrez2fnTAllnqmgHcNRqmseRSjzExILqibNJ?=
 =?us-ascii?Q?CHakYqahDkckSvL2ln6inL9SAiS+QelCgSPfUl0EqRMkArfod0NBZJDnz+q/?=
 =?us-ascii?Q?0PXB0iiNg1xZt5uIJTpNxFvQSZOT5a5/u2PGRC1w9eYmxaz/aeUJuXgTKjzm?=
 =?us-ascii?Q?NLcLjFUYlptcARxDale3DepPe4AaPvhExe0pJdXOThvBRdPD05PZXCVXb+Ty?=
 =?us-ascii?Q?v/+RcHLg6bqGIOl3mmdcv6XCmcIp3dPeEMzK2LenM+azxTXZEWUiZnmKODYQ?=
 =?us-ascii?Q?QEwadn4hOXbsbV2D5+tdliqMFcDvRZwTEnCMdaAgr8Is8xdmGHO9hO2GGHV5?=
 =?us-ascii?Q?Y2tGFnUhrLPgMCqlJtH10j0tD3byfiEoBHsyBpqu25YuBQXfhe9U2a/LSvfs?=
 =?us-ascii?Q?w1EIOpCYzAPq0fkq7dKMnlWTb9FHfSV/WQXHAaSFVmHCK+zZmw5Xkxsfom/i?=
 =?us-ascii?Q?qYQrTPhCTNgsKHg4wGIFGxP3Fabs6WKxqB+pFwIadbTNM3/Ku1WybGM93FBc?=
 =?us-ascii?Q?+AgqwWQGu5/cozgjLZ8pvFJ/iATMac1hYeSmzJ4vtUjVlGejgcKa6g2iv2YP?=
 =?us-ascii?Q?/agc3caMII2fq2jPgEOfFUcA+lm+BrLrhZOf369QQ9baCQ1GVLG2lP12ZT1E?=
 =?us-ascii?Q?jcpi2wx6cX5wHPsScZg2UuzgbCc1OSuA7zpQCz9XWHUTgPlUC02Avzp+vQZ4?=
 =?us-ascii?Q?nq+fJplhOU55E1leRBa5Se635G5x5g72YSL1Gcqye9QT/cZQ1Ge5is/kjuBW?=
 =?us-ascii?Q?pQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 564d57b0-917d-4102-cd24-08db2af5af2a
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 16:51:30.0197
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nehNIRlOStZrH/IdYBeIWB2lZDPQjUQhu/qBVaQZxxH2BV6BgkzFT+3OJtfH6skRG/VvybUs1jIDYbBi0sXYqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6852
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 22, 2023 at 05:46:53PM +0100, Simon Horman wrote:
> This feels a bit more like an enhancement than a fix to me,
> but I don't feel strongly about it.

How so?

Since commit 38b922c91227 ("net: enetc: expose some standardized ethtool
counters") - merged in kernel v6.1 - the user could run this command and
see this output:

$ ethtool -S eno0 --groups rmon
Standard stats for eno0:
rmon-etherStatsUndersizePkts: 0
rmon-etherStatsOversizePkts: 0
rmon-etherStatsFragments: 0
rmon-etherStatsJabbers: 0
rx-rmon-etherStatsPkts64to64Octets: 0
rx-rmon-etherStatsPkts65to127Octets: 0
rx-rmon-etherStatsPkts128to255Octets: 0
rx-rmon-etherStatsPkts256to511Octets: 0
rx-rmon-etherStatsPkts512to1023Octets: 0
rx-rmon-etherStatsPkts1024to1522Octets: 0
rx-rmon-etherStatsPkts1523to9600Octets: 0
tx-rmon-etherStatsPkts64to64Octets: 0
tx-rmon-etherStatsPkts65to127Octets: 0
tx-rmon-etherStatsPkts128to255Octets: 0
tx-rmon-etherStatsPkts256to511Octets: 0
tx-rmon-etherStatsPkts512to1023Octets: 0
tx-rmon-etherStatsPkts1024to1522Octets: 0
tx-rmon-etherStatsPkts1523to9600Octets: 0

After the blamed commit - merged in the v6.3 release candidates - the
same command produces the following output:

$ ethtool -S eno0 --groups rmon
Standard stats for eno0:
rmon-etherStatsUndersizePkts: 0
rmon-etherStatsOversizePkts: 0
rmon-etherStatsFragments: 0
rmon-etherStatsJabbers: 0

So why is this an enhancement?