Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Mar 2023 17:53:37 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: enetc: fix aggregate RMON counters not showing
 the ranges
Message-ID: <ZBsykS8b+antCVL1@corigine.com>
References: <20230321232831.1200905-1-vladimir.oltean@nxp.com>
 <ZBsw/SRtCgfadtlC@corigine.com>
 <20230322165126.23bwb4rnnbuuwlnx@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230322165126.23bwb4rnnbuuwlnx@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LVA038B7TN1VS9DRZrEscZyL8/ZmvmA+oovhjqOTryZHSnBPQk4AmC0IPLDj?=
 =?us-ascii?Q?oPaukGHSofyWziV01MicaNb9QhxUEzWH0rXSjjbxoOAWPG+/KUzuZ3KiVSO9?=
 =?us-ascii?Q?8z226PIjJU1jTt0vQQfmpEi6QEuqbeA8/e8rhMAhxNLPW9kPURSIij/5Nxo9?=
 =?us-ascii?Q?vW/zREmaBd9RhAYbm2BFPOSZNAQeuZWaa84KINxRTJGqRQPvQGPYpyhMPXij?=
 =?us-ascii?Q?iIcWE9Gzmm5H4H24PJprfZQzb6hdOhkPtQ6X1rPPuCsXI70R7eLSeCBBsg0A?=
 =?us-ascii?Q?xtDNjsrCB844BZbgsyCvEmDcUgth7RqlW4Z3+N+dqT+08y/GnEGzIXiOOuwY?=
 =?us-ascii?Q?mQDYrAvhnZrZlpBQw9RAsb2ipo7jZ5jI6W2tUoc3/ZYCqgzE1tJ0BCq2kgdp?=
 =?us-ascii?Q?uFKXkYTtWUktaU2jPBJpmdeGFx7Znf5QU/CttP3Mi8/gT2AtsfHSrYbP2DqV?=
 =?us-ascii?Q?v15MYDu0C0vkxAbX8PV2ArOsAFQa+g/aIbCr8Z5cGJtRSK2r4maiA2VWLMIM?=
 =?us-ascii?Q?woBM+btodVN+/Jfjht91a5MikxNcWUseI8WXN2k9tA5II2tq4ehU3KxKfUPB?=
 =?us-ascii?Q?cNKWQNAuUNkV05amSm/wE8RAyCE3Df/943uqljuAh53zE5kX6F7OPZVqcmRm?=
 =?us-ascii?Q?QpMQkymd8uWKaQoH4C0k38gky7mW9ik7+lTOPA3Cap8kKd5PoNkSnytaWbkL?=
 =?us-ascii?Q?4mt6uEVX4PPxYziEwQEMXOepDJZcxcxAYPF1GAV4rfXEs+bBc5EBKiyAbTv/?=
 =?us-ascii?Q?gm/0ieDPnS/xAceJn6unQUWddxvcQ7iA9BLipxLC/D23Ovft4/159zV040Is?=
 =?us-ascii?Q?b5G0bpBgajGjqDmuoeEXbPZMOItGtyTDreFh9kJcWTmRc1HIWS/ylw8KQMHE?=
 =?us-ascii?Q?6n7e1FnFvuVqmQt7acmNlLyyCMS+s17atPNoqxlIE43Z1kMMctwG11tuhVwz?=
 =?us-ascii?Q?DOqY9yxpfmx9+mMpRNAak0lxdJKroIcpjJkyewQoTTziA9xXkGO23evjH/m8?=
 =?us-ascii?Q?HyWVZD0tv431yDhzXSW+YSf915z1BtGwWzl9VKlAKC+4OiHAHbAjaqI6cC31?=
 =?us-ascii?Q?DAQPoPZzxj6OnN/nSe3P0fmdDtWfMMpeYA8J/ESrwqzvJE1rjxD6p888SJJJ?=
 =?us-ascii?Q?T3xM/fL1R6ICnNuP4Tog9jUsyiJp9aS/qtIns2p1v4RmIwXgSsCl8WuSXgeT?=
 =?us-ascii?Q?Ocefc7UDK0QuKUbE7rU083UsTpi1hkgZwW5Jxy78H3BWFkz82zwawrP26kvr?=
 =?us-ascii?Q?vLTGxqQmdrFNAvnzhrnA798hmKrJv+WDcr0yuTZAIDxgFpcA+xVvdoZJG+ww?=
 =?us-ascii?Q?KwN5VFfN3R6ocVgNYb2jt1UYxDWozYhZpap2qd6KPhJl1M/y+Y84LBboz/Bj?=
 =?us-ascii?Q?Xu4wTcnyBRA1boOnYhrd1/Qqct8Kktx4oyOZ2bxiVpVoTjLn4ggZQ1PRTQ3D?=
 =?us-ascii?Q?uXuhnyeYVqyqRtW0KZ9pHN7gA3Z3ISKMeCS2U4X3nn4+fB2rda08byA6ET8q?=
 =?us-ascii?Q?M8BoMi9vzw3w6a1YBlrbFB5tJRpaZjZ3RVkDZrBZ6NpVosssvbYvZIJgI/sT?=
 =?us-ascii?Q?H54LXEH8Qkho6o3CyAiBOleMTWf5bSPpSbUiGiljZkRGbC174zjjFVH7tJDr?=
 =?us-ascii?Q?NDU5TKJdd+2wT6oW8tt3T4Z5D+eyZSTpqJlYjDG+B8F030aP7MNYvXIFomSa?=
 =?us-ascii?Q?uBi7rA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2cb524c7-4fea-439e-37c9-08db2af5fe7c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 16:53:42.9214
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +7fZfFkueZnBwIq07LqkhPzP2qKiz2tRHx5YuMxa9icZEoNTLrFQkU+Ke19fjkrxTqW24zuJbYU19f37DlRJrEfa/Lcmrakd+4IQQAhps/Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR13MB5601
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 22, 2023 at 06:51:26PM +0200, Vladimir Oltean wrote:
> On Wed, Mar 22, 2023 at 05:46:53PM +0100, Simon Horman wrote:
> > This feels a bit more like an enhancement than a fix to me,
> > but I don't feel strongly about it.
> 
> How so?
> 
> Since commit 38b922c91227 ("net: enetc: expose some standardized ethtool
> counters") - merged in kernel v6.1 - the user could run this command and
> see this output:
> 
> $ ethtool -S eno0 --groups rmon
> Standard stats for eno0:
> rmon-etherStatsUndersizePkts: 0
> rmon-etherStatsOversizePkts: 0
> rmon-etherStatsFragments: 0
> rmon-etherStatsJabbers: 0
> rx-rmon-etherStatsPkts64to64Octets: 0
> rx-rmon-etherStatsPkts65to127Octets: 0
> rx-rmon-etherStatsPkts128to255Octets: 0
> rx-rmon-etherStatsPkts256to511Octets: 0
> rx-rmon-etherStatsPkts512to1023Octets: 0
> rx-rmon-etherStatsPkts1024to1522Octets: 0
> rx-rmon-etherStatsPkts1523to9600Octets: 0
> tx-rmon-etherStatsPkts64to64Octets: 0
> tx-rmon-etherStatsPkts65to127Octets: 0
> tx-rmon-etherStatsPkts128to255Octets: 0
> tx-rmon-etherStatsPkts256to511Octets: 0
> tx-rmon-etherStatsPkts512to1023Octets: 0
> tx-rmon-etherStatsPkts1024to1522Octets: 0
> tx-rmon-etherStatsPkts1523to9600Octets: 0
> 
> After the blamed commit - merged in the v6.3 release candidates - the
> same command produces the following output:
> 
> $ ethtool -S eno0 --groups rmon
> Standard stats for eno0:
> rmon-etherStatsUndersizePkts: 0
> rmon-etherStatsOversizePkts: 0
> rmon-etherStatsFragments: 0
> rmon-etherStatsJabbers: 0
> 
> So why is this an enhancement?

My understanding was incorrect.
I now agree it is a fix.