Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp6407455rwl; Wed, 22 Mar 2023 10:10:24 -0700 (PDT) X-Google-Smtp-Source: AK7set+SHd6ukT0C65WlDL0KwWa8OYQU4oDkfbBDgm4u3tA377U4K8eEi8SJ3czlKsf9hWUV8Hy1 X-Received: by 2002:a17:90b:1e4c:b0:234:ac93:d715 with SMTP id pi12-20020a17090b1e4c00b00234ac93d715mr4092548pjb.45.1679505024287; Wed, 22 Mar 2023 10:10:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679505024; cv=none; d=google.com; s=arc-20160816; b=wC5Pq/RhePZASsjy/obJPtCDVZgugScWB5gcX0oYRgysxXcSXramTym6flvoLJozc9 6B5/S1VY4Dg3JNU1enP6mkXWNICCX99tc7L387wWfyyXQhPQurrpQsttVm2u7J82J2wm 8lOR5iPK6hw0o/OaGjr9HC8dd1oSPY2X4OGRVzCNRfnWVXTJ7h7VKvKfjjpgG6ynbeC6 C5NifitHQVHgYMvFis5lMsGzu8vPSd7nVzJBmC/NZJ8KxGrqc37eFHIW4MNXRvcSbtB7 +tY3HXLaH3TWy5jdvdnIgnwKy3kcIg8jo1meeS3Bq0Bow4dXMoL7KNoZfbgWuZdR6qL1 8VrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=UQ/qCKKtUwESl9xaaIjrhAfZQFyi97d2S+2qUwoE1zg=; b=v3zrfYQS5yOuYmcUBJ5nuf7/hyqg7ARnm9A9NjP1hBaa6+lLlhi8QzyqVJ6SJTbwo9 LomFi+VElDCnALEMPT/Q7LWu+F7YXXA9Q3WkRsKfwdrcTRq05d4uBTn9s2TH1KN9vf7R kAAFiefAfOis+fA1upeW5YeK+KMntj3YBIeZic7IH8DOn7eLKRNbf/FRdtuKunvLPFEs zQPvYsVnHL7JlPB3MVH1JbWtHhMJ1br/f4Zrbo1KS+QfeyD+t8VS4y4Cg3BjhJH+HrMl hEbpswPmbybKAs75ddfLkLksBMUNlEvb3hTq00sVRG6udiMMkmTXgUqv2CGkcv9Z8qx9 9pew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b="Go9/j6vK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r9-20020a17090a690900b002239c987051si16438979pjj.128.2023.03.22.10.10.01; Wed, 22 Mar 2023 10:10:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b="Go9/j6vK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230402AbjCVRIh (ORCPT + 99 others); Wed, 22 Mar 2023 13:08:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230330AbjCVRIV (ORCPT ); Wed, 22 Mar 2023 13:08:21 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FDF1E05A for ; Wed, 22 Mar 2023 10:08:06 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id y4so75868032edo.2 for ; Wed, 22 Mar 2023 10:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1679504884; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UQ/qCKKtUwESl9xaaIjrhAfZQFyi97d2S+2qUwoE1zg=; b=Go9/j6vKoTDC/5mGgK/GUACxfIb88fOUkCayKBiNWp3zp6iZe+SKsmjQ4s9pP4pxVa CUQDs/JHWzfgytlKYJGLt7s64MUutg2O0rgiYtj9CZeasnwndA8GB1FdYj6BTsIkg/d8 30LeOw5gx1dGhJVAHH2iXerHBorpyA2+2m2wU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679504884; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UQ/qCKKtUwESl9xaaIjrhAfZQFyi97d2S+2qUwoE1zg=; b=Hzf78bSuaOzv2rrEVifJPm0O69hgBqxifvraU5QmDYjoR0VM8yuCOvMdP/gR7wYU0C hEI16u6xzLpPHJcKIzfoN94QcJ3kdban61z1kvzXF85YIf3y+uxvkEoUgYTtJRvap3d9 YPVGACeOORqaabpGMjhdHzxfTi7R5pPyEwN9VNSEIN0YdzwnWCjaxVbJTwLMkS5G9zgw GsWz3zUO/QjMF2Qme4ozlymAc7J6ZUC+IKvn/AWUs8WQmmdAPvozSdquD/vSbbYT8F84 1ADf4kOnEB0KZsrsfCw2ksU5EkmvdDBIUltM79BSflQvfnW1lTQIVgT/6UQSgCBstH7m 6idA== X-Gm-Message-State: AO0yUKW27A1jViLBGoZy9kkPfeD1c5aIWemddBS72T+afgobu/ANMAD2 bT6s5f0F589sLKyhT9mn2GJT/GdRCw0nmWgjTre1YVOG X-Received: by 2002:a17:906:395:b0:8b1:781d:f9a4 with SMTP id b21-20020a170906039500b008b1781df9a4mr7332785eja.21.1679504884442; Wed, 22 Mar 2023 10:08:04 -0700 (PDT) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com. [209.85.208.46]) by smtp.gmail.com with ESMTPSA id kb1-20020a1709070f8100b00933c4a25735sm4827773ejc.100.2023.03.22.10.08.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 10:08:03 -0700 (PDT) Received: by mail-ed1-f46.google.com with SMTP id eg48so75675530edb.13 for ; Wed, 22 Mar 2023 10:08:03 -0700 (PDT) X-Received: by 2002:a17:906:344d:b0:933:7658:8b44 with SMTP id d13-20020a170906344d00b0093376588b44mr3561499ejb.15.1679504883222; Wed, 22 Mar 2023 10:08:03 -0700 (PDT) MIME-Version: 1.0 References: <20230320071442.172228-1-pedro.falcato@gmail.com> <20230320115153.7n5cq4wl2hmcbndf@wittgenstein> <20230321142413.6mlowi5u6ewecodx@wittgenstein> <20230321161736.njmtnkvjf5rf7x5p@wittgenstein> <20230321201632.o2wiz5gk7cz36rn3@wittgenstein> <20230322101710.6rziolp4sqooqfwq@wittgenstein> In-Reply-To: <20230322101710.6rziolp4sqooqfwq@wittgenstein> From: Linus Torvalds Date: Wed, 22 Mar 2023 10:07:46 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] do_open(): Fix O_DIRECTORY | O_CREAT behavior To: Christian Brauner Cc: Pedro Falcato , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Aleksa Sarai Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2023 at 3:17=E2=80=AFAM Christian Brauner wrote: > > I don't feel strongly about this either and your points are valid. So I > incorporated that and updated the comments in the code. In case you'd lik= e to > take another look I've now put this up at: Ack, LGTM. Linus