Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7cf3ae87-9d7e-a846-89c6-d267ca76472a@amd.com>
Date:   Wed, 22 Mar 2023 14:01:18 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] drm/display: Add missing OLED Vesa brightnesses
 definitions
Content-Language: en-US
To:     Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>, airlied@gmail.com,
        daniel@ffwll.ch
Cc:     amd-gfx@lists.freedesktop.org, Anthony Koo <anthony.koo@amd.com>,
        Iswara Negulendran <iswara.nagulendran@amd.com>,
        Felipe Clark <felipe.clark@amd.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230322160513.1438881-1-Rodrigo.Siqueira@amd.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20230322160513.1438881-1-Rodrigo.Siqueira@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1hjL1RGU1h4bm5tWFhsaWlFS2E2VHJGS0k3eVdrb2ZUcHRGbkIyQXZON2ZO?=
 =?utf-8?B?Z1lDTnM1NjNPejNKTDNkZkxPUzR0dFNMdVkyaHY3dVZ3bHRYVTRRQUxSZ1J5?=
 =?utf-8?B?all4aFM1SmJtcFY3SXM1QWcwdDBQaXJwK1QvTEpuL3FXN0JFL2hlYlpNOElO?=
 =?utf-8?B?cjBqOEJWRkI4STJGa2VLeDRFSUdRTmtLY2VsVmRkYndPcjJyY3hmaVB4T09y?=
 =?utf-8?B?c1ozUGhFbUlGVjYvYi9TT2FMSzFGK0dDUU50TEYzd2dPeGFxMlVsUkRmK3JP?=
 =?utf-8?B?VzlqSm1Nb3ZVVXBGYjIwekVhdUlWdEN4aXJZY3JUeTN6ZlJrc1BxbCtIenY1?=
 =?utf-8?B?TU5ENDJ6Si9OaThEeE1hYU9zb1J2dURVbjRJU05pd1RVNllyQkxQeHkxMWpI?=
 =?utf-8?B?YmE4MGxZMjBGQnIvb1RXalBPNTBpeFMwSS8yWWk2SmFaWXhTeStmMGdReVJJ?=
 =?utf-8?B?M1VLWU5xaTdzM2ZTQW9xRUNCZ0NyRHYrQnd4L2pJNWV4SG9PTVNHOXlpSDdQ?=
 =?utf-8?B?Y0NsNDZteFBnNUt2dlN2ZnhYSlpleVRwb1hDNHpxc0krZkxkZzE0a1c3WE5s?=
 =?utf-8?B?SnU2VTRrUEZBWjVpYXRLRTV6T0Nwd0cwV0dZbEU4c2VORENZQWYrcmh5bVVt?=
 =?utf-8?B?NUhhZnp2TU10RUVzMmhmUDQ5V3hrbUdwbllkWEZsTlBZVnZ6eEJQVmJNR0pa?=
 =?utf-8?B?RytEU05QSWt2UjBpOEFkN2dmZTVOMjR4eC9tZ2k4bmVUcHRIRXJhdHhtVkxY?=
 =?utf-8?B?MGg5aGlraHE1Y1RBdmNtS291ZCtlY3A3Zmx1QXVYRklZQzc2cE1Cc0xnSHhS?=
 =?utf-8?B?UEF4ZVl0ejBSV3VETCtXK01qM29PODNXYXhwWHN4ZlUrODJubVJQZStjN2s2?=
 =?utf-8?B?NmZJd2VkajdhOUsvMDU1M3FvUmVrZDBWNytHMU9vMnVYSVZHM0l2OHhNckht?=
 =?utf-8?B?SitXMDl2ODQ3UjZMb2dOZVNsMER6Z1U5TGlGYTgzU3pxejBtbGhqZHpMbHlk?=
 =?utf-8?B?eFhwZlpvN0JCYXBpbTRxaCtFa3g3VTVRUlNmYks0V1N5bmF1ZDZZc05KWlFj?=
 =?utf-8?B?ZHVqSDhYVHJTRlRxZVJxWU04RjVkNDE2bkozeXVnVjlXeno4c1Y5SkMvdEVG?=
 =?utf-8?B?djdmRkhoa21rVFFidXc2eVFMVWsyVm9uaXRYdHJPTXl1RHpQSkJRNTFYZXNO?=
 =?utf-8?B?bytYQTZBUDg2clBrWWZZWWNxMWJkSUx6dzdmQ1IxTWlaaDZOTFd0LzNTR244?=
 =?utf-8?B?by8wZUg0R2ZQM1E1S08zQnlBMi9JUXdweTc5cGc4YkFyV1lrNDdSYWdRdnhO?=
 =?utf-8?B?amRKbG5UZG1ERWhvUnpqUkczM0VRSVhjVlN1RFBaa2xjUjBSckRjeHByYVJV?=
 =?utf-8?B?R25FK0pWZjBSbnl3aUdhNTQ3ZlNnb0RtMDFEUEo5aitnalBVd2JUZzZkRkJk?=
 =?utf-8?B?dzMxRzEyOU92ay9JK3AyWFdmTWZRMDZwaDFDbXlsWkZXWXgvL1Y5K2tNWkZk?=
 =?utf-8?B?Q0g5ajJnRWRJS1J5U0RUUzNUTEtLTUlTTFN0TU4wZ1I5cnNRdFlZdWRQdGpQ?=
 =?utf-8?B?dmlHbGxLcklQMGN6ZGg0T1o1Zko4L1krb3A4bFQrWWo0YThpU3Z3cHFHK1pU?=
 =?utf-8?B?aDRoVU9zMjQ5V0ZydnU1aGdNVWxwODRVb0tZaG5pbmRUWGxNK2JQVk1hVnhB?=
 =?utf-8?B?ZndDSUs1M1RienI5NWFoZ0k2dXBIbjMvZ3c3WVYxV1NoSFNQSkJHRFpoL21l?=
 =?utf-8?B?TGpWb2JYanBqUHk5dDNYMFV0S1ByWVNPSE1WQnMrVldQZ2ZSR2lrK2E3T3VQ?=
 =?utf-8?B?V0pwcFlzb0p1V1kzR3NwTUJtcGR6Sm9EZXI1cGxldDY3Z0JZSFdpSkdrcXkv?=
 =?utf-8?B?aHBna0ZNYjAza0JzaUFNM2h1dzZVSW9xSk5LMHY1SDcxNjdLeVhYUVBIY0dn?=
 =?utf-8?B?MDcrWFpDd1J6NUtTdHk5ZWNha3NTNSt4NzR5WWJaWncxQ1pyR3YvMThjUWpq?=
 =?utf-8?B?T0x3R2N2aVEyQi91UDBGQ1Z6UWwxMi8zTmN6dklGSWVaL0ZkdEYzdjRzaEpz?=
 =?utf-8?B?clM3dkxUd0h0a2xibzNZNlJoeXowWjNjaWxHcmZqNjV4UnhVNXJYTmhmSEov?=
 =?utf-8?Q?ZJI/RC5WT2FbuSDrnljNTvfl9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b080ea3c-5efb-418b-1399-08db2aff728c
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 18:01:23.2678
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f5AKPlJ2BbAqs5IpYbcDbk93/aDz3hF/VcSfnRyivwxkKwwQz29ys8WVvOSz3iJ2LCsHhJMbIdrCpWc5kcANtQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8362
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/22/23 12:05, Rodrigo Siqueira wrote:
> Cc: Anthony Koo <anthony.koo@amd.com>
> Cc: Iswara Negulendran <iswara.nagulendran@amd.com>
> Cc: Felipe Clark <felipe.clark@amd.com>
> Cc: Harry Wentland <Harry.Wentland@amd.com>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  include/drm/display/drm_dp.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h
> index 632376c291db..d30a9b2f450c 100644
> --- a/include/drm/display/drm_dp.h
> +++ b/include/drm/display/drm_dp.h
> @@ -977,6 +977,8 @@
>  # define DP_EDP_BACKLIGHT_FREQ_AUX_SET_CAP		(1 << 5)
>  # define DP_EDP_DYNAMIC_BACKLIGHT_CAP			(1 << 6)
>  # define DP_EDP_VBLANK_BACKLIGHT_UPDATE_CAP		(1 << 7)
> +#define DP_EDP_OLED_VESA_BRIGHTNESS_ON      0x80
> +# define DP_EDP_OLED_VESA_CAP				(1 << 4)
>  
>  #define DP_EDP_GENERAL_CAP_2		    0x703
>  # define DP_EDP_OVERDRIVE_ENGINE_ENABLED		(1 << 0)