Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dce372bd-e63c-f24c-5b79-1ef65fd1e59a@intel.com>
Date:   Wed, 22 Mar 2023 11:07:29 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 1/1] x86/irq: Add hardcoded hypervisor interrupts to
 /proc/stat
Content-Language: en-US
To:     Michael Kelley <mikelley@microsoft.com>, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        hpa@zytor.com, x86@kernel.org, linux-hyperv@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1677523568-50263-1-git-send-email-mikelley@microsoft.com>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <1677523568-50263-1-git-send-email-mikelley@microsoft.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/27/23 10:46, Michael Kelley wrote:
> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> index 766ffe3..9f668d2 100644
> --- a/arch/x86/kernel/irq.c
> +++ b/arch/x86/kernel/irq.c
> @@ -211,6 +211,13 @@ u64 arch_irq_stat_cpu(unsigned int cpu)
>  #ifdef CONFIG_X86_MCE_THRESHOLD
>  	sum += irq_stats(cpu)->irq_threshold_count;
>  #endif
> +#ifdef CONFIG_X86_HV_CALLBACK_VECTOR
> +	sum += irq_stats(cpu)->irq_hv_callback_count;
> +#endif
> +#if IS_ENABLED(CONFIG_HYPERV)
> +	sum += irq_stats(cpu)->irq_hv_reenlightenment_count;
> +	sum += irq_stats(cpu)->hyperv_stimer0_count;
> +#endif
>  #ifdef CONFIG_X86_MCE
>  	sum += per_cpu(mce_exception_count, cpu);
>  	sum += per_cpu(mce_poll_count, cpu);

This seems fine, especially since arch_show_interrupts() has them.  But,
what's with the "#if IS_ENABLED" versus the plain #ifdef?  Is there some
difference I'm missing?  Why not just be consistent with the other code
and use a plain #ifdef for both?