Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp6597816rwl; Wed, 22 Mar 2023 12:46:00 -0700 (PDT) X-Google-Smtp-Source: AK7set/e1MzJucSMW+C7qFRRyKdkCQMW9qBxbKu2BdLrA35Qc4bv7qoS+8aVaa9vUr9q3poSgjY0 X-Received: by 2002:a05:6a20:b806:b0:cc:7967:8a75 with SMTP id fi6-20020a056a20b80600b000cc79678a75mr558326pzb.46.1679514359946; Wed, 22 Mar 2023 12:45:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679514359; cv=none; d=google.com; s=arc-20160816; b=spqWWkisFlgbbx9RHAlunE5cxwB+3FRqLs/cK5Eqof00FGVfeJYrOBVfHDRyiQ7ZA4 MlKFVqtcdT5dXf8IDy7/XakZincI33FdyknuO7FLhVV+XcsAU9PC/rn9oBikyj1kCEUt aVReScAabIHjFlSHOXnYu5Zv7brtLD1GDE06mNBeSXuSU+kKYxqRppeRxY2WVTs7YWLI LgyhpTO3sCLqOg38byWfdonBspy5TgbXAwCM0+zImXi7VqJXhJj0UxuxsSXYjE3DLQE+ D8I4S7ixSO5+fYCcFiImlnWyyu2K1HR29iL0sUrcTZQa4Ey9dz6u3YLAoIK0YcL1xznT Z9Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mmglLE5oH+V8Tbw5lSX8yjxfe/MV+7OxcRsttZXtJoU=; b=Bw0WsaC/bynEKeCo0kMuZOZ+ajHCIfHJ+/ZqRjd6vOt4eaPSZbyUX0GOQ4XNu6wLEF 6LvkkpULN5YKY9C/KyK8WcXG8rw64ZT4UZMT58XLJgZ2cBGwyJWtMj5TVkO48SGwB2rk qGa/aivX1eURTKsvwgIF3uO+ItH6YmofMvO1jzIVBDMSEDlBHnbaLUOStatXfvm9saeC Fbvo14XF9z3epum5PtcM9VIdecMuNkprsCr1Nf+X4nvD/7fAjUCClRJo8KLsgK6uu0Uw lWHDFyq43Tl38SowB99Z+Jmn9DLPvL3HO+94doQDspL4MHkfjREI2FkBM+BGjOK+YbuH 05+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KsIagmLy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h9-20020a631209000000b00502d825633asi15934696pgl.639.2023.03.22.12.45.47; Wed, 22 Mar 2023 12:45:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KsIagmLy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229999AbjCVTpV (ORCPT + 99 others); Wed, 22 Mar 2023 15:45:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229838AbjCVTpS (ORCPT ); Wed, 22 Mar 2023 15:45:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6135E3E0BD; Wed, 22 Mar 2023 12:45:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EF741622B2; Wed, 22 Mar 2023 19:45:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E6C7C4339E; Wed, 22 Mar 2023 19:45:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679514306; bh=a59gUDfTCHexacSrsbU3Hhq+A3tfJIUWFd5dyE5PoH0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KsIagmLyRTqKsfR7uIUg9MjUB6redqBnrKvV76N6o1Vx+jY7uIq9Y/alf5qVC/2ey ohoXznoXXIOPSCCOrKmSUnBTPG7XgSSOYnAU0cwsvTb1jWWtbM7mUf8bn8zfxUqq7d sUKfStasnjoGheU7ibY1W95SuRdThbFK9Ec/iAOHru2Z9iREVbwiQjm2+mgwBrHgpT Rv8lUWHtGFZv1KFuOaULMtS5KzIMTqZzlDzOsR6T4Fl82KuJ/xakJuFUd6056Ubqmc H7gSghF0E0NFS/fX2z1J5oKfP42YjQUcRkcAmriowRcVz/Mqs+RrElKEEgy3Ag1wLo 1ff65pFu9K4+A== From: Frederic Weisbecker To: "Paul E . McKenney" Cc: LKML , Frederic Weisbecker , rcu , Uladzislau Rezki , Neeraj Upadhyay , Boqun Feng , Joel Fernandes Subject: [PATCH 1/4] rcu/nocb: Protect lazy shrinker against concurrent (de-)offloading Date: Wed, 22 Mar 2023 20:44:53 +0100 Message-Id: <20230322194456.2331527-2-frederic@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230322194456.2331527-1-frederic@kernel.org> References: <20230322194456.2331527-1-frederic@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The shrinker may run concurrently with callbacks (de-)offloading. As such, calling rcu_nocb_lock() is very dangerous because it does a conditional locking. The worst outcome is that rcu_nocb_lock() doesn't lock but rcu_nocb_unlock() eventually unlocks, or the reverse, creating an imbalance. Fix this with protecting against (de-)offloading using the barrier mutex. Signed-off-by: Frederic Weisbecker --- kernel/rcu/tree_nocb.h | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h index f2280616f9d5..dd9b655ae533 100644 --- a/kernel/rcu/tree_nocb.h +++ b/kernel/rcu/tree_nocb.h @@ -1336,13 +1336,25 @@ lazy_rcu_shrink_scan(struct shrinker *shrink, struct shrink_control *sc) unsigned long flags; unsigned long count = 0; + /* + * Protect against concurrent (de-)offloading. Otherwise nocb locking + * may be ignored or imbalanced. + */ + mutex_lock(&rcu_state.barrier_mutex); + /* Snapshot count of all CPUs */ for_each_possible_cpu(cpu) { struct rcu_data *rdp = per_cpu_ptr(&rcu_data, cpu); - int _count = READ_ONCE(rdp->lazy_len); + int _count; + + if (!rcu_rdp_is_offloaded(rdp)) + continue; + + _count = READ_ONCE(rdp->lazy_len); if (_count == 0) continue; + rcu_nocb_lock_irqsave(rdp, flags); WRITE_ONCE(rdp->lazy_len, 0); rcu_nocb_unlock_irqrestore(rdp, flags); @@ -1352,6 +1364,9 @@ lazy_rcu_shrink_scan(struct shrinker *shrink, struct shrink_control *sc) if (sc->nr_to_scan <= 0) break; } + + mutex_unlock(&rcu_state.barrier_mutex); + return count ? count : SHRINK_STOP; } -- 2.34.1