Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp6632835rwl; Wed, 22 Mar 2023 13:17:00 -0700 (PDT) X-Google-Smtp-Source: AK7set+7yD8UyY2DMJ8krptmNEb0RF9pYbHgyvP6BfLd9F6uABM5MKE0ctJC7fj9CLVAHNgRWJU0 X-Received: by 2002:a17:907:7e8e:b0:8b1:2d7f:ed57 with SMTP id qb14-20020a1709077e8e00b008b12d7fed57mr9951540ejc.42.1679516220152; Wed, 22 Mar 2023 13:17:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679516220; cv=none; d=google.com; s=arc-20160816; b=whfWsCHOc6LIOgL65eed8kuaYzO2N+nvSkxJOldb6HtzNfPKGdZc6FNq5OTYsZLmEN Edoixkove+g9fbBxzCMR0Rfi1NaawJcE6Hg0ktE30fFfbv0PNfBeozWYMJW9IonAcWNj 1Jz0lGHCJgOq452OoqHvVDazrVQIaGWdI6VqlFFBHJVGhnWTEDPBu0Y0qGo2iZ9gIyYh JnnXLM9puJSND3dxmaP3lAduwwvmqxU7LxCwzfopd8ktmfGiBSX7gSO9RnWk5lszSwZ3 iaMwatpx5pYfcNiOULCX6ddcYdStfO4mwXXaCxR90jRu/5Q0T2uC/CiAryzfvWCNJjMx RL0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=u8pYYRTdJJ1RT7XzDpXLhvTc8oK3bQatlnP/P8svCNM=; b=pe2uRd4imCJRZ9dAWprpQZgUCDmi8YUMhlM4lVjh7rF4tum03XA2jodOi/8SY27VvR +sGwQz0m5bd1HTNrlKXgZK/V/t763vXOXQOiiKa6RUMA2mGM5b+1ZQmOm/iMQXhAXkb/ VnoNo8dnbZuO785M1eTzj2WYVCu2zuYxCAbA+pRBRb4hDCY54Btn+K3ji8b2SasVJRMr xbVhMssylorI3shk1cYrA+UIXtgcvQIJc1iiNhfl5Bo2UDHnbtpm2Ifxn/DQxCExEcph H0dtAOEIEL6ErPdGruYQIcgGlqPR5RnhiumgU/o2O8XbJFzrss/qUYanuAdUA+a8Uuuv l6zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VECGmG74; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w25-20020a50fa99000000b004af50024631si19121312edr.433.2023.03.22.13.16.05; Wed, 22 Mar 2023 13:17:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VECGmG74; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232118AbjCVUPn (ORCPT + 99 others); Wed, 22 Mar 2023 16:15:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232347AbjCVUO7 (ORCPT ); Wed, 22 Mar 2023 16:14:59 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1292288892; Wed, 22 Mar 2023 13:05:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3D01BB81DE2; Wed, 22 Mar 2023 20:05:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0523C433EF; Wed, 22 Mar 2023 20:05:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679515509; bh=EauZcUtzlD9EeZdsLygkybO3oSxqsW90p055J+MpsuA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VECGmG74bccgZ4I4NQN5olkc4X3Grydc/t/WjnZjBGaZumR+zui6b7ry59O/NUDIQ AdGPcGSGykW7A3ls4pSymjJfwKoi3l+lme5WaEQsuxy84gEPUdzA9WezFPAD7/aFdl m8RkBUObMcUErGEE3La5OBaUeo78N/20tIzOPNTeQyuYts/YYjRdd5mXPdg5mkKbJ+ 7+R3esVcZT0RMoHqu8VYFgS+FhNjwxuMQEyIQc8h9aM2LvabGsHXDobbh6bb1YnvB9 GFPoHIc9Vu9866yc0kyqrxjKuYrqToIn0t5gVNjz8+1YiSuXB+7TZsYoUueK/xaYKm v5eSzCYWQzIuA== Date: Wed, 22 Mar 2023 20:05:03 +0000 From: Conor Dooley To: Andrew Jones Cc: "Jason A. Donenfeld" , Jisheng Zhang , Palmer Dabbelt , Paul Walmsley , Albert Ou , Anup Patel , Atish Patra , Heiko Stuebner , Conor Dooley , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, regressions@leemhuis.info, regressions@lists.linux.dev Subject: Re: [PATCH] riscv: require alternatives framework when selecting FPU support Message-ID: References: <20230322120907.2968494-1-Jason@zx2c4.com> <20230322124631.7p67thzeblrawsqj@orel> <1884bd96-2783-4556-bc57-8b733758baff@spud> <20230322192610.sad42xau33ye5ayn@orel> <2a3b08ce-5ab1-41b6-ad58-edbeff7b1acb@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="J4ue+fmAfy7X0A4F" Content-Disposition: inline In-Reply-To: <2a3b08ce-5ab1-41b6-ad58-edbeff7b1acb@spud> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --J4ue+fmAfy7X0A4F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 22, 2023 at 07:44:13PM +0000, Conor Dooley wrote: > On Wed, Mar 22, 2023 at 08:26:10PM +0100, Andrew Jones wrote: > > On Wed, Mar 22, 2023 at 03:17:13PM +0000, Conor Dooley wrote: > > > On Wed, Mar 22, 2023 at 01:46:31PM +0100, Andrew Jones wrote: >=20 > > > > (It's tempting to just select RISCV_ALTERNATIVE from RISCV, but may= be we > > > > can defer that wedding a bit longer.) > > >=20 > > > At that point, the config option should just go away entirely, no? > >=20 > > Ah, yes, and that makes the idea even more attractive, as we could remo= ve > > several ifdefs. >=20 > I went and did the cursory check, it's not compatible with XIP_KERNEL so > dropping the option entirely probably isn't a possibility :/ What I said is only now sinking in. We're now going to be disabling FPU support on XIP kernels with this patch. Well, technically not this patch since it wouldn't have built without Jason's changes, but that doesn't seem like the right thing to do... --J4ue+fmAfy7X0A4F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZBtfbwAKCRB4tDGHoIJi 0pW5AP4sHlVNJzb8DmPK+viV8n2vJxaAVsOvy2tUnwmOz57/gAEAwQTj9bHJRivx riPjP0SyuiPaqRz6C2g1689jApajxwY= =3YZf -----END PGP SIGNATURE----- --J4ue+fmAfy7X0A4F--