Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <71b0d889-85ef-3f20-3358-c351be97ce84@intel.com>
Date:   Wed, 22 Mar 2023 13:34:29 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.9.0
Subject: Re: [PATCH v8 0/6] Some improvements of resctrl selftest
Content-Language: en-US
From:   Reinette Chatre <reinette.chatre@intel.com>
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20230215083230.3155897-1-tan.shaopeng@jp.fujitsu.com>
 <7dcfc21e-9a17-65b1-6206-374cadb79973@intel.com>
In-Reply-To: <7dcfc21e-9a17-65b1-6206-374cadb79973@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFdNRExIKzZ1K2ZXeHJ0TVNIaThSRkNBN0xZRTRqR0pwSGpObVBnaWlJQWZm?=
 =?utf-8?B?ZUtLaXpXZFdVdXNRUlVlRTJSb2FFVFJoZHdkOGJvV3lycUhjWXJSbElHNGI1?=
 =?utf-8?B?VnZaR1RHVkpFcXBqLy9jWXhISWlxVmlLa2ZxUENYVkRQa0dXclZZV1RlZmxD?=
 =?utf-8?B?N0s2Rys3dk9vM2wzd3NIcUlKZ2FHMW1sZ2I5eDhJZHV2V0lrRkdxQ0d5UE1u?=
 =?utf-8?B?Ymc5cEhkd2RVUDVJOVhURzg5QThQQzBZOUVFY3BmMnNSUE5XczlES1FQS05n?=
 =?utf-8?B?VXZ2TEI5QnZPSXFaTTZpV2RqbVQwMFBFWDJNUUNoL1ArcjZpMEdlMnM4dDFJ?=
 =?utf-8?B?SWl3TkRQTTVDTldWUy9ma2szQUZYQjBKM1RCTmhlRmxFZ0tXdkgrR2tHWUI2?=
 =?utf-8?B?allpRnc1L1NDY0hjcFFtaDVWcUdvMjgvbG93eHpxMWNxUWhxbGFpek5uQk5i?=
 =?utf-8?B?bUQ3QXJITDZiZVRsQ2lvWGFaK1ZjYUdXNlBnZHV3ZDdWbHBudm9JeHY4OVRN?=
 =?utf-8?B?OG0zRHZPeGtkMFJoZlhyNFdrYzRjZHZhWU1Xa3JLOXRySCtrb2lPekVJTFZJ?=
 =?utf-8?B?UjNUbyt1Zm5xTko1SmlNakhMbTZ3NXZ5QnhmbDRzbE8wS21OUHU0Ni9KamF1?=
 =?utf-8?B?dnNGeHI5aE14WHRNUUFpNzBUU3V6cWh0SmlUaG9BZ3lBekpiZHhqUzNQNlVx?=
 =?utf-8?B?RWEvTTNmT0xLbGdOQ04vY0hraE10TDVvSFpNdlpnWnVMUExMOGt5cVJqUWdL?=
 =?utf-8?B?RUNJRG9HUkNXTmw2eDdHbVJHVkJ5NWlnMmxYTGl0WmN2MU1xM3o5enBmSFow?=
 =?utf-8?B?eVR6WmkrcEtaMTdyNnJsemZMaVNpVjM4b01BeWV6U0hCdWw5YVFmdnFnVnRM?=
 =?utf-8?B?bDFaUFdxUEJtaEVOaU9PdE55dGpxSjM2VTlSd2x5QlVmWjRVcS9TcHJMblYx?=
 =?utf-8?B?ME5oNEdsWkExdUYySjRDZTQ5UlNFSndRRFlYWFlTS1gwSVJWaXl2c2lMT2RL?=
 =?utf-8?B?aGs2bjdmNkl3QlFFZXdHOXpLMUhTV240dHJ3R0R5VzQvSE9QWTZza0l3SWZq?=
 =?utf-8?B?TkRVZ0grU1FHWjlNZ2c2bkN2aXVlSE5xY2JIQmw0VkZycGc3UmZGNnlrVUFo?=
 =?utf-8?B?VVN6eE8rMmc0bkxPTE9Hb04rUVBqcUF6cmdsbXhUQUU4b1VOTm8wTC9mWllz?=
 =?utf-8?B?OS9GenduNmFxakRzL1lqUEFnVXFzc3R4WHhYWXZnNW1WcUhwUGg2czRWR3Q0?=
 =?utf-8?B?bmpwOHp6ZTV1Y24rYmYvNTA5UGQ4bi84MStLNXFjYlpyT2lTakhCbEdRbWcy?=
 =?utf-8?B?bWZrRVJjMGN5UHhEblFTN3AreHBrb1ZkMzkyVTZXdTg3Y1ExdzdxbVJUbGpI?=
 =?utf-8?B?citZai91MEJIQlpGQ20xd2NTMzlqeG95QmY1TDlMeEdib2tFaHozdXMvTStI?=
 =?utf-8?B?RU9IS201NURhbFBGbGxoVFE3b0pEdnE3bGFMbU1Tb1hmYzhtSG5jUTZOUUts?=
 =?utf-8?B?eW9CeEM5aWgyU29wSG1yeWJIaHluOEZiV3k5ZW1PdTVVbGhaRS8rQVFwTUZW?=
 =?utf-8?B?ZkpmYWhsb2hqK2ZzWXB0c3NmeHpYdTJibnZHQVRhSlA3YXVuU0x3VDZjd3dX?=
 =?utf-8?B?K1VObFBTS1cwNmltWGltR0tWSDNvUHpGSDZlcjFYazMrREFCQ3JpdmZxQ0tz?=
 =?utf-8?B?VE4wVzFBQU5oWHFFVFNpR1c1SVRXMVM0TjlYb09zWjNkL0ZKZG9iNmpYRFZZ?=
 =?utf-8?B?M2dHSXNWU1RlQS9QYU9uYkQ0WVlSYndlYUVQczhkMUtyZUl1d0djZ0liTVVL?=
 =?utf-8?B?eTZBMks2aEpnNHJZYnZwdzJPU3c0OCswYkQyTjQrMUIwK2xNYUdBbEVFVkxS?=
 =?utf-8?B?RmgxK0lpMzQycWhUVjMrMVY5eHFpRC9hbEh6VVJ0Z0ZFNVpqVGlzVXVLSkF6?=
 =?utf-8?B?RFdaYkhCcTJOOTZBNXd6OTYzY1BhcDJiNUJiWDAxMENSeE5Bd1d4ZER1Rm1y?=
 =?utf-8?B?dGJGRlFFeXUyRGhZR3c3ZkdlUFdRak5vZUlSU0xDY0tlRFpmMEs2QUcwQ0xh?=
 =?utf-8?B?ZFdpOWtKSlJybUpvU0R4em91bzIwZk1XQlcxaGN5VkF1RG5wa0p6NGJ1c2NG?=
 =?utf-8?B?TWhoR3FGUDE1TDM5V2lQbWEwaHBnaS8rTzhyeFg4L01wdWdwR2FWZ2d6UGtF?=
 =?utf-8?B?d2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 911ca887-25ba-4d3c-2075-08db2b14d8a9
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 20:34:34.0016
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Me6CR8JT1C1ovYWAGsQBKdW0UWRJWO+2DJnbqPtN/mboZSrS0VO2uW+1cxG8qeE/cbijhvK5t9Bli/C0AFtCUOeGqpyvnmXKEpDX0VXe6KA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7511
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+x86 maintainers

Dear kselftest and x86 maintainers,

I am wondering about the appropriate path for this series and
also other pending resctrl selftest patches. Would you prefer it
routed via x86 or kselftest? If x86 I expect that we have to do
a better job of including x86 maintainers in all resctrl
selftest patch reviews.

Reinette

On 3/10/2023 2:25 PM, Reinette Chatre wrote:
> Hi Shuah,
> 
> Could you please consider taking this series in via the 
> linux-kselftest tree?
> 
> Thank you very much
> 
> Reinette
> 
> On 2/15/2023 12:32 AM, Shaopeng Tan wrote:
>> Hello,
>>
>> The aim of this patch series is to improve the resctrl selftest.
>> Without these fixes, some unnecessary processing will be executed
>> and test results will be confusing. 
>> There is no behavior change in test themselves.
>>
>> [patch 1] Make write_schemata() run to set up shemata with 100% allocation
>> 	  on first run in MBM test.
>> [patch 2] The MBA test result message is always output as "ok",
>> 	  make output message to be "not ok" if MBA check result is failed.
>> [patch 3] When a child process is created by fork(), the buffer of the 
>> 	  parent process is also copied. Flush the buffer before
>> 	  executing fork().
>> [patch 4] An error occurs whether in parents process or child process,
>> 	  the parents process always kills child process and runs
>> 	  umount_resctrlfs(), and the child process always waits to be
>> 	  killed by the parent process.
>> [patch 5] If a signal received, to cleanup properly before exiting the
>> 	  parent process, commonize the signal handler registered for 
>> 	  CMT/MBM/MBA tests and reuse it in CAT, also unregister the 
>> 	  signal handler at the end of each test.
>> [patch 6] Before exiting each test CMT/CAT/MBM/MBA, clear test result 
>> 	  files function cat/cmt/mbm/mba_test_cleanup() are called
>> 	  twice. Delete once.
>>
>> This patch series is based on Linux v6.2-rc7.
>>
>> Difference from v7:
>> [patch 4] 
>>   - Fix commitlog.
>> [patch 5]
>>   - Fix commitlog.
>>
>> Pervious versions of this series:
>> [v1] https://lore.kernel.org/lkml/20220914015147.3071025-1-tan.shaopeng@jp.fujitsu.com/
>> [v2] https://lore.kernel.org/lkml/20221005013933.1486054-1-tan.shaopeng@jp.fujitsu.com/
>> [v3] https://lore.kernel.org/lkml/20221101094341.3383073-1-tan.shaopeng@jp.fujitsu.com/
>> [v4] https://lore.kernel.org/lkml/20221117010541.1014481-1-tan.shaopeng@jp.fujitsu.com/
>> [v5] https://lore.kernel.org/lkml/20230111075802.3556803-1-tan.shaopeng@jp.fujitsu.com/
>> [v6] https://lore.kernel.org/lkml/20230131054655.396270-1-tan.shaopeng@jp.fujitsu.com/
>> [v7] https://lore.kernel.org/lkml/20230213062428.1721572-1-tan.shaopeng@jp.fujitsu.com/
>>
>> Shaopeng Tan (6):
>>   selftests/resctrl: Fix set up schemata with 100% allocation on first
>>     run in MBM test
>>   selftests/resctrl: Return MBA check result and make it to output
>>     message
>>   selftests/resctrl: Flush stdout file buffer before executing fork()
>>   selftests/resctrl: Cleanup properly when an error occurs in CAT test
>>   selftests/resctrl: Commonize the signal handler register/unregister
>>     for all tests
>>   selftests/resctrl: Remove duplicate codes that clear each test result
>>     file
>>
>>  tools/testing/selftests/resctrl/cat_test.c    | 29 ++++----
>>  tools/testing/selftests/resctrl/cmt_test.c    |  7 +-
>>  tools/testing/selftests/resctrl/fill_buf.c    | 14 ----
>>  tools/testing/selftests/resctrl/mba_test.c    | 23 +++----
>>  tools/testing/selftests/resctrl/mbm_test.c    | 20 +++---
>>  tools/testing/selftests/resctrl/resctrl.h     |  2 +
>>  .../testing/selftests/resctrl/resctrl_tests.c |  4 --
>>  tools/testing/selftests/resctrl/resctrl_val.c | 67 ++++++++++++++-----
>>  tools/testing/selftests/resctrl/resctrlfs.c   |  5 +-
>>  9 files changed, 96 insertions(+), 75 deletions(-)
>>