Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Mar 2023 21:56:28 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Alex Elder <elder@linaro.org>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, caleb.connolly@linaro.org, mka@chromium.org,
        evgreen@chromium.org, andersson@kernel.org,
        quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com,
        quic_jponduru@quicinc.com, quic_subashab@quicinc.com,
        elder@kernel.org, netdev@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: ipa: add IPA v5.0 to ipa_version_string()
Message-ID: <ZBtrfLOh3EKBKW+F@corigine.com>
References: <20230322144742.2203947-1-elder@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230322144742.2203947-1-elder@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?R9dZawu/PKqIpSXn+ghYBYemlLF34EsFyiL3SjrJ7FRZLBHDv4M3uG87hFYN?=
 =?us-ascii?Q?MWV4oWrDaw0ugxXtxjOhty3jfTaiyaqTtBwp+n2VGkFznDOFJyMEYbOiaRhg?=
 =?us-ascii?Q?A8e5GYxGmcwCeaOOq22r/QjEQs2+TczHugDv8sPlW2knR3cO6crmRVMQWpFc?=
 =?us-ascii?Q?d5HElpIJVcaOb0/tWyaDWg+B519mjaHKMDzRB7F2Uf0rIoEM5HznW7yzPRY6?=
 =?us-ascii?Q?uT+EyQ7ywk+lfahNQm+amkeckUFqk5AQDIHYQKYT9feXQKIRIJEpYh2xDc82?=
 =?us-ascii?Q?Vm5hON7/wBuaoEoitIEhGWIZA6iyvxNy+9i30OXMz2WmdHsMBcmaUhsyn3Wd?=
 =?us-ascii?Q?NAiwwrpSsteYfuZRxt1ZmGuHzn3Zp8FwcYQi/TJqFjw17rjyBT8vbcCQ3B2N?=
 =?us-ascii?Q?DoGyzm0smYxDxpWS8+0yTbO04jF2XU9TQIGOY50aCDeQAsCP/03i6vY7Q6Qj?=
 =?us-ascii?Q?Yyi0hwP42I/hCTy+Gb8KeFN/sKunV/D644dZLROK+PxqSgB+KszO4cy1QHo6?=
 =?us-ascii?Q?/nFqfE1I9rTuviM4VDB3DkyBLBwPHkAw54JRJgn4EsKzgoV+XssOmb3BhrWq?=
 =?us-ascii?Q?BYSepNYgWAspwRawWGPmWsGbF6vjU0TXiPh7jU2jq6a6SYp/f6jEEQxJLC7s?=
 =?us-ascii?Q?0voNIjDqvgLXdc4KHzgQoh3bZbSx7vNbhj++2kF5GLSPzgBQkFPHhDdM/n1v?=
 =?us-ascii?Q?4wDRm4MSbz8/V9yx+PwD9T0x5oCjCQEP6utNydb4nrW3yWdqQHS3HJbMXlqj?=
 =?us-ascii?Q?BcWZgEivD5hNtr9KdM3hLJsN79XJssHE3yxA6yqd2t2mMlyBmmlJufStMpXn?=
 =?us-ascii?Q?U4cAXn9gFry4uxJlsliR4Ekob7+O9Mr1bADB6IqRK76Z/cXWVO9u4FYrAXnU?=
 =?us-ascii?Q?+R7Pz+faYYItd59gX09a69spUYMes4pdHaH5UGEXmkh6kQ7j/QTk/o1VINiw?=
 =?us-ascii?Q?XP45e/VLlXDP16rxewr3idLBuio634gMB50ARxo3+z86b3AAqWZQLMBFDpIQ?=
 =?us-ascii?Q?iDlOhbqdtT7byTDcdXjC89bjtyeNsFOSqgSnr0le290EbVoKWl89PzobfzFY?=
 =?us-ascii?Q?XJxXwt5yrqq2ruJTmSzjezHczsdlvsgo9RmFg4g2gov19+UVD7cjTfQtkikF?=
 =?us-ascii?Q?lgtnJN75icOFWBpaHGgESEZKAgzKjD/cmKx7VRPgx21qqoJz3oNYsVsqsG1D?=
 =?us-ascii?Q?JbSmLjtdpBjn4UXLRESOAQYNasBC7RXfxTCFvs/1KJWU/4+01p8CMz9Z4eKE?=
 =?us-ascii?Q?RluvxOuKUmyQXskDtf3n28wN7uVU5acRto/2LqMTmWTHiQTqHH0dYDVd2W7w?=
 =?us-ascii?Q?Dsv3SgscF1aPE3Z3wNuEKvqksfUX4N4SGOf7BzMHKWdhU9Uhu+UlKQcnLceD?=
 =?us-ascii?Q?iGQ540gddD0UYUMyfGM/yDTezLdqJBucVoXSB8oRGuWoTlareLqcfCreV50D?=
 =?us-ascii?Q?CSHPF9r0G+G4+lHWyzicF9Mf15LAdREC4BJ4dIeiUXzNhs4KQ7EE0AhWMJnR?=
 =?us-ascii?Q?ifADqog75fKljeFO5eH7BruxquP4sQvMXGTRDnCVCbb+UXKky40rlS/rRWPg?=
 =?us-ascii?Q?+xONz+Hg3MDkkNYVlL5oUCa+YVlvSGHykuGxA0IwUmFGXODWo8zizf19Xiy9?=
 =?us-ascii?Q?fOcuG28euhgtAAT1A3a558y2F7Ia9f8S06YfECVrh4LjJgZYe26jfWdyVe2m?=
 =?us-ascii?Q?AapmxQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abf4f003-6195-4ec2-98ca-08db2b17edad
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 20:56:37.6751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LFa1yb58ATk2RkiiRAJsiDbjVkcUzxessd4faGvyyrox2kBF71xqUHWhjP9C8kDEeOY8wA1MNTRcH9jtm0I217xhAtGPMHz6YxjdfGP/1rE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3623
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 22, 2023 at 09:47:42AM -0500, Alex Elder wrote:
> In the IPA device sysfs directory, the "version" file can be read to
> find out what IPA version is implemented.  The content of this file
> is supplied by ipa_version_string(), which needs to be updated to
> properly handle IPA v5.0.
> 
> Signed-off-by: Alex Elder <elder@linaro.org>

Hi Alex,

this patch looks fine. But I am curious.
Should IPA_VERSION_5_1 and IPA_VERSION_5_5 also be added?

> ---
> This should have been included in the previous series...
> 
>  drivers/net/ipa/ipa_sysfs.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ipa/ipa_sysfs.c b/drivers/net/ipa/ipa_sysfs.c
> index 14bd2f9030453..2ff09ce343b73 100644
> --- a/drivers/net/ipa/ipa_sysfs.c
> +++ b/drivers/net/ipa/ipa_sysfs.c
> @@ -36,6 +36,8 @@ static const char *ipa_version_string(struct ipa *ipa)
>  		return "4.9";
>  	case IPA_VERSION_4_11:
>  		return "4.11";
> +	case IPA_VERSION_5_0:
> +		return "5.0";
>  	default:
>  		return "0.0";	/* Won't happen (checked at probe time) */
>  	}
> -- 
> 2.34.1
>