Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp6731250rwl; Wed, 22 Mar 2023 14:59:04 -0700 (PDT) X-Google-Smtp-Source: AK7set/iU1pRn3PRf9DAqcumpX/ZVbT6HH+NAI/t4vl8Roe/e3tbZ2umxzSlvNcXiOxSgboBnMCZ X-Received: by 2002:a17:907:a4c3:b0:93a:219d:b167 with SMTP id vq3-20020a170907a4c300b0093a219db167mr7644398ejc.52.1679522344180; Wed, 22 Mar 2023 14:59:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679522344; cv=none; d=google.com; s=arc-20160816; b=epJmDFZSN1GQu/j6UajJj9Aebj/ETcq//AlWTEZOk++R0E4HTqiF5DkWS/klpXImv0 uzGBQLs+UKUX1Xg7+4xUopumCxV0idCwQzZo6+AWtdDMj0vS9ZKJY5gcLq2ryf2OfDrI sD8oLb1dgpawdqwt0rq+fptBSP1JC99eppV1T3h54BlK5PqzeGtjmlQ0UVGIPFQEWthS bw1jdI8WDCWXvmhSvo8blXg3ecVbvRXDtD3J/aYzNb1e6N6WKeji1TGFjhC6wUOphNLD 5an8bYGCZ1dMNLH2nsALAxSjL9g+EWjI/cNjqwki0+kScCIQ73KaA5BD/RhcbpfFziRT 1naw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=9PZ8LbgL1GCJ0WhsAnJBQpBWwgIIWREQb1ysFBtLIlU=; b=kG+oIGYaUL8q4wfBXz2P4YagZBhqOvRQoWg0YZxusP33EDAWtKqltFPzxstSQTFCIu YA8VuELpxsLIIZsoizBUYVvba5bIiQdrBoXQCQiD7hWw5+4Uei/tiM9A6dcSae+xf6SU 9uyF2OeJ/W3+DQIwByw9Z6+SlEFVgFsCT/3fNClPt6NPHFfZsaPlzL7RhgaphlrKcm5U /nxMfsbNa3+0kWsKBSmJ7PmHHU2tPwTROvMavou+L/3H5YSHvn4Qtv/+2wOXZ8+TGL3W ayQ5eItvQPJhwFX3WL4bs7FKmm8pA0P/e9561sfUx14MeE+xd1WwvWOZoQycAcL2L1Ll 2Log== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NdzjacQV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id du12-20020a17090772cc00b00931f00ca4e3si18274968ejc.779.2023.03.22.14.58.40; Wed, 22 Mar 2023 14:59:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NdzjacQV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229508AbjCVV6f (ORCPT + 99 others); Wed, 22 Mar 2023 17:58:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229725AbjCVV6e (ORCPT ); Wed, 22 Mar 2023 17:58:34 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFFF7E1AA for ; Wed, 22 Mar 2023 14:58:32 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id eg48so78728524edb.13 for ; Wed, 22 Mar 2023 14:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679522311; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9PZ8LbgL1GCJ0WhsAnJBQpBWwgIIWREQb1ysFBtLIlU=; b=NdzjacQVjFpDskaHW+X0rKQ4vy5A/Puc1twYGKSURN1B2J1KXe9htTqg1n+Qp30ZuN ovVmb+K02bM3JmPQGUY8jhSfhQTv0+MEQ4Q+HoZWij79QEgzGXaRgajZR8HVphqVid0k 1rosoaOwraP4Ewa1O6HZ04aj7kE9WFr4n2aq6K3gDX28h1m4LuJet7s5q6ydHpSf2KMl pZK/tlj9fObsgQUQyJm4IvtHcnepzb1Vn0bFkjBcTrlG0lFnkJK0cV7EsH5omIY6arz+ jXToux6DQHVe4w+i4iWNIiPXbrS7XPAzBmJpa7Mz/Wl5/lWAb5Ya7ClWSBerkZ2Ggru/ JpsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679522311; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9PZ8LbgL1GCJ0WhsAnJBQpBWwgIIWREQb1ysFBtLIlU=; b=dc/Wru2Csst/0S413c7iI41NhkFqDlFTWyTO8M1Al4rQ9Nl8NEv2iQSOI1Hxjetelh 9T8dGM7JU+pfhDRtEJSOrTVUdF6i3liNSp2eUMX/ZQnmDgUlZhJ5JM7a+Djn4UmQYjfy smn41Qh418J0v5+shDoJxFr/r9R5aEckZIxSl+mDap0+9VwYNB5VzPua3IthWzwLT+wt ewijSoNzF04/wcFsuT1SWCyW5ATHEO+4anbYcrSoOG6olFA9GHYNkCdKGV1Wan1lKvKR U/gA37XG+MPvNYIyTfJX0qHWgg4TgOKcqC9AlQCzWQOHrhg7GQ3ByMNSMu37zqmKp/sV uFEA== X-Gm-Message-State: AO0yUKVzv4iA78BUoCuAaVTaPGeX3/qEGGTMPUTR0k1iBIl6t2uQf9VV 2SdSKsvHYraTHxyze6oFNJisNg== X-Received: by 2002:a17:906:23e9:b0:926:9c33:ea4 with SMTP id j9-20020a17090623e900b009269c330ea4mr7317722ejg.27.1679522310723; Wed, 22 Mar 2023 14:58:30 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:626d:5729:6e71:4c22? ([2a02:810d:15c0:828:626d:5729:6e71:4c22]) by smtp.gmail.com with ESMTPSA id g26-20020a1709064e5a00b00930525d89e2sm7690989ejw.89.2023.03.22.14.58.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 14:58:30 -0700 (PDT) Message-ID: <2aa37662-c111-0388-9002-387b9340f1a2@linaro.org> Date: Wed, 22 Mar 2023 22:58:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 1/6] dt-bindings: mfd: Add the Lantiq PEF2256 E1/T1/J1 framer Content-Language: en-US To: Herve Codina , Lee Jones , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Christophe Leroy , Thomas Petazzoni References: <20230322134654.219957-1-herve.codina@bootlin.com> <20230322134654.219957-2-herve.codina@bootlin.com> From: Krzysztof Kozlowski In-Reply-To: <20230322134654.219957-2-herve.codina@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/03/2023 14:46, Herve Codina wrote: > The Lantiq PEF2256 is a framer and line interface component designed to > fulfill all required interfacing between an analog E1/T1/J1 line and the > digital PCM system highway/H.100 bus. > > + lantiq,channel-phase: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1, 2, 3, 4, 5, 6, 7] > + default: 0 > + description: > + The pef2256 delivers a full frame (32 8bit time-slots in E1 and 24 8bit > + time-slots 8 8bit signaling in E1/J1) every 125us. This lead to a data > + rate of 2048000 bit/s. When lantiq,data-rate-bps is more than 2048000 > + bit/s, the data (all 32 8bit) present in the frame are interleave with > + unused time-slots. The lantiq,channel-phase property allows to set the > + correct alignment of the interleave mechanism. > + For instance, suppose lantiq,data-rate-bps = 8192000 (ie 4*2048000), and > + lantiq,channel-phase = 2, the interleave schema with unused time-slots > + (nu) and used time-slots (XX) for TSi is > + nu nu XX nu nu nu XX nu nu nu XX nu > + <-- TSi --> <- TSi+1 -> <- TSi+2 -> > + With lantiq,data-rate-bps = 8192000, and lantiq,channel-phase = 1, the > + interleave schema is > + nu XX nu nu nu XX nu nu nu XX nu nu > + <-- TSi --> <- TSi+1 -> <- TSi+2 -> > + With lantiq,data-rate-bps = 4096000 (ie 2*2048000), and > + lantiq,channel-phase = 1, the interleave schema is > + nu XX nu XX nu XX > + <-- TSi --> <- TSi+1 -> <- TSi+2 -> > + > + lantiq,subordinate: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + If present, the pef2256 works in subordinate mode. In this mode it > + synchronizes on line interface clock signals. Otherwise, it synchronizes > + on internal clocks. > + > +patternProperties: > + '^codec([0-9]|[1-2][0-9]|3[0-1])?$': > + $ref: /schemas/sound/lantiq,pef2256-codec.yaml Does not look bisectable. I also could not find in commit msg or in cover letter description of patch merging requirements. > + > +allOf: allOf goes usually after required, just like in example-schema. Best regards, Krzysztof