Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: Y5uvfMVcqHPsfatka/j6AyJ5hMzKchW8PgXqqK6v5az4zarZ6thGVLxMfEts1IuKIBq2sy8Mgv
 w1WQgKhGWVwIU76jn3Zua/ZiVQdPK/tAjf5O1AYdyhZZFe10Dd8NooND5MCX15djppQFnvbsOf
 cFEa6cmVvZ5u3OGWATRGkDVOZ0QPGooCVNh+9KvnyPRggX8s94kWO+oTQwHwF6olM+bnjBVGt8
 ntDxxUU4ywo02yMAYEq1C6GPszw40KfZg4b3coQy9rMuRGTFBBZ+pfPXFYgvx3NPt3eh6/r9eJ
 wac=
IronPort-SDR: TET2YpgVoi4t4TQvdUWba6shHEi8bzUJ7lm2w+PzISLNervvGFvw1B0EGjDRg1yD8xAh8ZZpW9
 dlAT5OoeSVSqduH+06bCUo/Tv5t/zFa4KLi59X0aFEUl7VpkKWCvoAmVPYR5eA4iadUzpXZ2nv
 GAsv2KPVfAqxj7s9rhuoDx8IabOs5oFuHyPkU2+7tKAumNJDOIOUJV1olz2NFnIQKyB4dXaIJO
 4SG6b+p2pxWW3Pjm31bqxgYIcEkqH1LByvqnNUrcPKntF461Sy5d21UGsOxpJrQrVGfssQ0HSd
 VFs=
WDCIronportException: Internal
Message-ID: <e717267b-6dc2-5018-01f1-143fe1bf0793@opensource.wdc.com>
Date:   Thu, 23 Mar 2023 07:34:33 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH 00/32] pata_parport-bpck6: rework bpck6 protocol driver
To:     Ondrej Zary <linux@zary.sk>, Sergey Shtylyov <s.shtylyov@omp.ru>
Cc:     Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
        Tim Waugh <tim@cyberelk.net>, linux-block@vger.kernel.org,
        linux-parport@lists.infradead.org, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230307224627.28011-1-linux@zary.sk>
 <202303181955.41922.linux@zary.sk>
 <d16b4b27-f1d3-bf05-e062-516e7c708fa2@omp.ru>
 <202303221310.44235.linux@zary.sk>
Content-Language: en-US
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <202303221310.44235.linux@zary.sk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/22/23 21:10, Ondrej Zary wrote:
> On Sunday 19 March 2023 21:02:43 Sergey Shtylyov wrote:
>> On 3/18/23 9:55 PM, Ondrej Zary wrote:
>>
>>>>> This patch series simplifies bpck6 code, removing ppc6lnx.c file to match
>>>>> the simplicity of other protocol drivers. It also converts the direct
>>>>> port I/O access to paraport access functions. This conversion revealed that
>>>>> there's no 8-bit and 16-bit EPP support in parport_pc so patch 11 implements
>>>>> that.
>>>>>
>>>>> Tested with Backpack CD-RW 222011 and CD-RW 19350.
>>>>>
>>>>> Signed-off-by: Ondrej Zary <linux@zary.sk>
>>>>> ---
>>>>>  drivers/ata/pata_parport/bpck6.c   | 452 +++++++++++++++++++++++++++--------
>>>>>  drivers/ata/pata_parport/ppc6lnx.c | 726 ---------------------------------------------------------
>>>>>  drivers/parport/parport_pc.c       |  20 +-
>>>>>  include/uapi/linux/parport.h       |   3 +
>>>>>  4 files changed, 370 insertions(+), 831 deletions(-)
>>>>
>>>>    OK, it's finally clear I can't keep up with reviewing 32 patches posted
>>>> at once...  Luckily, all those patches seem to be dealing with parallel port
>>>> control), not the PATA control! Of course, when I volunteered to review the
>>>> PATA driver patches, I didn't expect such patch volumes -- I mostly expected
>>>> some odd fixes, not a massive driver rework... :-/
>>>
>>> So you're going to review the (P)ATA parts (if any) only.
>>
>>    I saw no PATA parts in this patcheset...
>>
>>> Maybe Sudip (as parport maintainer) could review the parallel port parts?
>>
>>    I have no objections! :-)
> 
> Looks like Sudip does not care. What needs to be done so this can be merged?

I will have a look at the series this morning and merge it if I do not see any
issues.


-- 
Damien Le Moal
Western Digital Research